Title: [286648] trunk/Source
- Revision
- 286648
- Author
- [email protected]
- Date
- 2021-12-08 01:54:25 -0800 (Wed, 08 Dec 2021)
Log Message
[GStreamer] Enable mediaSourceInlinePainting
https://bugs.webkit.org/show_bug.cgi?id=233813
Patch by Philippe Normand <[email protected]> on 2021-12-08
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Covered by http/tests/media/media-source/mediasource-rvfc.html
* page/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::setMediaSourceInlinePaintingEnabled):
* page/RuntimeEnabledFeatures.h:
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::mediaSourceInlinePaintingEnabled const):
Source/WTF:
* Scripts/Preferences/WebPreferencesExperimental.yaml: GStreamer ports can already run tests
requiring this setting, without change in the platform layer, until we migrate to the
GPUProcess.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (286647 => 286648)
--- trunk/Source/WTF/ChangeLog 2021-12-08 08:55:35 UTC (rev 286647)
+++ trunk/Source/WTF/ChangeLog 2021-12-08 09:54:25 UTC (rev 286648)
@@ -1,3 +1,14 @@
+2021-12-08 Philippe Normand <[email protected]>
+
+ [GStreamer] Enable mediaSourceInlinePainting
+ https://bugs.webkit.org/show_bug.cgi?id=233813
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * Scripts/Preferences/WebPreferencesExperimental.yaml: GStreamer ports can already run tests
+ requiring this setting, without change in the platform layer, until we migrate to the
+ GPUProcess.
+
2021-12-07 Aditya Keerthi <[email protected]>
[iOS] Add initial support for find-in-page SPI
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (286647 => 286648)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-12-08 08:55:35 UTC (rev 286647)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-12-08 09:54:25 UTC (rev 286648)
@@ -887,7 +887,7 @@
type: bool
humanReadableName: "Experimental MediaSource Inline Painting"
humanReadableDescription: "Experimental MediaSource Inline Painting"
- condition: ENABLE(MEDIA_SOURCE) && HAVE(AVSAMPLEBUFFERVIDEOOUTPUT)
+ condition: ENABLE(MEDIA_SOURCE) && (HAVE(AVSAMPLEBUFFERVIDEOOUTPUT) || USE(GSTREAMER))
webcoreBinding: RuntimeEnabledFeatures
defaultValue:
WebKitLegacy:
Modified: trunk/Source/WebCore/ChangeLog (286647 => 286648)
--- trunk/Source/WebCore/ChangeLog 2021-12-08 08:55:35 UTC (rev 286647)
+++ trunk/Source/WebCore/ChangeLog 2021-12-08 09:54:25 UTC (rev 286648)
@@ -1,3 +1,18 @@
+2021-12-08 Philippe Normand <[email protected]>
+
+ [GStreamer] Enable mediaSourceInlinePainting
+ https://bugs.webkit.org/show_bug.cgi?id=233813
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ Covered by http/tests/media/media-source/mediasource-rvfc.html
+
+ * page/RuntimeEnabledFeatures.cpp:
+ (WebCore::RuntimeEnabledFeatures::setMediaSourceInlinePaintingEnabled):
+ * page/RuntimeEnabledFeatures.h:
+ * testing/InternalSettings.cpp:
+ (WebCore::InternalSettings::mediaSourceInlinePaintingEnabled const):
+
2021-12-08 Diego Pino Garcia <[email protected]>
REGRESSION(r286556): DeviceOrientationUpdateProvider.h is only available in iOS
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp (286647 => 286648)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp 2021-12-08 08:55:35 UTC (rev 286647)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp 2021-12-08 09:54:25 UTC (rev 286648)
@@ -81,11 +81,13 @@
}
#endif
-#if ENABLE(MEDIA_SOURCE) && HAVE(AVSAMPLEBUFFERVIDEOOUTPUT)
+#if ENABLE(MEDIA_SOURCE) && (HAVE(AVSAMPLEBUFFERVIDEOOUTPUT) || USE(GSTREAMER))
void RuntimeEnabledFeatures::setMediaSourceInlinePaintingEnabled(bool isEnabled)
{
m_mediaSourceInlinePaintingEnabled = isEnabled;
+#if HAVE(AVSAMPLEBUFFERVIDEOOUTPUT)
MediaSessionManagerCocoa::setMediaSourceInlinePaintingEnabled(isEnabled);
+#endif
}
#endif
Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (286647 => 286648)
--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2021-12-08 08:55:35 UTC (rev 286647)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h 2021-12-08 09:54:25 UTC (rev 286648)
@@ -246,7 +246,7 @@
bool webAuthenticationModernEnabled() const { return m_areWebAuthenticationModernEnabled; }
#endif
-#if ENABLE(MEDIA_SOURCE) && HAVE(AVSAMPLEBUFFERVIDEOOUTPUT)
+#if ENABLE(MEDIA_SOURCE) && (HAVE(AVSAMPLEBUFFERVIDEOOUTPUT) || USE(GSTREAMER))
WEBCORE_EXPORT void setMediaSourceInlinePaintingEnabled(bool);
bool mediaSourceInlinePaintingEnabled() const { return m_mediaSourceInlinePaintingEnabled; }
#endif
@@ -392,7 +392,7 @@
bool m_areWebAuthenticationModernEnabled { false };
#endif
-#if ENABLE(MEDIA_SOURCE) && HAVE(AVSAMPLEBUFFERVIDEOOUTPUT)
+#if ENABLE(MEDIA_SOURCE) && (HAVE(AVSAMPLEBUFFERVIDEOOUTPUT) || USE(GSTREAMER))
bool m_mediaSourceInlinePaintingEnabled { false };
#endif
Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (286647 => 286648)
--- trunk/Source/WebCore/testing/InternalSettings.cpp 2021-12-08 08:55:35 UTC (rev 286647)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp 2021-12-08 09:54:25 UTC (rev 286648)
@@ -441,7 +441,7 @@
bool InternalSettings::mediaSourceInlinePaintingEnabled() const
{
-#if ENABLE(MEDIA_SOURCE) && HAVE(AVSAMPLEBUFFERVIDEOOUTPUT)
+#if ENABLE(MEDIA_SOURCE) && (HAVE(AVSAMPLEBUFFERVIDEOOUTPUT) || USE(GSTREAMER))
return RuntimeEnabledFeatures::sharedFeatures().mediaSourceInlinePaintingEnabled();
#else
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
