Title: [286653] trunk/Source/WebCore
Revision
286653
Author
[email protected]
Date
2021-12-08 07:31:39 -0800 (Wed, 08 Dec 2021)

Log Message

REGRESSION(r286603) [GTK][WPE] WebGL broken after the ANGLE update.
https://bugs.webkit.org/show_bug.cgi?id=233965

Reviewed by Adrian Perez de Castro.

Covered by existing tests.

* platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:
(WebCore::ExtensionsGLOpenGLCommon::getTranslatedShaderSourceANGLE):
Remove usage of SH_UNFOLD_SHORT_CIRCUIT after last ANGLE update as
suggested by Kimmo.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (286652 => 286653)


--- trunk/Source/WebCore/ChangeLog	2021-12-08 13:51:18 UTC (rev 286652)
+++ trunk/Source/WebCore/ChangeLog	2021-12-08 15:31:39 UTC (rev 286653)
@@ -1,3 +1,17 @@
+2021-12-08  Lauro Moura  <[email protected]>
+
+        REGRESSION(r286603) [GTK][WPE] WebGL broken after the ANGLE update.
+        https://bugs.webkit.org/show_bug.cgi?id=233965
+
+        Reviewed by Adrian Perez de Castro.
+
+        Covered by existing tests.
+
+        * platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:
+        (WebCore::ExtensionsGLOpenGLCommon::getTranslatedShaderSourceANGLE):
+        Remove usage of SH_UNFOLD_SHORT_CIRCUIT after last ANGLE update as
+        suggested by Kimmo.
+
 2021-12-08  Antoine Quint  <[email protected]>
 
         'border-radius shorthand is getting expanded in WebKit

Modified: trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp (286652 => 286653)


--- trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp	2021-12-08 13:51:18 UTC (rev 286652)
+++ trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp	2021-12-08 15:31:39 UTC (rev 286653)
@@ -190,8 +190,9 @@
 
     String translatedShaderSource;
     String shaderInfoLog;
-    GCGLuint64 extraCompileOptions = SH_CLAMP_INDIRECT_ARRAY_BOUNDS | SH_UNFOLD_SHORT_CIRCUIT | SH_INIT_OUTPUT_VARIABLES | SH_ENFORCE_PACKING_RESTRICTIONS | SH_LIMIT_EXPRESSION_COMPLEXITY | SH_LIMIT_CALL_STACK_DEPTH | SH_INITIALIZE_UNINITIALIZED_LOCALS;
 
+    GCGLuint64 extraCompileOptions = SH_CLAMP_INDIRECT_ARRAY_BOUNDS | SH_INIT_OUTPUT_VARIABLES | SH_ENFORCE_PACKING_RESTRICTIONS | SH_LIMIT_EXPRESSION_COMPLEXITY | SH_LIMIT_CALL_STACK_DEPTH | SH_INITIALIZE_UNINITIALIZED_LOCALS;
+
     if (m_requiresBuiltInFunctionEmulation)
         extraCompileOptions |= SH_EMULATE_ABS_INT_FUNCTION;
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to