Title: [286659] trunk/Source/ThirdParty/ANGLE
- Revision
- 286659
- Author
- [email protected]
- Date
- 2021-12-08 09:06:45 -0800 (Wed, 08 Dec 2021)
Log Message
Avoid noisy Wcomment warnings after ANGLE update in r286603
https://bugs.webkit.org/show_bug.cgi?id=233964
<rdar://problem/86186455>
Reviewed by Michael Catanzaro.
* CMakeLists.txt: Pass also -Wno-comment when building with GCC or Clang; arrange to
set compiler flags for any of the ANGLE library targets instead of only for libANGLE.
* src/compiler/translator/tree_util/IntermTraverse.h: Revert change from 233964 to
avoid having differences with the upstream version of the file.
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (286658 => 286659)
--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt 2021-12-08 17:04:27 UTC (rev 286658)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt 2021-12-08 17:06:45 UTC (rev 286659)
@@ -243,12 +243,18 @@
endif ()
if (COMPILER_IS_GCC_OR_CLANG)
- WEBKIT_ADD_TARGET_CXX_FLAGS(ANGLE -Wno-cast-align
- -Wno-extra
- -Wno-suggest-attribute=format
- -Wno-undef
- -Wno-unused-parameter
- -Wno-return-type)
+ foreach (angle_target ANGLE EGL GLESv2)
+ if (TARGET ${angle_target})
+ WEBKIT_ADD_TARGET_CXX_FLAGS(${angle_target}
+ -Wno-cast-align
+ -Wno-extra
+ -Wno-suggest-attribute=format
+ -Wno-undef
+ -Wno-unused-parameter
+ -Wno-return-type
+ -Wno-comment)
+ endif ()
+ endforeach ()
endif ()
target_link_libraries(ANGLEFramework INTERFACE ANGLE)
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (286658 => 286659)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-12-08 17:04:27 UTC (rev 286658)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-12-08 17:06:45 UTC (rev 286659)
@@ -1,3 +1,16 @@
+2021-12-08 Adrian Perez de Castro <[email protected]>
+
+ Avoid noisy Wcomment warnings after ANGLE update in r286603
+ https://bugs.webkit.org/show_bug.cgi?id=233964
+ <rdar://problem/86186455>
+
+ Reviewed by Michael Catanzaro.
+
+ * CMakeLists.txt: Pass also -Wno-comment when building with GCC or Clang; arrange to
+ set compiler flags for any of the ANGLE library targets instead of only for libANGLE.
+ * src/compiler/translator/tree_util/IntermTraverse.h: Revert change from 233964 to
+ avoid having differences with the upstream version of the file.
+
2021-12-07 Myles C. Maxfield <[email protected]>
[MacCatalyst] Fix build after r286603
Modified: trunk/Source/ThirdParty/ANGLE/src/compiler/translator/tree_util/IntermTraverse.h (286658 => 286659)
--- trunk/Source/ThirdParty/ANGLE/src/compiler/translator/tree_util/IntermTraverse.h 2021-12-08 17:04:27 UTC (rev 286658)
+++ trunk/Source/ThirdParty/ANGLE/src/compiler/translator/tree_util/IntermTraverse.h 2021-12-08 17:06:45 UTC (rev 286659)
@@ -239,10 +239,10 @@
//
// Node 1 Node 6
// EOpIndexDirect EOpIndexDirect
- // / \ / \.
+ // / \ / \
// Node 2 Node 3 Node 7 Node 3
// EOpIndexIndirect N --> replaced with --> EOpIndexIndirect N
- // / \ / \.
+ // / \ / \
// Node 4 Node 5 Node 8 Node 5
// symbol _expression_ replacement _expression_
// ^ ^
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
