Title: [106983] trunk/Tools
- Revision
- 106983
- Author
- [email protected]
- Date
- 2012-02-07 13:37:43 -0800 (Tue, 07 Feb 2012)
Log Message
layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021
Reviewed by Dan Bernstein.
Fix race condition in repaint rect tracking. When running a test using the repaint.js
harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
the repaint test already run, thus invalidating the previously tracked repaint rects.
* DumpRenderTree/mac/DumpRenderTree.mm:
(dump):
(runTest):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (106982 => 106983)
--- trunk/Tools/ChangeLog 2012-02-07 21:37:17 UTC (rev 106982)
+++ trunk/Tools/ChangeLog 2012-02-07 21:37:43 UTC (rev 106983)
@@ -1,3 +1,21 @@
+2012-02-07 Nikolas Zimmermann <[email protected]>
+
+ layoutTestController.display() is flaky for SVG tests
+ https://bugs.webkit.org/show_bug.cgi?id=78021
+
+ Reviewed by Dan Bernstein.
+
+ Fix race condition in repaint rect tracking. When running a test using the repaint.js
+ harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
+ the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
+ hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
+ svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
+ the repaint test already run, thus invalidating the previously tracked repaint rects.
+
+ * DumpRenderTree/mac/DumpRenderTree.mm:
+ (dump):
+ (runTest):
+
2012-02-07 Hans Wennborg <[email protected]>
Chromium: remove WebSpeechInputResult::set
Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (106982 => 106983)
--- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2012-02-07 21:37:17 UTC (rev 106982)
+++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2012-02-07 21:37:43 UTC (rev 106983)
@@ -1146,10 +1146,8 @@
WebArchive *webArchive = [[mainFrame dataSource] webArchive];
resultString = HardAutorelease(createXMLStringFromWebArchiveData((CFDataRef)[webArchive data]));
resultMimeType = @"application/x-webarchive";
- } else {
- sizeWebViewForCurrentTest();
+ } else
resultString = [mainFrame renderTreeAsExternalRepresentationForPrinting:gLayoutTestController->isPrinting()];
- }
if (resultString && !resultData)
resultData = [resultString dataUsingEncoding:NSUTF8StringEncoding];
@@ -1303,6 +1301,7 @@
releaseAndZero(&draggingInfo);
done = NO;
+ sizeWebViewForCurrentTest();
gLayoutTestController->setIconDatabaseEnabled(false);
if (disallowedURLs)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
