Title: [286779] trunk/Source/ThirdParty/ANGLE
Revision
286779
Author
[email protected]
Date
2021-12-09 07:33:03 -0800 (Thu, 09 Dec 2021)

Log Message

[ANGLE] Code generation happens on each build and produces SCM diffs
https://bugs.webkit.org/show_bug.cgi?id=234025

Reviewed by Kimmo Kinnunen.

Temporarily remove the build phase that generates the
mtl_default_shaders_src_autogen files because they are producing
diffs.

We either need to generate these manually, or fix the Xcode project
to generate them into Derived Sources so they don't appear in our
repository.

* ANGLE.xcodeproj/project.pbxproj:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (286778 => 286779)


--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2021-12-09 15:07:32 UTC (rev 286778)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2021-12-09 15:33:03 UTC (rev 286779)
@@ -3513,7 +3513,6 @@
 			isa = PBXNativeTarget;
 			buildConfigurationList = FFDA50CB269F845100AE11E2 /* Build configuration list for PBXNativeTarget "ANGLEMetalLib" */;
 			buildPhases = (
-				FF194FF827443BDF006A97A3 /* ShellScript */,
 				FFDA50C3269F845100AE11E2 /* Sources */,
 			);
 			buildRules = (
@@ -3586,23 +3585,6 @@
 			shellPath = /bin/sh;
 			shellScript = "if [ \"${XCODE_VERSION_ACTUAL}\" -ge \"1140\" -a \"${WK_USE_NEW_BUILD_SYSTEM}\" = \"YES\" ]; then\n    # In this configuration, post-processing is performed at the same time as copying in the postprocess-header-rule script, so there's no need for this separate step.\n    exit 0\nfi\n\nexec \"$SRCROOT/adjust-angle-include-paths.py\"\n";
 		};
-		FF194FF827443BDF006A97A3 /* ShellScript */ = {
-			isa = PBXShellScriptBuildPhase;
-			buildActionMask = 2147483647;
-			files = (
-			);
-			inputFileListPaths = (
-			);
-			inputPaths = (
-			);
-			outputFileListPaths = (
-			);
-			outputPaths = (
-			);
-			runOnlyForDeploymentPostprocessing = 0;
-			shellPath = /bin/sh;
-			shellScript = "python scripts/run_code_generation.py -g \"Metal default shaders\"\nexit 0\n";
-		};
 		FFDA50D5269F895400AE11E2 /* Bake Metal Library to NSData */ = {
 			isa = PBXShellScriptBuildPhase;
 			buildActionMask = 2147483647;

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (286778 => 286779)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-09 15:07:32 UTC (rev 286778)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-09 15:33:03 UTC (rev 286779)
@@ -1,3 +1,20 @@
+2021-12-09  Dean Jackson  <[email protected]>
+
+        [ANGLE] Code generation happens on each build and produces SCM diffs
+        https://bugs.webkit.org/show_bug.cgi?id=234025
+
+        Reviewed by Kimmo Kinnunen.
+
+        Temporarily remove the build phase that generates the
+        mtl_default_shaders_src_autogen files because they are producing
+        diffs.
+
+        We either need to generate these manually, or fix the Xcode project
+        to generate them into Derived Sources so they don't appear in our
+        repository.
+
+        * ANGLE.xcodeproj/project.pbxproj:
+
 2021-12-08  Kyle Piddington  <[email protected]>
 
         Update ANGLE changes.diff with new roll.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to