Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (286802 => 286803)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-12-09 22:47:24 UTC (rev 286803)
@@ -1,3 +1,16 @@
+2021-12-09 Brent Fulgham <[email protected]>
+
+ Unprefix CSS value text-align: -webkit-match-parent
+ https://bugs.webkit.org/show_bug.cgi?id=229496
+ <rdar://problem/82628618>
+
+ Reviewed by Darin Adler.
+
+ Rebaseline to show new passing tests.
+
+ * web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt:
+ * web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt:
+
2021-12-09 Matt Woodrow <[email protected]>
Unprefix -webkit-mask
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt (286802 => 286803)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt 2021-12-09 22:47:24 UTC (rev 286803)
@@ -5,5 +5,5 @@
PASS Property text-align value 'right'
PASS Property text-align value 'center'
PASS Property text-align value 'justify'
-FAIL Property text-align value 'match-parent' assert_true: 'match-parent' is a supported value for text-align. expected true got false
+PASS Property text-align value 'match-parent'
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt (286802 => 286803)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt 2021-12-09 22:47:24 UTC (rev 286803)
@@ -5,6 +5,6 @@
PASS e.style['text-align'] = "right" should set the property value
PASS e.style['text-align'] = "center" should set the property value
PASS e.style['text-align'] = "justify" should set the property value
-FAIL e.style['text-align'] = "match-parent" should set the property value assert_not_equals: property should be set got disallowed value ""
+PASS e.style['text-align'] = "match-parent" should set the property value
FAIL e.style['text-align'] = "justify-all" should set the property value assert_not_equals: property should be set got disallowed value ""
Modified: trunk/Source/WebCore/ChangeLog (286802 => 286803)
--- trunk/Source/WebCore/ChangeLog 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/ChangeLog 2021-12-09 22:47:24 UTC (rev 286803)
@@ -1,3 +1,23 @@
+2021-12-09 Brent Fulgham <[email protected]>
+
+ Unprefix CSS value text-align: -webkit-match-parent
+ https://bugs.webkit.org/show_bug.cgi?id=229496
+ <rdar://problem/82628618>
+
+ Reviewed by Darin Adler.
+
+ Tested by web-platform-tests: css/css-text/parsing/text-align-computed.html,
+ css/css-text/parsing/text-align-valid.html
+
+ SSIA.
+
+ * css/CSSProperties.json: Add the unprefixed version.
+ * css/CSSValueKeywords.in: Ditto.
+ * css/html.css:
+ (li): Use the unprefixed version.
+ * style/StyleBuilderConverter.h:
+ (WebCore::Style::BuilderConverter::convertTextAlign): Handle the new unprefixed version.
+
2021-12-09 Alan Bujtas <[email protected]>
[LFC][IFC] Try not to include non-content type of inline boxes in the visual reordering
Modified: trunk/Source/WebCore/css/CSSProperties.json (286802 => 286803)
--- trunk/Source/WebCore/css/CSSProperties.json 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/css/CSSProperties.json 2021-12-09 22:47:24 UTC (rev 286803)
@@ -4501,12 +4501,16 @@
"right",
"center",
"justify",
+ {
+ "value": "match-parent",
+ "url": "https://www.w3.org/TR/css-text-3/#text-align"
+ },
"-webkit-left",
"-webkit-right",
"-webkit-center",
{
"value": "-webkit-match-parent",
- "url": "https://www.w3.org/TR/css-text-3/#text-align"
+ "url": "non-standard"
},
{
"value": "start",
Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (286802 => 286803)
--- trunk/Source/WebCore/css/CSSValueKeywords.in 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in 2021-12-09 22:47:24 UTC (rev 286803)
@@ -342,7 +342,10 @@
-webkit-left
-webkit-right
-webkit-center
+match-parent
-webkit-match-parent
+//start
+//end
//
// CSS_PROP_TEXT_JUSTIFY:
//
Modified: trunk/Source/WebCore/css/html.css (286802 => 286803)
--- trunk/Source/WebCore/css/html.css 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/css/html.css 2021-12-09 22:47:24 UTC (rev 286803)
@@ -299,7 +299,7 @@
li {
display: list-item;
- text-align: -webkit-match-parent;
+ text-align: match-parent;
}
/* FIXME: this should also match ::before::marker and ::after::marker but we don't support
Modified: trunk/Source/WebCore/style/StyleBuilderConverter.h (286802 => 286803)
--- trunk/Source/WebCore/style/StyleBuilderConverter.h 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebCore/style/StyleBuilderConverter.h 2021-12-09 22:47:24 UTC (rev 286803)
@@ -612,7 +612,7 @@
auto& primitiveValue = downcast<CSSPrimitiveValue>(value);
ASSERT(primitiveValue.isValueID());
- if (primitiveValue.valueID() != CSSValueWebkitMatchParent)
+ if (primitiveValue.valueID() != CSSValueWebkitMatchParent && primitiveValue.valueID() != CSSValueMatchParent)
return primitiveValue;
auto& parentStyle = builderState.parentStyle();
Modified: trunk/Source/WebInspectorUI/ChangeLog (286802 => 286803)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-12-09 22:47:24 UTC (rev 286803)
@@ -1,3 +1,13 @@
+2021-12-09 Brent Fulgham <[email protected]>
+
+ Unprefix CSS value text-align: -webkit-match-parent
+ https://bugs.webkit.org/show_bug.cgi?id=229496
+ <rdar://problem/82628618>
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Models/CSSKeywordCompletions.js: Add 'match-parent'
+
2021-12-08 BJ Burg <[email protected]>
[Cocoa] Web Inspector: provide a way for _WKInspectorExtension clients to be to notified when an extension tab navigates
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js (286802 => 286803)
--- trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js 2021-12-09 21:49:45 UTC (rev 286802)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js 2021-12-09 22:47:24 UTC (rev 286803)
@@ -1346,7 +1346,7 @@
"auto", "fixed",
],
"text-align": [
- "-webkit-auto", "left", "right", "center", "justify", "-webkit-left", "-webkit-right", "-webkit-center", "-webkit-match-parent", "start", "end",
+ "-webkit-auto", "left", "right", "center", "justify", "match-parent", "-webkit-left", "-webkit-right", "-webkit-center", "-webkit-match-parent", "start", "end",
],
"text-anchor": [
"middle", "start", "end",
