Title: [286856] trunk/Source/_javascript_Core
- Revision
- 286856
- Author
- [email protected]
- Date
- 2021-12-10 09:25:22 -0800 (Fri, 10 Dec 2021)
Log Message
Remove Mac-specific ARM64EHash implementation
https://bugs.webkit.org/show_bug.cgi?id=234150
Reviewed by Saam Barati.
Currently we have a weaker implementation of ARM64EHash on mac, but we measured it and it's not
any faster than the stricter version we use on iOS. We are removing the mac-specific version and
switching it to use the stricter version.
* assembler/AssemblerBuffer.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (286855 => 286856)
--- trunk/Source/_javascript_Core/ChangeLog 2021-12-10 17:16:51 UTC (rev 286855)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-12-10 17:25:22 UTC (rev 286856)
@@ -1,3 +1,16 @@
+2021-12-10 Tadeu Zagallo <[email protected]>
+
+ Remove Mac-specific ARM64EHash implementation
+ https://bugs.webkit.org/show_bug.cgi?id=234150
+
+ Reviewed by Saam Barati.
+
+ Currently we have a weaker implementation of ARM64EHash on mac, but we measured it and it's not
+ any faster than the stricter version we use on iOS. We are removing the mac-specific version and
+ switching it to use the stricter version.
+
+ * assembler/AssemblerBuffer.h:
+
2021-12-10 Adrian Perez de Castro <[email protected]>
Non-unified build fixes, mid December 2021 edition
Modified: trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h (286855 => 286856)
--- trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h 2021-12-10 17:16:51 UTC (rev 286855)
+++ trunk/Source/_javascript_Core/assembler/AssemblerBuffer.h 2021-12-10 17:25:22 UTC (rev 286856)
@@ -203,29 +203,8 @@
};
#if CPU(ARM64E)
-#if PLATFORM(MAC)
class ARM64EHash {
public:
- ARM64EHash(void* initialHash)
- : m_hash(static_cast<uint32_t>(bitwise_cast<uintptr_t>(initialHash)))
- {
- }
-
- ALWAYS_INLINE uint32_t update(uint32_t value, uint32_t, void*)
- {
- uint64_t input = value ^ m_hash;
- uint64_t a = static_cast<uint32_t>(tagInt(input, static_cast<PtrTag>(0)) >> 39);
- uint64_t b = tagInt(input, static_cast<PtrTag>(0xb7e151628aed2a6a)) >> 23;
- m_hash = a ^ b;
- return m_hash;
- }
-
- private:
- uint32_t m_hash;
- };
-#else
- class ARM64EHash {
- public:
ARM64EHash(void* diversifier)
{
setUpdatedHash(0, 0, diversifier);
@@ -280,7 +259,6 @@
uint64_t m_hash;
};
-#endif // PLATFORM(MAC)
#endif // CPU(ARM64E)
class AssemblerBuffer {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
