Title: [286891] trunk/Source/_javascript_Core
- Revision
- 286891
- Author
- ysuz...@apple.com
- Date
- 2021-12-10 17:10:47 -0800 (Fri, 10 Dec 2021)
Log Message
[JSC] isTaggedJSCCodePtrImpl does not have proper implementation for JITCage & JITCode combination
https://bugs.webkit.org/show_bug.cgi?id=234186
Reviewed by Mark Lam.
If JITCage is enabled and target code is JITCode, we should use tagJSCCodePtrImpl.
* runtime/JSCPtrTag.h:
(JSC::isTaggedJSCCodePtrImpl):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (286890 => 286891)
--- trunk/Source/_javascript_Core/ChangeLog 2021-12-11 01:08:04 UTC (rev 286890)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-12-11 01:10:47 UTC (rev 286891)
@@ -1,3 +1,15 @@
+2021-12-10 Yusuke Suzuki <ysuz...@apple.com>
+
+ [JSC] isTaggedJSCCodePtrImpl does not have proper implementation for JITCage & JITCode combination
+ https://bugs.webkit.org/show_bug.cgi?id=234186
+
+ Reviewed by Mark Lam.
+
+ If JITCage is enabled and target code is JITCode, we should use tagJSCCodePtrImpl.
+
+ * runtime/JSCPtrTag.h:
+ (JSC::isTaggedJSCCodePtrImpl):
+
2021-12-10 Don Olmstead <don.olmst...@sony.com>
Add FileSystem function to read a file at a path
Modified: trunk/Source/_javascript_Core/runtime/JSCPtrTag.h (286890 => 286891)
--- trunk/Source/_javascript_Core/runtime/JSCPtrTag.h 2021-12-11 01:08:04 UTC (rev 286890)
+++ trunk/Source/_javascript_Core/runtime/JSCPtrTag.h 2021-12-11 01:10:47 UTC (rev 286891)
@@ -185,6 +185,9 @@
RELEASE_ASSERT_NOT_REACHED();
#endif
}
+ } else {
+ if (Options::useJITCage())
+ return ptr == tagJSCCodePtrImpl<tag, calleeType, callerType>(removeCodePtrTag(ptr));
#endif // ENABLE(JIT_CAGE)
}
return WTF::isTaggedNativeCodePtrImpl<tag>(ptr);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
