Title: [286976] branches/safari-612-branch/Source/WebKit
Revision
286976
Author
alanc...@apple.com
Date
2021-12-13 12:57:00 -0800 (Mon, 13 Dec 2021)

Log Message

Cherry-pick r286834. rdar://problem/86427901

    Inspector "composite" events are all very short
    https://bugs.webkit.org/show_bug.cgi?id=234114
    <rdar://86299391>

    Reviewed by Tim Horton.

    The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
    time to include painting so use kCATransactionPhasePreLayout.

    * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
    (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
    * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
    (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-612-branch/Source/WebKit/ChangeLog (286975 => 286976)


--- branches/safari-612-branch/Source/WebKit/ChangeLog	2021-12-13 20:56:57 UTC (rev 286975)
+++ branches/safari-612-branch/Source/WebKit/ChangeLog	2021-12-13 20:57:00 UTC (rev 286976)
@@ -1,5 +1,42 @@
 2021-12-13  Alan Coon  <alanc...@apple.com>
 
+        Cherry-pick r286834. rdar://problem/86235740
+
+    Inspector "composite" events are all very short
+    https://bugs.webkit.org/show_bug.cgi?id=234114
+    <rdar://86299391>
+    
+    Reviewed by Tim Horton.
+    
+    The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
+    time to include painting so use kCATransactionPhasePreLayout.
+    
+    * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
+    (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
+    * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+    (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-12-09  Simon Fraser  <simon.fra...@apple.com>
+
+            Inspector "composite" events are all very short
+            https://bugs.webkit.org/show_bug.cgi?id=234114
+            <rdar://86299391>
+
+            Reviewed by Tim Horton.
+
+            The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
+            time to include painting so use kCATransactionPhasePreLayout.
+
+            * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
+            (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
+            * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+            (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
+
+2021-12-13  Alan Coon  <alanc...@apple.com>
+
         Cherry-pick r286858. rdar://problem/86423741
 
     Use simpler idioms for std::less and std::greater possible in modern C++

Modified: branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm (286975 => 286976)


--- branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm	2021-12-13 20:56:57 UTC (rev 286975)
+++ branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm	2021-12-13 20:57:00 UTC (rev 286976)
@@ -293,7 +293,7 @@
             if (Frame* coreFrame = retainedPage->mainFrame())
                 corePage->inspectorController().willComposite(*coreFrame);
         }
-    } forPhase:kCATransactionPhasePreCommit];
+    } forPhase:kCATransactionPhasePreLayout];
     
     [CATransaction addCommitHandler:[retainedPage = makeRefPtr(&m_webPage)] {
         if (Page* corePage = retainedPage->corePage()) {

Modified: branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (286975 => 286976)


--- branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2021-12-13 20:56:57 UTC (rev 286975)
+++ branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm	2021-12-13 20:57:00 UTC (rev 286976)
@@ -426,7 +426,7 @@
             if (Frame* coreFrame = retainedPage->mainFrame())
                 corePage->inspectorController().willComposite(*coreFrame);
         }
-    } forPhase:kCATransactionPhasePreCommit];
+    } forPhase:kCATransactionPhasePreLayout];
 
     [CATransaction addCommitHandler:[retainedPage = makeRefPtr(&m_webPage)] {
         if (Page* corePage = retainedPage->corePage()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to