Title: [287154] trunk/Source/_javascript_Core
- Revision
- 287154
- Author
- ca...@igalia.com
- Date
- 2021-12-16 13:05:43 -0800 (Thu, 16 Dec 2021)
Log Message
[JSC] only emit pointer validation for ARM64E
https://bugs.webkit.org/show_bug.cgi?id=234402
Reviewed by Yusuke Suzuki and Mark Lam.
JIT thunks no longer emit `push <reg>; pop <reg>;` on
non-ARM64E arches with the emitPointerValidation macro.
* jit/ThunkGenerators.cpp:
(JSC::emitPointerValidation):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (287153 => 287154)
--- trunk/Source/_javascript_Core/ChangeLog 2021-12-16 21:02:07 UTC (rev 287153)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-12-16 21:05:43 UTC (rev 287154)
@@ -1,3 +1,16 @@
+2021-12-16 Caitlin Potter <ca...@igalia.com>
+
+ [JSC] only emit pointer validation for ARM64E
+ https://bugs.webkit.org/show_bug.cgi?id=234402
+
+ Reviewed by Yusuke Suzuki and Mark Lam.
+
+ JIT thunks no longer emit `push <reg>; pop <reg>;` on
+ non-ARM64E arches with the emitPointerValidation macro.
+
+ * jit/ThunkGenerators.cpp:
+ (JSC::emitPointerValidation):
+
2021-12-16 Michael Saboff <msab...@apple.com>
Create symlinks pointing to alternate root framework locations
Modified: trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp (287153 => 287154)
--- trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2021-12-16 21:02:07 UTC (rev 287153)
+++ trunk/Source/_javascript_Core/jit/ThunkGenerators.cpp 2021-12-16 21:05:43 UTC (rev 287154)
@@ -148,6 +148,7 @@
template<typename TagType>
inline void emitPointerValidation(CCallHelpers& jit, GPRReg pointerGPR, TagType tag)
{
+#if CPU(ARM64E)
if (!ASSERT_ENABLED)
return;
if (!Options::useJITCage()) {
@@ -159,6 +160,11 @@
jit.validateUntaggedPtr(pointerGPR);
jit.popToRestore(pointerGPR);
}
+#else
+ UNUSED_PARAM(jit);
+ UNUSED_PARAM(pointerGPR);
+ UNUSED_PARAM(tag);
+#endif
}
// We will jump here if the JIT code tries to make a call, but the
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
