- Revision
- 287167
- Author
- tyle...@apple.com
- Date
- 2021-12-16 17:52:25 -0800 (Thu, 16 Dec 2021)
Log Message
AX: Make aria-multiline.html, clipped-text-under-element.html, mixed-checkbox.html, and selection-states.html pass in isolated tree mode
https://bugs.webkit.org/show_bug.cgi?id=234382
Reviewed by Chris Fleizach.
* accessibility/mac/aria-multiline-expected.txt:
* accessibility/mac/aria-multiline.html:
* accessibility/mac/clipped-text-under-element.html:
* accessibility/mac/mixed-checkbox-expected.txt:
* accessibility/mac/mixed-checkbox.html:
* accessibility/selection-states-expected.txt:
* accessibility/selection-states.html:
Make these tests pass in isolated tree mode by using
accessibilityController.accessibleElementById to get JS references to
AX objects instead of document.getElementById() +
accessibilityController.focusedElement.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (287166 => 287167)
--- trunk/LayoutTests/ChangeLog 2021-12-17 01:22:18 UTC (rev 287166)
+++ trunk/LayoutTests/ChangeLog 2021-12-17 01:52:25 UTC (rev 287167)
@@ -1,3 +1,22 @@
+2021-12-16 Tyler Wilcock <tyle...@apple.com>
+
+ AX: Make aria-multiline.html, clipped-text-under-element.html, mixed-checkbox.html, and selection-states.html pass in isolated tree mode
+ https://bugs.webkit.org/show_bug.cgi?id=234382
+
+ Reviewed by Chris Fleizach.
+
+ * accessibility/mac/aria-multiline-expected.txt:
+ * accessibility/mac/aria-multiline.html:
+ * accessibility/mac/clipped-text-under-element.html:
+ * accessibility/mac/mixed-checkbox-expected.txt:
+ * accessibility/mac/mixed-checkbox.html:
+ * accessibility/selection-states-expected.txt:
+ * accessibility/selection-states.html:
+ Make these tests pass in isolated tree mode by using
+ accessibilityController.accessibleElementById to get JS references to
+ AX objects instead of document.getElementById() +
+ accessibilityController.focusedElement.
+
2021-12-16 Ryan Haddad <ryanhad...@apple.com>
REGRESSION(r286849-r286852): [iOS] http/tests/app-privacy-report/user-attribution-post-request.html is consistently failing
Modified: trunk/LayoutTests/accessibility/mac/aria-multiline-expected.txt (287166 => 287167)
--- trunk/LayoutTests/accessibility/mac/aria-multiline-expected.txt 2021-12-17 01:22:18 UTC (rev 287166)
+++ trunk/LayoutTests/accessibility/mac/aria-multiline-expected.txt 2021-12-17 01:52:25 UTC (rev 287167)
@@ -5,8 +5,8 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS accessibilityController.focusedElement.role is 'AXRole: AXTextField'
-PASS accessibilityController.focusedElement.role is 'AXRole: AXTextArea'
+PASS accessibilityController.accessibleElementById('textfield').role is 'AXRole: AXTextField'
+PASS accessibilityController.accessibleElementById('textarea').role is 'AXRole: AXTextArea'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/mac/aria-multiline.html (287166 => 287167)
--- trunk/LayoutTests/accessibility/mac/aria-multiline.html 2021-12-17 01:22:18 UTC (rev 287166)
+++ trunk/LayoutTests/accessibility/mac/aria-multiline.html 2021-12-17 01:52:25 UTC (rev 287167)
@@ -12,18 +12,12 @@
<div id="console"></div>
<script>
-
description("This tests that aria-multiline will change the role of a text control from a text field to a text area.");
if (window.accessibilityController) {
-
- document.getElementById("textfield").focus();
- shouldBe("accessibilityController.focusedElement.role", "'AXRole: AXTextField'");
-
- document.getElementById("textarea").focus();
- shouldBe("accessibilityController.focusedElement.role", "'AXRole: AXTextArea'");
+ shouldBe("accessibilityController.accessibleElementById('textfield').role", "'AXRole: AXTextField'");
+ shouldBe("accessibilityController.accessibleElementById('textarea').role", "'AXRole: AXTextArea'");
}
-
</script>
<script src=""
Modified: trunk/LayoutTests/accessibility/mac/clipped-text-under-element.html (287166 => 287167)
--- trunk/LayoutTests/accessibility/mac/clipped-text-under-element.html 2021-12-17 01:22:18 UTC (rev 287166)
+++ trunk/LayoutTests/accessibility/mac/clipped-text-under-element.html 2021-12-17 01:52:25 UTC (rev 287167)
@@ -26,16 +26,13 @@
<div id="console"></div>
<script>
-
description("This tests that even if an element is not visible, textUnderElement() will still give the text.");
if (window.accessibilityController) {
- document.getElementById("hidden-link").focus();
- var hiddenLink = accessibilityController.focusedElement;
+ var hiddenLink = accessibilityController.accessibleElementById("hidden-link");
shouldBe("hiddenLink.title", "'AXTitle: I am the hidden link text.'");
- document.getElementById("visible-link").focus();
- var visibleLink = accessibilityController.focusedElement;
+ var visibleLink = accessibilityController.accessibleElementById("visible-link");
shouldBe("visibleLink.title", "'AXTitle: I am the visible link text.'");
}
Modified: trunk/LayoutTests/accessibility/mac/mixed-checkbox-expected.txt (287166 => 287167)
--- trunk/LayoutTests/accessibility/mac/mixed-checkbox-expected.txt 2021-12-17 01:22:18 UTC (rev 287166)
+++ trunk/LayoutTests/accessibility/mac/mixed-checkbox-expected.txt 2021-12-17 01:52:25 UTC (rev 287167)
@@ -12,11 +12,11 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS accessibilityController.focusedElement.intValue is 0
-PASS accessibilityController.focusedElement.intValue is 1
-PASS accessibilityController.focusedElement.intValue is 2
-PASS accessibilityController.focusedElement.intValue is 0
-PASS accessibilityController.focusedElement.intValue is 0
+PASS accessibilityController.accessibleElementById('box1').intValue is 0
+PASS accessibilityController.accessibleElementById('box2').intValue is 1
+PASS accessibilityController.accessibleElementById('box3').intValue is 2
+PASS accessibilityController.accessibleElementById('box4').intValue is 0
+PASS accessibilityController.accessibleElementById('box5').intValue is 0
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/mac/mixed-checkbox.html (287166 => 287167)
--- trunk/LayoutTests/accessibility/mac/mixed-checkbox.html 2021-12-17 01:22:18 UTC (rev 287166)
+++ trunk/LayoutTests/accessibility/mac/mixed-checkbox.html 2021-12-17 01:52:25 UTC (rev 287167)
@@ -21,24 +21,19 @@
if (window.accessibilityController) {
// aria-state=false
- document.getElementById("box1").focus();
- shouldBe("accessibilityController.focusedElement.intValue", "0");
+ shouldBe("accessibilityController.accessibleElementById('box1').intValue", "0");
// aria-state=true
- document.getElementById("box2").focus();
- shouldBe("accessibilityController.focusedElement.intValue", "1");
+ shouldBe("accessibilityController.accessibleElementById('box2').intValue", "1");
// aria-state=mixed
- document.getElementById("box3").focus();
- shouldBe("accessibilityController.focusedElement.intValue", "2");
+ shouldBe("accessibilityController.accessibleElementById('box3').intValue", "2");
// no aria state, default to off
- document.getElementById("box4").focus();
- shouldBe("accessibilityController.focusedElement.intValue", "0");
+ shouldBe("accessibilityController.accessibleElementById('box4').intValue", "0");
// native checkbox is also aria checkbox, default to native semantics
- document.getElementById("box5").focus();
- shouldBe("accessibilityController.focusedElement.intValue", "0");
+ shouldBe("accessibilityController.accessibleElementById('box5').intValue", "0");
}
Modified: trunk/LayoutTests/accessibility/selection-states-expected.txt (287166 => 287167)
--- trunk/LayoutTests/accessibility/selection-states-expected.txt 2021-12-17 01:22:18 UTC (rev 287166)
+++ trunk/LayoutTests/accessibility/selection-states-expected.txt 2021-12-17 01:52:25 UTC (rev 287167)
@@ -1,14 +1,13 @@
This tests that we report the correct selection-related states.
-
-PASS accessibilityController.focusedElement.isMultiSelectable is true
-PASS accessibilityController.focusedElement.childAtIndex(0).isSelectable is true
-PASS accessibilityController.focusedElement.childAtIndex(0).isSelected is true
-PASS accessibilityController.focusedElement.childAtIndex(1).isSelectable is true
-PASS accessibilityController.focusedElement.childAtIndex(1).isSelected is false
-PASS accessibilityController.focusedElement.childAtIndex(2).isSelectable is false
-PASS accessibilityController.focusedElement.childAtIndex(2).isSelected is false
+PASS accessibilityController.accessibleElementById("selectElement").isMultiSelectable is true
+PASS accessibilityController.accessibleElementById("selectElement").childAtIndex(0).isSelectable is true
+PASS accessibilityController.accessibleElementById("selectElement").childAtIndex(0).isSelected is true
+PASS accessibilityController.accessibleElementById("selectElement").childAtIndex(1).isSelectable is true
+PASS accessibilityController.accessibleElementById("selectElement").childAtIndex(1).isSelected is false
+PASS accessibilityController.accessibleElementById("selectElement").childAtIndex(2).isSelectable is false
+PASS accessibilityController.accessibleElementById("selectElement").childAtIndex(2).isSelected is false
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/accessibility/selection-states.html (287166 => 287167)
--- trunk/LayoutTests/accessibility/selection-states.html 2021-12-17 01:22:18 UTC (rev 287166)
+++ trunk/LayoutTests/accessibility/selection-states.html 2021-12-17 01:52:25 UTC (rev 287167)
@@ -13,23 +13,17 @@
<p>This tests that we report the correct selection-related states.</p>
-<p id="notDRT">This test should only be run inside of DumpRenderTree.</p>
-
<p id="console"></p>
<script>
if (window.testRunner && window.accessibilityController) {
- document.getElementById("notDRT").style.visibility = "hidden";
-
- document.getElementById("selectElement").focus();
-
- shouldBeTrue('accessibilityController.focusedElement.isMultiSelectable');
- shouldBeTrue('accessibilityController.focusedElement.childAtIndex(0).isSelectable');
- shouldBeTrue('accessibilityController.focusedElement.childAtIndex(0).isSelected');
- shouldBeTrue('accessibilityController.focusedElement.childAtIndex(1).isSelectable');
- shouldBeFalse('accessibilityController.focusedElement.childAtIndex(1).isSelected');
- shouldBeFalse('accessibilityController.focusedElement.childAtIndex(2).isSelectable');
- shouldBeFalse('accessibilityController.focusedElement.childAtIndex(2).isSelected');
+ shouldBeTrue('accessibilityController.accessibleElementById("selectElement").isMultiSelectable');
+ shouldBeTrue('accessibilityController.accessibleElementById("selectElement").childAtIndex(0).isSelectable');
+ shouldBeTrue('accessibilityController.accessibleElementById("selectElement").childAtIndex(0).isSelected');
+ shouldBeTrue('accessibilityController.accessibleElementById("selectElement").childAtIndex(1).isSelectable');
+ shouldBeFalse('accessibilityController.accessibleElementById("selectElement").childAtIndex(1).isSelected');
+ shouldBeFalse('accessibilityController.accessibleElementById("selectElement").childAtIndex(2).isSelectable');
+ shouldBeFalse('accessibilityController.accessibleElementById("selectElement").childAtIndex(2).isSelected');
}
</script>
</body>
