Title: [287189] trunk/Source/WebCore
- Revision
- 287189
- Author
- [email protected]
- Date
- 2021-12-17 08:03:15 -0800 (Fri, 17 Dec 2021)
Log Message
[LFC][IFC] Line spanning inline items should use InlineItem::opaqueBidiLevel
https://bugs.webkit.org/show_bug.cgi?id=234417
Reviewed by Antti Koivisto.
The visual order of the non-empty inline boxes are driven by their content and not by
their guessed bidi levels.
* layout/formattingContexts/inline/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::initialize):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (287188 => 287189)
--- trunk/Source/WebCore/ChangeLog 2021-12-17 16:02:45 UTC (rev 287188)
+++ trunk/Source/WebCore/ChangeLog 2021-12-17 16:03:15 UTC (rev 287189)
@@ -1,5 +1,18 @@
2021-12-17 Alan Bujtas <[email protected]>
+ [LFC][IFC] Line spanning inline items should use InlineItem::opaqueBidiLevel
+ https://bugs.webkit.org/show_bug.cgi?id=234417
+
+ Reviewed by Antti Koivisto.
+
+ The visual order of the non-empty inline boxes are driven by their content and not by
+ their guessed bidi levels.
+
+ * layout/formattingContexts/inline/InlineLineBuilder.cpp:
+ (WebCore::Layout::LineBuilder::initialize):
+
+2021-12-17 Alan Bujtas <[email protected]>
+
[LFC][IFC] Inline boxes set direction for both their content and their decoration unlike other inline level elements
https://bugs.webkit.org/show_bug.cgi?id=234418
Modified: trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp (287188 => 287189)
--- trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-12-17 16:02:45 UTC (rev 287188)
+++ trunk/Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp 2021-12-17 16:03:15 UTC (rev 287189)
@@ -372,7 +372,7 @@
// We only have to do it on the first run as any subsequent inline content is either at the same/higher nesting level.
auto& firstInlineItem = m_inlineItems[leadingInlineItemIndex];
// Let's treat these spanning inline items as opaque bidi content. They should not change the bidi levels on adjacent content.
- auto bidiLevelForOpaqueInlineItem = firstInlineItem.bidiLevel();
+ auto bidiLevelForOpaqueInlineItem = InlineItem::opaqueBidiLevel;
// If the parent is the formatting root, we can stop here. This is root inline box content, there's no nesting inline box from the previous line(s)
// unless the inline box closing is forced over to the current line.
// e.g.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
