Title: [287204] trunk/Source/ThirdParty/ANGLE
Revision
287204
Author
[email protected]
Date
2021-12-17 13:39:12 -0800 (Fri, 17 Dec 2021)

Log Message

[ANGLE] "WARN: driver_utils.cpp:169 (rx::GetVendorString):! Unimplemented: rx::GetVendorString" on WinCairo debug testing bot
https://bugs.webkit.org/show_bug.cgi?id=234371

Reviewed by Kenneth Russell.

After r286603 updated ANGLE, WinCairo debug testing bot was
observing annoying warning message for all WebGL tessts.
> WARN: driver_utils.cpp:169 (rx::GetVendorString): 	! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169)

The vendor ID was 0x1414 (Microsoft).
<https://pcisig.com/membership/member-companies>

* src/libANGLE/renderer/driver_utils.cpp:
(rx::GetVendorString): Added more vendor strings for vendor IDs.
* src/libANGLE/renderer/driver_utils.h: Added VENDOR_ID_MICROSOFT.

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (287203 => 287204)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-17 21:05:42 UTC (rev 287203)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-17 21:39:12 UTC (rev 287204)
@@ -1,3 +1,21 @@
+2021-12-17  Fujii Hironori  <[email protected]>
+
+        [ANGLE] "WARN: driver_utils.cpp:169 (rx::GetVendorString):! Unimplemented: rx::GetVendorString" on WinCairo debug testing bot
+        https://bugs.webkit.org/show_bug.cgi?id=234371
+
+        Reviewed by Kenneth Russell.
+
+        After r286603 updated ANGLE, WinCairo debug testing bot was
+        observing annoying warning message for all WebGL tessts.
+        > WARN: driver_utils.cpp:169 (rx::GetVendorString): 	! Unimplemented: rx::GetVendorString(..\..\Source\ThirdParty\ANGLE\src\libANGLE\renderer\driver_utils.cpp:169)
+
+        The vendor ID was 0x1414 (Microsoft).
+        <https://pcisig.com/membership/member-companies>
+
+        * src/libANGLE/renderer/driver_utils.cpp:
+        (rx::GetVendorString): Added more vendor strings for vendor IDs.
+        * src/libANGLE/renderer/driver_utils.h: Added VENDOR_ID_MICROSOFT.
+
 2021-12-17  Kimmo Kinnunen  <[email protected]>
 
         REGRESSION (r287068): [macOS arm64] TestWebKitAPI.GraphicsContextGLCocoaTest.UnrecycledDisplayBuffersNoLeaks is failing

Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp (287203 => 287204)


--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp	2021-12-17 21:05:42 UTC (rev 287203)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.cpp	2021-12-17 21:39:12 UTC (rev 287204)
@@ -146,6 +146,8 @@
             return "ARM";
         case VENDOR_ID_APPLE:
             return "Apple";
+        case VENDOR_ID_MICROSOFT:
+            return "Microsoft";
         case VENDOR_ID_BROADCOM:
             return "Broadcom";
         case VENDOR_ID_GOOGLE:
@@ -160,6 +162,12 @@
             return "Imagination Technologies";
         case VENDOR_ID_QUALCOMM:
             return "Qualcomm";
+        case VENDOR_ID_SAMSUNG:
+            return "Samsung";
+        case VENDOR_ID_VMWARE:
+            return "VMware";
+        case VENDOR_ID_VIVANTE:
+            return "Vivante";
         case 0xba5eba11:  // Mock vendor ID used for tests.
             return "Test";
         case 0:

Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h (287203 => 287204)


--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h	2021-12-17 21:05:42 UTC (rev 287203)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/driver_utils.h	2021-12-17 21:39:12 UTC (rev 287204)
@@ -21,6 +21,7 @@
     VENDOR_ID_AMD     = 0x1002,
     VENDOR_ID_APPLE   = 0x106B,
     VENDOR_ID_ARM     = 0x13B5,
+    VENDOR_ID_MICROSOFT = 0x1414,
     // Broadcom devices won't use PCI, but this is their Vulkan vendor id.
     VENDOR_ID_BROADCOM = 0x14E4,
     VENDOR_ID_GOOGLE   = 0x1AE0,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to