Title: [287213] trunk/Source/WebCore
- Revision
- 287213
- Author
- [email protected]
- Date
- 2021-12-17 16:27:26 -0800 (Fri, 17 Dec 2021)
Log Message
Add comment to r287208.
https://bugs.webkit.org/show_bug.cgi?id=234428
Unreviewed.
No new tests because there is no behavior change.
* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyCSSVisibilityRules):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (287212 => 287213)
--- trunk/Source/WebCore/ChangeLog 2021-12-17 23:20:06 UTC (rev 287212)
+++ trunk/Source/WebCore/ChangeLog 2021-12-18 00:27:26 UTC (rev 287213)
@@ -1,5 +1,17 @@
2021-12-17 Myles C. Maxfield <[email protected]>
+ Add comment to r287208.
+ https://bugs.webkit.org/show_bug.cgi?id=234428
+
+ Unreviewed.
+
+ No new tests because there is no behavior change.
+
+ * platform/graphics/WidthIterator.cpp:
+ (WebCore::WidthIterator::applyCSSVisibilityRules):
+
+2021-12-17 Myles C. Maxfield <[email protected]>
+
Refactor WidthIterator::applyCSSVisibilityRules() to be a little more elegant
https://bugs.webkit.org/show_bug.cgi?id=234428
Modified: trunk/Source/WebCore/platform/graphics/WidthIterator.cpp (287212 => 287213)
--- trunk/Source/WebCore/platform/graphics/WidthIterator.cpp 2021-12-17 23:20:06 UTC (rev 287212)
+++ trunk/Source/WebCore/platform/graphics/WidthIterator.cpp 2021-12-18 00:27:26 UTC (rev 287213)
@@ -575,6 +575,10 @@
glyphBuffer.glyphs(index)[0] = newGlyph;
};
+ // FIXME: It's technically wrong to call clobberAdvance or deleteGlyph here, because this is after initialAdvances have been
+ // applied. If the last glyph in a run needs to have its advance clobbered, but the next run has an initial advance, we need
+ // to apply the initial advance on the new clobbered advance, rather than clobbering the initial advance entirely.
+
auto clobberAdvance = [&] (auto index, auto newAdvance) {
auto advanceBeforeClobbering = glyphBuffer.advanceAt(index);
glyphBuffer.advances(index)[0] = makeGlyphBufferAdvance(newAdvance, height(advanceBeforeClobbering));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
