Title: [287326] trunk/Source
Revision
287326
Author
[email protected]
Date
2021-12-21 12:16:05 -0800 (Tue, 21 Dec 2021)

Log Message

Fix symlinks for alternate root framework locations
https://bugs.webkit.org/show_bug.cgi?id=234567

Reviewed by Filip Pizlo.

Source/ThirdParty/ANGLE:

Eliminated the creation of symlinks for ANGLE as it is under WebCore.

* ANGLE.xcodeproj/project.pbxproj:
* Configurations/ANGLE-dynamic.xcconfig:

Source/WebCore:

Covered by existing tests.

Moved OUTPUT_ALTERNATE_ROOT_PATH in create symlink script from outputFileListPaths to outputPaths.

* WebCore.xcodeproj/project.pbxproj:

Source/WebGPU:

Moved OUTPUT_ALTERNATE_ROOT_PATH in create symlink script from outputFileListPaths to outputPaths.

* WebGPU.xcodeproj/project.pbxproj:

Source/WebInspectorUI:

Moved OUTPUT_ALTERNATE_ROOT_PATH in create symlink script from outputFileListPaths to outputPaths.

* WebInspectorUI.xcodeproj/project.pbxproj:

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (287325 => 287326)


--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj	2021-12-21 20:16:05 UTC (rev 287326)
@@ -3508,7 +3508,6 @@
 				31CD00CE2491974C00486F27 /* CopyFiles */,
 				31CD00CF2491976800486F27 /* CopyFiles */,
 				31CD00D2249197FD00486F27 /* Adjust ANGLE Paths */,
-				6577FFC5276AC8630011AEC8 /* Create Symlink to Alt Root Path */,
 			);
 			buildRules = (
 				31A9E9A0249AA04200C7E243 /* PBXBuildRule */,
@@ -3597,25 +3596,6 @@
 			shellPath = /bin/sh;
 			shellScript = "if [ \"${XCODE_VERSION_ACTUAL}\" -ge \"1140\" -a \"${WK_USE_NEW_BUILD_SYSTEM}\" = \"YES\" ]; then\n    # In this configuration, post-processing is performed at the same time as copying in the postprocess-header-rule script, so there's no need for this separate step.\n    exit 0\nfi\n\nexec \"$SRCROOT/adjust-angle-include-paths.py\"\n";
 		};
-		6577FFC5276AC8630011AEC8 /* Create Symlink to Alt Root Path */ = {
-			isa = PBXShellScriptBuildPhase;
-			buildActionMask = 8;
-			files = (
-			);
-			inputFileListPaths = (
-			);
-			inputPaths = (
-			);
-			name = "Create Symlink to Alt Root Path";
-			outputFileListPaths = (
-			);
-			outputPaths = (
-				"${OUTPUT_ALTERNATE_ROOT_PATH}",
-			);
-			runOnlyForDeploymentPostprocessing = 1;
-			shellPath = /bin/zsh;
-			shellScript = "\"${SRCROOT}/scripts/create-symlink-to-altroot.sh\"\n";
-		};
 		FFDA50D5269F895400AE11E2 /* Bake Metal Library to NSData */ = {
 			isa = PBXShellScriptBuildPhase;
 			buildActionMask = 2147483647;

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (287325 => 287326)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-12-21 20:16:05 UTC (rev 287326)
@@ -1,3 +1,15 @@
+2021-12-21  Michael Saboff  <[email protected]>
+
+        Fix symlinks for alternate root framework locations
+        https://bugs.webkit.org/show_bug.cgi?id=234567
+
+        Reviewed by Filip Pizlo.
+
+        Eliminated the creation of symlinks for ANGLE as it is under WebCore.
+
+        * ANGLE.xcodeproj/project.pbxproj:
+        * Configurations/ANGLE-dynamic.xcconfig:
+
 2021-12-21  Arcady Goldmints-Orlov  <[email protected]>
 
         [GTK] build fails with undefined symbol in ANGLE if USE_ANGLE_WEBGL is enabled.

Modified: trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig (287325 => 287326)


--- trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig	2021-12-21 20:16:05 UTC (rev 287326)
@@ -30,11 +30,6 @@
 DYLIB_INSTALL_NAME_BASE_WK_RELOCATABLE_FRAMEWORKS_ = $(DYLIB_INSTALL_NAME_BASE);
 DYLIB_INSTALL_NAME_BASE_WK_RELOCATABLE_FRAMEWORKS_YES = @loader_path/../../../;
 
-ALTERNATE_ROOT_PATH = $(DYLIB_INSTALL_NAME_BASE);
-
-OUTPUT_ALTERNATE_ROOT_PATH = $(OUTPUT_ALTERNATE_ROOT_PATH_$(USE_SYSTEM_CONTENT_PATH));
-OUTPUT_ALTERNATE_ROOT_PATH_YES = $(DSTROOT)$(ALTERNATE_ROOT_PATH)/$(FULL_PRODUCT_NAME);
-
 HEADER_SEARCH_PATHS = include src src/common/third_party/numerics third_party/base src/common/third_party/base third_party/zlib/google ${DERIVED_FILES_DIR};
 
 ANGLE_HEADERS_FOLDER_PATH = /usr/local/include/ANGLE;

Modified: trunk/Source/WebCore/ChangeLog (287325 => 287326)


--- trunk/Source/WebCore/ChangeLog	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/WebCore/ChangeLog	2021-12-21 20:16:05 UTC (rev 287326)
@@ -1,3 +1,16 @@
+2021-12-21  Michael Saboff  <[email protected]>
+
+        Fix symlinks for alternate root framework locations
+        https://bugs.webkit.org/show_bug.cgi?id=234567
+
+        Reviewed by Filip Pizlo.
+
+        Covered by existing tests.
+
+        Moved OUTPUT_ALTERNATE_ROOT_PATH in create symlink script from outputFileListPaths to outputPaths.
+
+        * WebCore.xcodeproj/project.pbxproj:
+
 2021-12-21  Antti Koivisto  <[email protected]>
 
         REGRESSION(r286169): 0.3% Speedometer regression

Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (287325 => 287326)


--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2021-12-21 20:16:05 UTC (rev 287326)
@@ -38332,9 +38332,9 @@
 			);
 			name = "Create Symlink to Alt Root Path";
 			outputFileListPaths = (
-				"${OUTPUT_ALTERNATE_ROOT_PATH}",
 			);
 			outputPaths = (
+				"${OUTPUT_ALTERNATE_ROOT_PATH}",
 			);
 			runOnlyForDeploymentPostprocessing = 1;
 			shellPath = /bin/zsh;

Modified: trunk/Source/WebGPU/ChangeLog (287325 => 287326)


--- trunk/Source/WebGPU/ChangeLog	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/WebGPU/ChangeLog	2021-12-21 20:16:05 UTC (rev 287326)
@@ -1,3 +1,14 @@
+2021-12-21  Michael Saboff  <[email protected]>
+
+        Fix symlinks for alternate root framework locations
+        https://bugs.webkit.org/show_bug.cgi?id=234567
+
+        Reviewed by Filip Pizlo.
+
+        Moved OUTPUT_ALTERNATE_ROOT_PATH in create symlink script from outputFileListPaths to outputPaths.
+
+        * WebGPU.xcodeproj/project.pbxproj:
+
 2021-12-16  Michael Saboff  <[email protected]>
 
         https://bugs.webkit.org/show_bug.cgi?id=234173

Modified: trunk/Source/WebGPU/WebGPU.xcodeproj/project.pbxproj (287325 => 287326)


--- trunk/Source/WebGPU/WebGPU.xcodeproj/project.pbxproj	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/WebGPU/WebGPU.xcodeproj/project.pbxproj	2021-12-21 20:16:05 UTC (rev 287326)
@@ -443,9 +443,9 @@
 			);
 			name = "Create Symlink to Alt Root Path";
 			outputFileListPaths = (
-				"${OUTPUT_ALTERNATE_ROOT_PATH}",
 			);
 			outputPaths = (
+				"${OUTPUT_ALTERNATE_ROOT_PATH}",
 			);
 			runOnlyForDeploymentPostprocessing = 1;
 			shellPath = /bin/zsh;

Modified: trunk/Source/WebInspectorUI/ChangeLog (287325 => 287326)


--- trunk/Source/WebInspectorUI/ChangeLog	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/WebInspectorUI/ChangeLog	2021-12-21 20:16:05 UTC (rev 287326)
@@ -1,3 +1,14 @@
+2021-12-21  Michael Saboff  <[email protected]>
+
+        Fix symlinks for alternate root framework locations
+        https://bugs.webkit.org/show_bug.cgi?id=234567
+
+        Reviewed by Filip Pizlo.
+
+        Moved OUTPUT_ALTERNATE_ROOT_PATH in create symlink script from outputFileListPaths to outputPaths.
+
+        * WebInspectorUI.xcodeproj/project.pbxproj:
+
 2021-12-16  Michael Saboff  <[email protected]>
 
         https://bugs.webkit.org/show_bug.cgi?id=234173

Modified: trunk/Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj (287325 => 287326)


--- trunk/Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj	2021-12-21 19:36:05 UTC (rev 287325)
+++ trunk/Source/WebInspectorUI/WebInspectorUI.xcodeproj/project.pbxproj	2021-12-21 20:16:05 UTC (rev 287326)
@@ -159,9 +159,9 @@
 			);
 			name = "Create Symlink to Alt Root Path";
 			outputFileListPaths = (
-				"${OUTPUT_ALTERNATE_ROOT_PATH}",
 			);
 			outputPaths = (
+				"${OUTPUT_ALTERNATE_ROOT_PATH}",
 			);
 			runOnlyForDeploymentPostprocessing = 1;
 			shellPath = /bin/zsh;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to