Diff
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (287381 => 287382)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2021-12-23 03:10:16 UTC (rev 287382)
@@ -1,3 +1,16 @@
+2021-12-22 Michael Saboff <[email protected]>
+
+ Fix WebKit Build issues when using system content path
+ https://bugs.webkit.org/show_bug.cgi?id=234624
+
+ Reviewed by Filip Pizlo.
+
+ Changed INSTALL_PATH on macOS builds to use a fully qualified .../WebCore.framework/Versions/A/Frameworks.
+ Deleted unused create-symlink-to-altroot.sh script.
+
+ * Configurations/ANGLE-dynamic.xcconfig:
+ * scripts/create-symlink-to-altroot.sh: Removed.
+
2021-12-21 Michael Saboff <[email protected]>
Fix symlinks for alternate root framework locations
Modified: trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig (287381 => 287382)
--- trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/ThirdParty/ANGLE/Configurations/ANGLE-dynamic.xcconfig 2021-12-23 03:10:16 UTC (rev 287382)
@@ -15,9 +15,9 @@
ANGLE_OTHER_LDFLAGS_macosx = -framework IOKit -lz;
INSTALL_PATH = $(INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_$(USE_SYSTEM_CONTENT_PATH));
-INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH)$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks;
+INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH)$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_ = $(INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO);
-INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks;
+INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO[sdk=macosx*] = $(INSTALL_PATH_USE_ALTERNATE_FRAMEWORKS_DIR_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));
INSTALL_PATH_USE_ALTERNATE_FRAMEWORKS_DIR_NO = $(INSTALL_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
INSTALL_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_NO = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
Deleted: trunk/Source/ThirdParty/ANGLE/scripts/create-symlink-to-altroot.sh (287381 => 287382)
--- trunk/Source/ThirdParty/ANGLE/scripts/create-symlink-to-altroot.sh 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/ThirdParty/ANGLE/scripts/create-symlink-to-altroot.sh 2021-12-23 03:10:16 UTC (rev 287382)
@@ -1,30 +0,0 @@
-#!/bin/zsh
-
-set -e
-
-if [[ -z "${OUTPUT_ALTERNATE_ROOT_PATH}" ]]; then
- exit 0
-fi
-
-if [[ "${SKIP_INSTALL}" = "YES" ]]; then
- exit 0
-fi
-
-# Convert eg. `/System/Library/PrivateFrameworks` to `../../..`
-RELATIVE_PATH_FROM_SYMLINK_TO_ROOT=$(echo "${ALTERNATE_ROOT_PATH}" | sed -E -e "s/\/[a-zA-Z0-9_]+/..\//g" -e "s/\/$//")
-SYMLINK_VALUE="${RELATIVE_PATH_FROM_SYMLINK_TO_ROOT}${INSTALL_PATH}/${FULL_PRODUCT_NAME}"
-
-if [[ -L "${OUTPUT_ALTERNATE_ROOT_PATH}" ]]; then
- EXISTING_SYMLINK_VALUE=$(readlink "${OUTPUT_ALTERNATE_ROOT_PATH}")
-
- if [[ "${EXISTING_SYMLINK_VALUE}" == "${SYMLINK_VALUE}" ]]; then
- exit 0
- fi
-
- echo "warning: existing symlink is incorrect; expected ${SYMLINK_VALUE}, got ${EXISTING_SYMLINK_VALUE}"
-elif [[ -e "${OUTPUT_ALTERNATE_ROOT_PATH}" ]]; then
- echo "error: expected a symlink at ${OUTPUT_ALTERNATE_ROOT_PATH}"
- exit 1
-fi
-
-ln -sf "${SYMLINK_VALUE}" "${OUTPUT_ALTERNATE_ROOT_PATH}"
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (287381 => 287382)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-12-23 03:10:16 UTC (rev 287382)
@@ -1,3 +1,14 @@
+2021-12-22 Michael Saboff <[email protected]>
+
+ Fix WebKit Build issues when using system content path
+ https://bugs.webkit.org/show_bug.cgi?id=234624
+
+ Reviewed by Filip Pizlo.
+
+ Changed INSTALL_PATH on macOS builds to use fully qualified .../WebCore.framework/Versions/A/Frameworks.
+
+ * Configurations/libwebrtc.xcconfig:
+
2021-12-16 Michael Saboff <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=234173
Modified: trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig (287381 => 287382)
--- trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/ThirdParty/libwebrtc/Configurations/libwebrtc.xcconfig 2021-12-23 03:10:16 UTC (rev 287382)
@@ -32,7 +32,7 @@
EXPORTED_SYMBOLS_FILE[sdk=iphonesimulator*] = Configurations/libwebrtc.iOSsim.exp;
INSTALL_PATH = $(INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_$(USE_SYSTEM_CONTENT_PATH));
-INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH)$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks;
+INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH)$(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_ = $(INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO);
INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO = $(NORMAL_WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Frameworks;
INSTALL_PATH_USE_SYSTEM_CONTENT_PATH_NO[sdk=macosx*] = $(INSTALL_PATH_USE_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
Modified: trunk/Source/WebCore/ChangeLog (287381 => 287382)
--- trunk/Source/WebCore/ChangeLog 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/WebCore/ChangeLog 2021-12-23 03:10:16 UTC (rev 287382)
@@ -1,3 +1,16 @@
+2021-12-22 Michael Saboff <[email protected]>
+
+ Fix WebKit Build issues when using system content path
+ https://bugs.webkit.org/show_bug.cgi?id=234624
+
+ Reviewed by Filip Pizlo.
+
+ Covered by existing tests.
+
+ Added SYSTEM_CONTENT_PATH processing to WebCore's normal location.
+
+ * Configurations/WebCore.xcconfig:
+
2021-12-22 Brent Fulgham <[email protected]>
Hardening: decodeArrayBuffer is missing WARN_UNUSED_RETURN
Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (287381 => 287382)
--- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2021-12-23 03:10:16 UTC (rev 287382)
@@ -150,9 +150,12 @@
SECTORDER_FLAGS_Production[sdk=iphoneos*] = -Wl,-order_file,$(SDKROOT)/AppleInternal/OrderFiles/WebCore.order;
SECTORDER_FLAGS_Production[sdk=macosx*] = -Wl,-order_file,WebCore.order;
-NORMAL_WEBCORE_FRAMEWORKS_DIR[sdk=iphone*] = $(PRODUCTION_FRAMEWORKS_DIR);
-NORMAL_WEBCORE_FRAMEWORKS_DIR[sdk=macosx*] = $(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Versions/A/Frameworks;
+NORMAL_WEBCORE_FRAMEWORKS_PREFIX = $(NORMAL_WEBCORE_FRAMEWORKS_PREFIX_$(USE_SYSTEM_CONTENT_PATH));
+NORMAL_WEBCORE_FRAMEWORKS_PREFIX_YES = $(SYSTEM_CONTENT_PATH);
+NORMAL_WEBCORE_FRAMEWORKS_DIR[sdk=iphone*] = $(NORMAL_WEBCORE_FRAMEWORKS_PREFIX)$(PRODUCTION_FRAMEWORKS_DIR);
+NORMAL_WEBCORE_FRAMEWORKS_DIR[sdk=macosx*] = $(NORMAL_WEBCORE_FRAMEWORKS_PREFIX)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Versions/A/Frameworks;
+
WEBCORE_FRAMEWORKS_DIR = $(WEBCORE_FRAMEWORKS_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
WEBCORE_FRAMEWORKS_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_NO = $(NORMAL_WEBCORE_FRAMEWORKS_DIR);
WEBCORE_FRAMEWORKS_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR);
Modified: trunk/Source/WebKit/ChangeLog (287381 => 287382)
--- trunk/Source/WebKit/ChangeLog 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/WebKit/ChangeLog 2021-12-23 03:10:16 UTC (rev 287382)
@@ -1,3 +1,15 @@
+2021-12-22 Michael Saboff <[email protected]>
+
+ Fix WebKit Build issues when using system content path
+ https://bugs.webkit.org/show_bug.cgi?id=234624
+
+ Reviewed by Filip Pizlo.
+
+ Added SYSTEM_CONTENT_PATH processing to the nested frameworks path (UMBRELLA_FRAMEWORKS_DIR).
+
+ * Configurations/BaseTarget.xcconfig:
+ * Configurations/WebKit.xcconfig:
+
2021-12-22 Aditya Keerthi <[email protected]>
[iOS] metromile.com <select> dropdowns open twice
Modified: trunk/Source/WebKit/Configurations/BaseTarget.xcconfig (287381 => 287382)
--- trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/WebKit/Configurations/BaseTarget.xcconfig 2021-12-23 03:10:16 UTC (rev 287382)
@@ -99,13 +99,16 @@
_javascript_CORE_PRIVATE_HEADERS_DIR_Production_COCOA_TOUCH_NO = $(SDKROOT)$(PRODUCTION_FRAMEWORKS_DIR)/_javascript_Core.framework/PrivateHeaders;
_javascript_CORE_PRIVATE_HEADERS_engineering = $(BUILT_PRODUCTS_DIR)/_javascript_Core.framework/PrivateHeaders;
+UMBRELLA_FRAMEWORKS_PREFIX = $(UMBRELLA_FRAMEWORKS_PREFIX_USE_SYSTEM_CONTENT_PATH_$(USE_SYSTEM_CONTENT_PATH));
+UMBRELLA_FRAMEWORKS_PREFIX_USE_SYSTEM_CONTENT_PATH_YES = $(SYSTEM_CONTENT_PATH);
+
UMBRELLA_FRAMEWORKS_DIR = $(UMBRELLA_FRAMEWORKS_DIR_$(CONFIGURATION));
UMBRELLA_FRAMEWORKS_DIR_Debug = $(UMBRELLA_FRAMEWORKS_DIR_engineering);
UMBRELLA_FRAMEWORKS_DIR_Release = $(UMBRELLA_FRAMEWORKS_DIR_engineering);
UMBRELLA_FRAMEWORKS_DIR_Production = $(UMBRELLA_FRAMEWORKS_DIR_Production_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
-UMBRELLA_FRAMEWORKS_DIR_Production_COCOA_TOUCH_YES = $(SDKROOT)$(WK_ALTERNATE_WEBKIT_SDK_PATH)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+UMBRELLA_FRAMEWORKS_DIR_Production_COCOA_TOUCH_YES = $(SDKROOT)$(UMBRELLA_FRAMEWORKS_PREFIX)$(WK_ALTERNATE_WEBKIT_SDK_PATH)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
UMBRELLA_FRAMEWORKS_DIR_Production_COCOA_TOUCH_NO = $(SDKROOT)$(UMBRELLA_FRAMEWORKS_DIR_Production_macosx_USE_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
-UMBRELLA_FRAMEWORKS_DIR_Production_macosx_USE_OVERRIDE_FRAMEWORKS_DIR_NO = $(NEXT_ROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Versions/A/Frameworks;
+UMBRELLA_FRAMEWORKS_DIR_Production_macosx_USE_OVERRIDE_FRAMEWORKS_DIR_NO = $(NEXT_ROOT)$(UMBRELLA_FRAMEWORKS_PREFIX)$(SYSTEM_LIBRARY_DIR)/Frameworks/WebKit.framework/Versions/A/Frameworks;
UMBRELLA_FRAMEWORKS_DIR_Production_macosx_USE_OVERRIDE_FRAMEWORKS_DIR_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR);
UMBRELLA_FRAMEWORKS_DIR_engineering = $(BUILT_PRODUCTS_DIR);
Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (287381 => 287382)
--- trunk/Source/WebKit/Configurations/WebKit.xcconfig 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig 2021-12-23 03:10:16 UTC (rev 287382)
@@ -42,6 +42,11 @@
DYLIB_INSTALL_NAME_BASE_NO = $(NORMAL_WEBKIT_FRAMEWORKS_DIR);
DYLIB_INSTALL_NAME_BASE_YES = $(DYLIB_INSTALL_NAME_BASE);
+ALTERNATE_ROOT_PATH = $(DYLIB_INSTALL_NAME_BASE);
+
+OUTPUT_ALTERNATE_ROOT_PATH = $(OUTPUT_ALTERNATE_ROOT_PATH_$(USE_SYSTEM_CONTENT_PATH));
+OUTPUT_ALTERNATE_ROOT_PATH_YES = $(DSTROOT)$(ALTERNATE_ROOT_PATH)/$(FULL_PRODUCT_NAME);
+
LIBRARY_SEARCH_PATHS = $(inherited) "$(LIBWEBRTC_LIBRARY_DIR)";
WK_ACCESSIBILITY_LDFLAGS = $(WK_ACCESSIBILITY_LDFLAGS_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (287381 => 287382)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-12-23 03:10:16 UTC (rev 287382)
@@ -1,3 +1,14 @@
+2021-12-22 Michael Saboff <[email protected]>
+
+ Fix WebKit Build issues when using system content path
+ https://bugs.webkit.org/show_bug.cgi?id=234624
+
+ Reviewed by Filip Pizlo.
+
+ Added SYSTEM_CONTENT_PATH processing to NORMAL_PRODUCTION_FRAMEWORKS_DIR.
+
+ * Configurations/WebKitLegacy.xcconfig:
+
2021-12-21 Brady Eidson <[email protected]>
Make Notification identifiers be a UUID string instead of a uint64_t
Modified: trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig (287381 => 287382)
--- trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig 2021-12-23 02:19:55 UTC (rev 287381)
+++ trunk/Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig 2021-12-23 03:10:16 UTC (rev 287382)
@@ -116,9 +116,12 @@
WEBKIT_LEGACY_FRAMEWORKS_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_NO = $(NORMAL_WEBKIT_LEGACY_FRAMEWORKS_DIR);
WEBKIT_LEGACY_FRAMEWORKS_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR);
+NORMAL_PRODUCTION_FRAMEWORKS_PREFIX = $(NORMAL_PRODUCTION_FRAMEWORKS_PREFIX_$(USE_SYSTEM_CONTENT_PATH));
+NORMAL_PRODUCTION_FRAMEWORKS_PREFIX_YES = $(SYSTEM_CONTENT_PATH);
+
NORMAL_PRODUCTION_FRAMEWORKS_DIR = $(NORMAL_PRODUCTION_FRAMEWORKS_DIR_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
-NORMAL_PRODUCTION_FRAMEWORKS_DIR_COCOA_TOUCH_YES = $(SDKROOT)$(WK_ALTERNATE_WEBKIT_SDK_PATH)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
-NORMAL_PRODUCTION_FRAMEWORKS_DIR_COCOA_TOUCH_NO = $(NEXT_ROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks;
+NORMAL_PRODUCTION_FRAMEWORKS_DIR_COCOA_TOUCH_YES = $(SDKROOT)$(NORMAL_PRODUCTION_FRAMEWORKS_PREFIX)$(WK_ALTERNATE_WEBKIT_SDK_PATH)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+NORMAL_PRODUCTION_FRAMEWORKS_DIR_COCOA_TOUCH_NO = $(NEXT_ROOT)$(NORMAL_PRODUCTION_FRAMEWORKS_PREFIX)$(SYSTEM_LIBRARY_DIR)/Frameworks;
PRODUCTION_FRAMEWORKS_DIR = $(PRODUCTION_FRAMEWORKS_DIR_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
PRODUCTION_FRAMEWORKS_DIR_COCOA_TOUCH_YES = $(NORMAL_PRODUCTION_FRAMEWORKS_DIR);
