Title: [287388] trunk/Source/WebCore
Revision
287388
Author
[email protected]
Date
2021-12-23 00:54:35 -0800 (Thu, 23 Dec 2021)

Log Message

[GTK][a11y] Test accessibility/svg-remote-element.html crashes with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=234563

Reviewed by Adrian Perez de Castro.

This is because the remote svg element wrappers can't be created because the svg image page hasn't the root
object set.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement const): Set the root image wrapper element on the svg
image page.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (287387 => 287388)


--- trunk/Source/WebCore/ChangeLog	2021-12-23 08:53:38 UTC (rev 287387)
+++ trunk/Source/WebCore/ChangeLog	2021-12-23 08:54:35 UTC (rev 287388)
@@ -1,5 +1,19 @@
 2021-12-23  Carlos Garcia Campos  <[email protected]>
 
+        [GTK][a11y] Test accessibility/svg-remote-element.html crashes with ATSPI
+        https://bugs.webkit.org/show_bug.cgi?id=234563
+
+        Reviewed by Adrian Perez de Castro.
+
+        This is because the remote svg element wrappers can't be created because the svg image page hasn't the root
+        object set.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::remoteSVGRootElement const): Set the root image wrapper element on the svg
+        image page.
+
+2021-12-23  Carlos Garcia Campos  <[email protected]>
+
         [GTK][a11y] WTR: add support for notifications when building with ATSPI
         https://bugs.webkit.org/show_bug.cgi?id=234550
 

Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (287387 => 287388)


--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2021-12-23 08:53:38 UTC (rev 287387)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2021-12-23 08:54:35 UTC (rev 287388)
@@ -3397,7 +3397,12 @@
     ASSERT(!createIfNecessary || rootSVGObject);
     if (!is<AccessibilitySVGRoot>(rootSVGObject))
         return nullptr;
-    
+
+#if USE(ATSPI)
+    if (auto* page = document->page())
+        page->setAccessibilityRootObject(createIfNecessary == Create ? axObjectCache()->document().page()->accessibilityRootObject() : nullptr);
+#endif
+
     return downcast<AccessibilitySVGRoot>(rootSVGObject);
 }
     
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to