Title: [287396] trunk/Tools
Revision
287396
Author
[email protected]
Date
2021-12-23 08:53:42 -0800 (Thu, 23 Dec 2021)

Log Message

[Flatpak] Fix a11y tests on some distros including Fedora
https://bugs.webkit.org/show_bug.cgi?id=234612

Reviewed by Michael Catanzaro.

Using --no-a11y-bus fixes a11y working in Fedora, as well
as just being the intended behavior it always had since we
granted direct org.a11y.Bus access.

* flatpak/flatpakutils.py:
(WebkitFlatpak):
(WebkitFlatpak.run_in_sandbox):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (287395 => 287396)


--- trunk/Tools/ChangeLog	2021-12-23 15:07:24 UTC (rev 287395)
+++ trunk/Tools/ChangeLog	2021-12-23 16:53:42 UTC (rev 287396)
@@ -1,3 +1,18 @@
+2021-12-23  Patrick Griffis  <[email protected]>
+
+        [Flatpak] Fix a11y tests on some distros including Fedora
+        https://bugs.webkit.org/show_bug.cgi?id=234612
+
+        Reviewed by Michael Catanzaro.
+
+        Using --no-a11y-bus fixes a11y working in Fedora, as well
+        as just being the intended behavior it always had since we
+        granted direct org.a11y.Bus access.
+
+        * flatpak/flatpakutils.py:
+        (WebkitFlatpak):
+        (WebkitFlatpak.run_in_sandbox):
+
 2021-12-23  Carlos Garcia Campos  <[email protected]>
 
         [GTK][a11y] WTR: handle heading level as special case in intValue with ATSPI

Modified: trunk/Tools/flatpak/flatpakutils.py (287395 => 287396)


--- trunk/Tools/flatpak/flatpakutils.py	2021-12-23 15:07:24 UTC (rev 287395)
+++ trunk/Tools/flatpak/flatpakutils.py	2021-12-23 16:53:42 UTC (rev 287396)
@@ -705,6 +705,10 @@
         # For now this supports only files in the WebKit path
         return host_path.replace(self.source_root, self.sandbox_source_root)
 
+    @staticmethod
+    def get_user_runtime_dir():
+        return os.environ.get('XDG_RUNTIME_DIR', os.path.join('/run/user', str(os.getuid())))
+
     def run_in_sandbox(self, *args, **kwargs):
         if not self.setup_builddir():
             return 1
@@ -757,7 +761,12 @@
                            "--die-with-parent",
                            "--filesystem=host",
                            "--allow=devel",
+                           # FIXME: --session-bus is only a workaround for https://github.com/flatpak/flatpak/pull/4630
+                           "--session-bus",
+                           "--no-a11y-bus",
                            "--talk-name=org.a11y.Bus",
+                           # at-spi creates directories like `$XDG_RUNTIME_DIR/at-spi2-E6A5E1` on the host
+                           "--filesystem=" + self.get_user_runtime_dir(),
                            "--talk-name=org.gtk.vfs",
                            "--talk-name=org.gtk.vfs.*"]
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to