Title: [287450] trunk/Source/WebKit
- Revision
- 287450
- Author
- [email protected]
- Date
- 2021-12-26 15:11:37 -0800 (Sun, 26 Dec 2021)
Log Message
RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uint32_t
https://bugs.webkit.org/show_bug.cgi?id=234657
Reviewed by Don Olmstead.
connectionID a parameter of ScriptMessageClient::didPostMessage() is casteed as <int>.
Since ConnectionID is define as uint32_t, it should be casted as <uint32_t>.
* UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp: Fixed cast for connectionID.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (287449 => 287450)
--- trunk/Source/WebKit/ChangeLog 2021-12-26 21:53:12 UTC (rev 287449)
+++ trunk/Source/WebKit/ChangeLog 2021-12-26 23:11:37 UTC (rev 287450)
@@ -1,3 +1,15 @@
+2021-12-26 Yousuke Kimoto <[email protected]>
+
+ RemoteInspectorProtocolHandler::inspect() expects ConnectionID as uint32_t
+ https://bugs.webkit.org/show_bug.cgi?id=234657
+
+ Reviewed by Don Olmstead.
+
+ connectionID a parameter of ScriptMessageClient::didPostMessage() is casteed as <int>.
+ Since ConnectionID is define as uint32_t, it should be casted as <uint32_t>.
+
+ * UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp: Fixed cast for connectionID.
+
2021-12-25 Commit Queue <[email protected]>
Unreviewed, reverting r285088.
Modified: trunk/Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp (287449 => 287450)
--- trunk/Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp 2021-12-26 21:53:12 UTC (rev 287449)
+++ trunk/Source/WebKit/UIProcess/Inspector/socket/RemoteInspectorProtocolHandler.cpp 2021-12-26 23:11:37 UTC (rev 287450)
@@ -60,7 +60,7 @@
return;
URL requestURL { { }, page.pageLoadState().url() };
- m_inspectorProtocolHandler.inspect(requestURL.hostAndPort(), parseInteger<int>(tokens[0]).value_or(0), parseInteger<int>(tokens[1]).value_or(0), tokens[2]);
+ m_inspectorProtocolHandler.inspect(requestURL.hostAndPort(), parseInteger<uint32_t>(tokens[0]).value_or(0), parseInteger<uint32_t>(tokens[1]).value_or(0), tokens[2]);
}
bool supportsAsyncReply() override
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
