Diff
Modified: trunk/LayoutTests/ChangeLog (287508 => 287509)
--- trunk/LayoutTests/ChangeLog 2022-01-02 01:06:42 UTC (rev 287508)
+++ trunk/LayoutTests/ChangeLog 2022-01-02 07:22:11 UTC (rev 287509)
@@ -1,3 +1,17 @@
+2022-01-01 Antoine Quint <[email protected]>
+
+ "animation" shorthand does not parse values in the right order
+ https://bugs.webkit.org/show_bug.cgi?id=234788
+
+ Reviewed by Dean Jackson.
+
+ Update the order in which animation-name is serialized in the "animation" shorthand
+ for some non-WPT tests.
+
+ * fast/css/longhand-overrides-shorthand-prefixing-expected.txt:
+ * fast/css/longhand-overrides-shorthand-prefixing.html:
+ * fast/css/transform-inline-style-remove-expected.txt:
+
2022-01-01 Diego Pino Garcia <[email protected]>
[GTK] Unreviewed test gardening, update flakey tests expectations
Modified: trunk/LayoutTests/fast/css/longhand-overrides-shorthand-prefixing-expected.txt (287508 => 287509)
--- trunk/LayoutTests/fast/css/longhand-overrides-shorthand-prefixing-expected.txt 2022-01-02 01:06:42 UTC (rev 287508)
+++ trunk/LayoutTests/fast/css/longhand-overrides-shorthand-prefixing-expected.txt 2022-01-02 07:22:11 UTC (rev 287509)
@@ -3,35 +3,35 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-Setting "animation" to "move 2s" then "animation-duration" to "10s" accessing "animation"
+Setting "animation" to "2s move" then "animation-duration" to "10s" accessing "animation"
PASS element.style.animation
PASS element.style.cssText
-Setting "animation" to "move 2s" then "animation-duration" to "10s" accessing "webkitAnimation"
+Setting "animation" to "2s move" then "animation-duration" to "10s" accessing "webkitAnimation"
PASS element.style.animation
PASS element.style.cssText
-Setting "-webkit-animation" to "move 2s" then "animation-duration" to "10s" accessing "animation"
+Setting "-webkit-animation" to "2s move" then "animation-duration" to "10s" accessing "animation"
PASS element.style.webkitAnimation
PASS element.style.cssText
-Setting "-webkit-animation" to "move 2s" then "animation-duration" to "10s" accessing "webkitAnimation"
+Setting "-webkit-animation" to "2s move" then "animation-duration" to "10s" accessing "webkitAnimation"
PASS element.style.webkitAnimation
PASS element.style.cssText
-Setting "animation" to "move 2s" then "-webkit-animation-duration" to "10s" accessing "animation"
+Setting "animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "animation"
PASS element.style.animation
PASS element.style.cssText
-Setting "animation" to "move 2s" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
+Setting "animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
PASS element.style.animation
PASS element.style.cssText
-Setting "-webkit-animation" to "move 2s" then "-webkit-animation-duration" to "10s" accessing "animation"
+Setting "-webkit-animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "animation"
PASS element.style.webkitAnimation
PASS element.style.cssText
-Setting "-webkit-animation" to "move 2s" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
+Setting "-webkit-animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
PASS element.style.webkitAnimation
PASS element.style.cssText
Modified: trunk/LayoutTests/fast/css/longhand-overrides-shorthand-prefixing.html (287508 => 287509)
--- trunk/LayoutTests/fast/css/longhand-overrides-shorthand-prefixing.html 2022-01-02 01:06:42 UTC (rev 287508)
+++ trunk/LayoutTests/fast/css/longhand-overrides-shorthand-prefixing.html 2022-01-02 07:22:11 UTC (rev 287509)
@@ -63,7 +63,7 @@
debug("");
}
-testPropertyVariants("animation", "animation-duration", "move 2s", "move 10s", "10s");
+testPropertyVariants("animation", "animation-duration", "2s move", "10s move", "10s");
successfullyParsed = true;
Modified: trunk/LayoutTests/fast/css/transform-inline-style-remove-expected.txt (287508 => 287509)
--- trunk/LayoutTests/fast/css/transform-inline-style-remove-expected.txt 2022-01-02 01:06:42 UTC (rev 287508)
+++ trunk/LayoutTests/fast/css/transform-inline-style-remove-expected.txt 2022-01-02 07:22:11 UTC (rev 287509)
@@ -19,7 +19,7 @@
transform origin X (after):
transform origin Y (after):
-animation (before): test 5s ease-in-out infinite alternate
+animation (before): 5s ease-in-out infinite alternate test
animation name (before): test
animation duration (before): 5s
animation timing function (before): ease-in-out
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287508 => 287509)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-02 01:06:42 UTC (rev 287508)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-02 07:22:11 UTC (rev 287509)
@@ -1,3 +1,14 @@
+2022-01-01 Antoine Quint <[email protected]>
+
+ "animation" shorthand does not parse values in the right order
+ https://bugs.webkit.org/show_bug.cgi?id=234788
+
+ Reviewed by Dean Jackson.
+
+ Mark a new WPT progression.
+
+ * web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt:
+
2021-12-31 Tim Nguyen <[email protected]>
Re-import css/css-writing-modes WPT
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt (287508 => 287509)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt 2022-01-02 01:06:42 UTC (rev 287508)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt 2022-01-02 07:22:11 UTC (rev 287509)
@@ -8,6 +8,6 @@
PASS e.style['animation'] = "paused" should set the property value
PASS e.style['animation'] = "none" should set the property value
PASS e.style['animation'] = "anim" should set the property value
-FAIL e.style['animation'] = "anim paused both reverse 4 1s -3s cubic-bezier(0, -2, 1, 3)" should set the property value assert_equals: serialization should be canonical expected "1s cubic-bezier(0, -2, 1, 3) -3s 4 reverse both paused anim" but got "anim 1s cubic-bezier(0, -2, 1, 3) -3s 4 reverse both paused"
-FAIL e.style['animation'] = "anim paused both reverse, 4 1s -3s cubic-bezier(0, -2, 1, 3)" should set the property value assert_equals: serialization should be canonical expected "0s ease 0s 1 reverse both paused anim, 1s cubic-bezier(0, -2, 1, 3) -3s 4 normal none running none" but got "anim reverse both paused, 1s cubic-bezier(0, -2, 1, 3) -3s 4"
+PASS e.style['animation'] = "anim paused both reverse 4 1s -3s cubic-bezier(0, -2, 1, 3)" should set the property value
+FAIL e.style['animation'] = "anim paused both reverse, 4 1s -3s cubic-bezier(0, -2, 1, 3)" should set the property value assert_equals: serialization should be canonical expected "0s ease 0s 1 reverse both paused anim, 1s cubic-bezier(0, -2, 1, 3) -3s 4 normal none running none" but got "reverse both paused anim, 1s cubic-bezier(0, -2, 1, 3) -3s 4"
Modified: trunk/Source/WebCore/ChangeLog (287508 => 287509)
--- trunk/Source/WebCore/ChangeLog 2022-01-02 01:06:42 UTC (rev 287508)
+++ trunk/Source/WebCore/ChangeLog 2022-01-02 07:22:11 UTC (rev 287509)
@@ -1,3 +1,14 @@
+2022-01-01 Antoine Quint <[email protected]>
+
+ "animation" shorthand does not parse values in the right order
+ https://bugs.webkit.org/show_bug.cgi?id=234788
+
+ Reviewed by Dean Jackson.
+
+ The animation-name should be parsed last, not first.
+
+ * css/CSSProperties.json:
+
2022-01-01 Jean-Yves Avenard <[email protected]>
ScalableImageDecoder should be using SharedBuffer instead of DataSegment
Modified: trunk/Source/WebCore/css/CSSProperties.json (287508 => 287509)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-01-02 01:06:42 UTC (rev 287508)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-01-02 07:22:11 UTC (rev 287509)
@@ -899,7 +899,6 @@
"-webkit-animation"
],
"longhands": [
- "animation-name",
"animation-duration",
"animation-timing-function",
"animation-delay",
@@ -906,7 +905,8 @@
"animation-iteration-count",
"animation-direction",
"animation-fill-mode",
- "animation-play-state"
+ "animation-play-state",
+ "animation-name"
]
},
"specification": {
