Title: [287554] trunk
- Revision
- 287554
- Author
- [email protected]
- Date
- 2022-01-03 13:49:37 -0800 (Mon, 03 Jan 2022)
Log Message
Unreviewed, reverting r287550.
https://bugs.webkit.org/show_bug.cgi?id=234829
Reverted changeset:
"[Web Animations] changing the effect of a transition should
no longer have it marked as running"
https://bugs.webkit.org/show_bug.cgi?id=234823
https://commits.webkit.org/r287550
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287553 => 287554)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-03 21:47:42 UTC (rev 287553)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-03 21:49:37 UTC (rev 287554)
@@ -1,3 +1,16 @@
+2022-01-03 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r287550.
+ https://bugs.webkit.org/show_bug.cgi?id=234829
+
+
+ Reverted changeset:
+
+ "[Web Animations] changing the effect of a transition should
+ no longer have it marked as running"
+ https://bugs.webkit.org/show_bug.cgi?id=234823
+ https://commits.webkit.org/r287550
+
2022-01-03 Antoine Quint <[email protected]>
Unreviewed test gardening, this test progressed in the way it fails but the test expectation
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-effect.tentative-expected.txt (287553 => 287554)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-effect.tentative-expected.txt 2022-01-03 21:47:42 UTC (rev 287553)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/CSSTransition-effect.tentative-expected.txt 2022-01-03 21:49:37 UTC (rev 287554)
@@ -2,7 +2,7 @@
PASS After setting a transition's effect to null, it still reports the original transition property
PASS After setting a transition's effect to null, it becomes finished
PASS After setting a transition's effect to null, style is updated
-PASS After setting a transition's effect to null, a new transition can be started
+FAIL After setting a transition's effect to null, a new transition can be started assert_equals: expected "100px" but got "0px"
PASS After setting a transition's effect to null, it should be possible to interrupt that transition
PASS After setting a new keyframe effect with a shorter duration, the transition becomes finished
PASS After setting a new keyframe effect targeting different properties, the transition continues to report the original transition property
Modified: trunk/Source/WebCore/ChangeLog (287553 => 287554)
--- trunk/Source/WebCore/ChangeLog 2022-01-03 21:47:42 UTC (rev 287553)
+++ trunk/Source/WebCore/ChangeLog 2022-01-03 21:49:37 UTC (rev 287554)
@@ -1,3 +1,16 @@
+2022-01-03 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r287550.
+ https://bugs.webkit.org/show_bug.cgi?id=234829
+
+
+ Reverted changeset:
+
+ "[Web Animations] changing the effect of a transition should
+ no longer have it marked as running"
+ https://bugs.webkit.org/show_bug.cgi?id=234823
+ https://commits.webkit.org/r287550
+
2022-01-03 Sam Weinig <[email protected]>
Add resolved/unresolved color type accessors to require users to be explicit about whether they will handle missing/none color components
Modified: trunk/Source/WebCore/animation/DeclarativeAnimation.cpp (287553 => 287554)
--- trunk/Source/WebCore/animation/DeclarativeAnimation.cpp 2022-01-03 21:47:42 UTC (rev 287553)
+++ trunk/Source/WebCore/animation/DeclarativeAnimation.cpp 2022-01-03 21:49:37 UTC (rev 287554)
@@ -235,17 +235,6 @@
disassociateFromOwningElement();
}
-void DeclarativeAnimation::setEffect(RefPtr<AnimationEffect>&& newEffect)
-{
- if (effect() == newEffect)
- return;
-
- WebAnimation::setEffect(WTFMove(newEffect));
-
- if (auto styleable = owningElement())
- styleable->removeDeclarativeAnimationFromListsForOwningElement(*this);
-}
-
AnimationEffectPhase DeclarativeAnimation::phaseWithoutEffect() const
{
// This shouldn't be called if we actually have an effect.
Modified: trunk/Source/WebCore/animation/DeclarativeAnimation.h (287553 => 287554)
--- trunk/Source/WebCore/animation/DeclarativeAnimation.h 2022-01-03 21:47:42 UTC (rev 287553)
+++ trunk/Source/WebCore/animation/DeclarativeAnimation.h 2022-01-03 21:49:37 UTC (rev 287554)
@@ -64,7 +64,6 @@
ExceptionOr<void> bindingsPause() override;
void setTimeline(RefPtr<AnimationTimeline>&&) final;
- void setEffect(RefPtr<AnimationEffect>&&) final;
void cancel() final;
void tick() override;
Modified: trunk/Source/WebCore/animation/WebAnimation.h (287553 => 287554)
--- trunk/Source/WebCore/animation/WebAnimation.h 2022-01-03 21:47:42 UTC (rev 287553)
+++ trunk/Source/WebCore/animation/WebAnimation.h 2022-01-03 21:49:37 UTC (rev 287554)
@@ -73,7 +73,7 @@
AnimationEffect* bindingsEffect() const { return effect(); }
virtual void setBindingsEffect(RefPtr<AnimationEffect>&&);
AnimationEffect* effect() const { return m_effect.get(); }
- virtual void setEffect(RefPtr<AnimationEffect>&&);
+ void setEffect(RefPtr<AnimationEffect>&&);
AnimationTimeline* timeline() const { return m_timeline.get(); }
virtual void setTimeline(RefPtr<AnimationTimeline>&&);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
