Title: [287603] trunk/Source/WebCore
Revision
287603
Author
grao...@webkit.org
Date
2022-01-04 23:33:56 -0800 (Tue, 04 Jan 2022)

Log Message

RenderStyle::transitionForProperty() is unused
https://bugs.webkit.org/show_bug.cgi?id=234860

Reviewed by Dean Jackson.

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::transitionForProperty const): Deleted.
* rendering/style/RenderStyle.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (287602 => 287603)


--- trunk/Source/WebCore/ChangeLog	2022-01-05 07:03:15 UTC (rev 287602)
+++ trunk/Source/WebCore/ChangeLog	2022-01-05 07:33:56 UTC (rev 287603)
@@ -1,5 +1,16 @@
 2022-01-04  Antoine Quint  <grao...@webkit.org>
 
+        RenderStyle::transitionForProperty() is unused
+        https://bugs.webkit.org/show_bug.cgi?id=234860
+
+        Reviewed by Dean Jackson.
+
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::RenderStyle::transitionForProperty const): Deleted.
+        * rendering/style/RenderStyle.h:
+
+2022-01-04  Antoine Quint  <grao...@webkit.org>
+
         WPT test css/css-transitions/parsing/transition-shorthand.html has failures
         https://bugs.webkit.org/show_bug.cgi?id=234856
 

Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (287602 => 287603)


--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2022-01-05 07:03:15 UTC (rev 287602)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2022-01-05 07:33:56 UTC (rev 287603)
@@ -1811,19 +1811,6 @@
     return object.document().settings().css3DTransformInteroperabilityEnabled() ? std::max(1.0f, perspective()) : perspective();
 }
 
-const Animation* RenderStyle::transitionForProperty(CSSPropertyID property) const
-{
-    auto* transitions = this->transitions();
-    if (!transitions)
-        return nullptr;
-    for (size_t i = 0, size = transitions->size(); i < size; ++i) {
-        auto& animation = transitions->animation(i);
-        if (animation.property().mode == Animation::TransitionMode::All || animation.property().id == property)
-            return &animation;
-    }
-    return nullptr;
-}
-
 const FontCascade& RenderStyle::fontCascade() const
 {
     return m_inheritedData->fontCascade;

Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (287602 => 287603)


--- trunk/Source/WebCore/rendering/style/RenderStyle.h	2022-01-05 07:03:15 UTC (rev 287602)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h	2022-01-05 07:33:56 UTC (rev 287603)
@@ -720,9 +720,6 @@
     bool hasAnimations() const { return m_rareNonInheritedData->animations && m_rareNonInheritedData->animations->size() > 0; }
     bool hasTransitions() const { return m_rareNonInheritedData->transitions && m_rareNonInheritedData->transitions->size() > 0; }
 
-    // Return the first found Animation (including 'all' transitions).
-    const Animation* transitionForProperty(CSSPropertyID) const;
-
     TransformStyle3D transformStyle3D() const { return static_cast<TransformStyle3D>(m_rareNonInheritedData->transformStyle3D); }
     bool preserves3D() const { return transformStyle3D() == TransformStyle3D::Preserve3D; }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to