Title: [287760] trunk
- Revision
- 287760
- Author
- [email protected]
- Date
- 2022-01-07 10:44:50 -0800 (Fri, 07 Jan 2022)
Log Message
Allow storing form data responses in Cache Storage
https://bugs.webkit.org/show_bug.cgi?id=234881
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
* web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
Source/WebCore:
Covered by rebased tests.
* Modules/cache/DOMCache.cpp:
(WebCore::DOMCache::put):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287759 => 287760)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-07 18:43:28 UTC (rev 287759)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-07 18:44:50 UTC (rev 287760)
@@ -1,3 +1,12 @@
+2022-01-07 Youenn Fablet <[email protected]>
+
+ Allow storing form data responses in Cache Storage
+ https://bugs.webkit.org/show_bug.cgi?id=234881
+
+ Reviewed by Alex Christensen.
+
+ * web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
+
2022-01-07 Martin Robinson <[email protected]>
When transform-style: preserve-3d is used with a grouping property it should still create a containing block
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt (287759 => 287760)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt 2022-01-07 18:43:28 UTC (rev 287759)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt 2022-01-07 18:44:50 UTC (rev 287760)
@@ -24,5 +24,5 @@
PASS Cache.put with an embedded VARY:* Response
PASS Cache.put should store Response.redirect() correctly
PASS Cache.put called with simple Request and blob Response
-FAIL Cache.put called with simple Request and form data Response promise_test: Unhandled rejection with value: object "NotSupportedError: Not implemented"
+PASS Cache.put called with simple Request and form data Response
Modified: trunk/Source/WebCore/ChangeLog (287759 => 287760)
--- trunk/Source/WebCore/ChangeLog 2022-01-07 18:43:28 UTC (rev 287759)
+++ trunk/Source/WebCore/ChangeLog 2022-01-07 18:44:50 UTC (rev 287760)
@@ -1,5 +1,17 @@
2022-01-07 Youenn Fablet <[email protected]>
+ Allow storing form data responses in Cache Storage
+ https://bugs.webkit.org/show_bug.cgi?id=234881
+
+ Reviewed by Alex Christensen.
+
+ Covered by rebased tests.
+
+ * Modules/cache/DOMCache.cpp:
+ (WebCore::DOMCache::put):
+
+2022-01-07 Youenn Fablet <[email protected]>
+
Expose rvfc processingDuration for the WebRTC code path
https://bugs.webkit.org/show_bug.cgi?id=234949
Modified: trunk/Source/WebCore/Modules/cache/DOMCache.cpp (287759 => 287760)
--- trunk/Source/WebCore/Modules/cache/DOMCache.cpp 2022-01-07 18:43:28 UTC (rev 287759)
+++ trunk/Source/WebCore/Modules/cache/DOMCache.cpp 2022-01-07 18:44:50 UTC (rev 287760)
@@ -365,13 +365,8 @@
return;
}
- if (response->isBlobFormData()) {
- promise.reject(Exception { NotSupportedError, "Not implemented"_s });
- return;
- }
-
- // FIXME: for efficiency, we should load blobs directly instead of going through the readableStream path.
- if (response->isBlobBody()) {
+ // FIXME: for efficiency, we should load blobs/form data directly instead of going through the readableStream path.
+ if (response->isBlobBody() || response->isBlobFormData()) {
auto streamOrException = response->readableStream(*scriptExecutionContext()->globalObject());
if (UNLIKELY(streamOrException.hasException())) {
promise.reject(streamOrException.releaseException());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
