Title: [287764] trunk
- Revision
- 287764
- Author
- [email protected]
- Date
- 2022-01-07 10:56:47 -0800 (Fri, 07 Jan 2022)
Log Message
Transitions without an explicit property-name should not be considered
https://bugs.webkit.org/show_bug.cgi?id=234960
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Mark WPT progression.
* web-platform-tests/css/css-transitions/events-004-expected.txt:
Source/WebCore:
When we fill the transition-property to match the number of another `transition-`
property, we should not consider running a transition for that property.
* style/Styleable.cpp:
(WebCore::transitionMatchesProperty):
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (287763 => 287764)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-07 18:53:26 UTC (rev 287763)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-01-07 18:56:47 UTC (rev 287764)
@@ -1,3 +1,14 @@
+2022-01-07 Antoine Quint <[email protected]>
+
+ Transitions without an explicit property-name should not be considered
+ https://bugs.webkit.org/show_bug.cgi?id=234960
+
+ Reviewed by Darin Adler.
+
+ Mark WPT progression.
+
+ * web-platform-tests/css/css-transitions/events-004-expected.txt:
+
2022-01-07 Youenn Fablet <[email protected]>
Allow storing form data responses in Cache Storage
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/events-004-expected.txt (287763 => 287764)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/events-004-expected.txt 2022-01-07 18:53:26 UTC (rev 287763)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/events-004-expected.txt 2022-01-07 18:56:47 UTC (rev 287764)
@@ -1,4 +1,4 @@
PASS repeating lists
-FAIL truncating lists assert_approx_equals: expected 0.02 +/- 0.0005 but got 0.01
+PASS truncating lists
Modified: trunk/Source/WebCore/ChangeLog (287763 => 287764)
--- trunk/Source/WebCore/ChangeLog 2022-01-07 18:53:26 UTC (rev 287763)
+++ trunk/Source/WebCore/ChangeLog 2022-01-07 18:56:47 UTC (rev 287764)
@@ -1,3 +1,16 @@
+2022-01-07 Antoine Quint <[email protected]>
+
+ Transitions without an explicit property-name should not be considered
+ https://bugs.webkit.org/show_bug.cgi?id=234960
+
+ Reviewed by Darin Adler.
+
+ When we fill the transition-property to match the number of another `transition-`
+ property, we should not consider running a transition for that property.
+
+ * style/Styleable.cpp:
+ (WebCore::transitionMatchesProperty):
+
2022-01-07 Youenn Fablet <[email protected]>
Use completion handlers for takeAllMessagesForPort methods
Modified: trunk/Source/WebCore/style/Styleable.cpp (287763 => 287764)
--- trunk/Source/WebCore/style/Styleable.cpp 2022-01-07 18:53:26 UTC (rev 287763)
+++ trunk/Source/WebCore/style/Styleable.cpp 2022-01-07 18:56:47 UTC (rev 287764)
@@ -316,6 +316,9 @@
static bool transitionMatchesProperty(const Animation& transition, CSSPropertyID property)
{
+ if (transition.isPropertyFilled())
+ return false;
+
auto mode = transition.property().mode;
if (mode == Animation::TransitionMode::None || mode == Animation::TransitionMode::UnknownProperty)
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
