Title: [287774] trunk/Source/WebKit
- Revision
- 287774
- Author
- [email protected]
- Date
- 2022-01-07 11:48:43 -0800 (Fri, 07 Jan 2022)
Log Message
ImageBuffer with floating point logicalSize() paints into a slightly truncated destination rect
https://bugs.webkit.org/show_bug.cgi?id=225377
Reviewed by Tim Horton.
This is the rest of https://bugs.webkit.org/show_bug.cgi?id=232470.
This is also a follow-up of https://bugs.webkit.org/show_bug.cgi?id=232515.
No new tests; the behavior change is covered by
fast/backgrounds/hidpi-bitmap-background-origin-on-subpixel-position.html
since Tim Horton reverted the workaround for this bug that he landed in r276945.
* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (287773 => 287774)
--- trunk/Source/WebKit/ChangeLog 2022-01-07 19:46:23 UTC (rev 287773)
+++ trunk/Source/WebKit/ChangeLog 2022-01-07 19:48:43 UTC (rev 287774)
@@ -1,3 +1,23 @@
+2022-01-07 Myles C. Maxfield <[email protected]>
+
+ ImageBuffer with floating point logicalSize() paints into a slightly truncated destination rect
+ https://bugs.webkit.org/show_bug.cgi?id=225377
+
+ Reviewed by Tim Horton.
+
+ This is the rest of https://bugs.webkit.org/show_bug.cgi?id=232470.
+
+ This is also a follow-up of https://bugs.webkit.org/show_bug.cgi?id=232515.
+
+ No new tests; the behavior change is covered by
+ fast/backgrounds/hidpi-bitmap-background-origin-on-subpixel-position.html
+ since Tim Horton reverted the workaround for this bug that he landed in r276945.
+
+ * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+ (WebKit::RemoteLayerBackingStore::drawInContext):
+ * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+ (WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):
+
2022-01-07 Alex Christensen <[email protected]>
Unreviewed, reverting r287698.
Modified: trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (287773 => 287774)
--- trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-01-07 19:46:23 UTC (rev 287773)
+++ trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm 2022-01-07 19:48:43 UTC (rev 287774)
@@ -371,7 +371,7 @@
WebCore::IntRect layerBounds(WebCore::IntPoint(), WebCore::expandedIntSize(m_size));
if (!m_dirtyRegion.contains(layerBounds)) {
ASSERT(m_backBuffer.imageBuffer);
- context.drawImageBuffer(*m_backBuffer.imageBuffer, { {0, 0}, m_size }, { {0, 0}, m_size }, { WebCore::CompositeOperator::Copy });
+ context.drawImageBuffer(*m_backBuffer.imageBuffer, { 0, 0 }, { WebCore::CompositeOperator::Copy });
}
if (m_paintingRects.size() == 1)
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (287773 => 287774)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2022-01-07 19:46:23 UTC (rev 287773)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2022-01-07 19:48:43 UTC (rev 287774)
@@ -128,11 +128,6 @@
void RemoteRenderingBackendProxy::createRemoteImageBuffer(ImageBuffer& imageBuffer)
{
auto logicalSize = imageBuffer.logicalSize();
- if (logicalSize.width() > 1 || logicalSize.height() > 1) {
- // FIXME: https://bugs.webkit.org/show_bug.cgi?id=225377 If we unconditionally use imageBuffer.logicalSize() here instead of imageBuffer.truncatedLogicalSize(),
- // there may be a memory regression. See https://trac.webkit.org/changeset/287358/webkit
- logicalSize = imageBuffer.truncatedLogicalSize();
- }
sendToStream(Messages::RemoteRenderingBackend::CreateImageBuffer(logicalSize, imageBuffer.renderingMode(), imageBuffer.resolutionScale(), imageBuffer.colorSpace(), imageBuffer.pixelFormat(), imageBuffer.renderingResourceIdentifier()));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
