Diff
Modified: trunk/LayoutTests/ChangeLog (107093 => 107094)
--- trunk/LayoutTests/ChangeLog 2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/LayoutTests/ChangeLog 2012-02-08 16:57:45 UTC (rev 107094)
@@ -1,3 +1,18 @@
+2012-02-08 Alexei Svitkine <[email protected]>
+
+ Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
+ https://bugs.webkit.org/show_bug.cgi?id=78007
+
+ This got broken by: http://trac.webkit.org/changeset/105470
+ And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191
+
+ There is still three tests that fail from the set, but the cause for these is different,
+ which I'm still investigating.
+
+ Reviewed by James Robinson.
+
+ * platform/chromium/test_expectations.txt:
+
2012-02-08 Pavel Feldman <[email protected]>
Web Inspector: bind entire subtree upon childNodeInserted so that text node were accounted.
Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html (107093 => 107094)
--- trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html 2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html 2012-02-08 16:57:45 UTC (rev 107094)
@@ -11,7 +11,7 @@
}
::-webkit-scrollbar-track-piece,
::-webkit-scrollbar-corner {
- background-color: blue;
+ background-color: orange;
}
</style>
</head>
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw.html (107093 => 107094)
--- trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw.html 2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw.html 2012-02-08 16:57:45 UTC (rev 107094)
@@ -11,7 +11,7 @@
}
::-webkit-scrollbar-track-piece,
::-webkit-scrollbar-corner {
- background-color: blue;
+ background-color: orange;
}
</style>
</head>
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se.html (107093 => 107094)
--- trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se.html 2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se.html 2012-02-08 16:57:45 UTC (rev 107094)
@@ -11,7 +11,7 @@
}
::-webkit-scrollbar-track-piece,
::-webkit-scrollbar-corner {
- background-color: blue;
+ background-color: orange;
}
</style>
</head>
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw.html (107093 => 107094)
--- trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw.html 2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw.html 2012-02-08 16:57:45 UTC (rev 107094)
@@ -11,7 +11,7 @@
}
::-webkit-scrollbar-track-piece,
::-webkit-scrollbar-corner {
- background-color: blue;
+ background-color: orange;
}
</style>
</head>
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/overhang-e-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/overhang-n-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/overhang-ne-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/overhang-nw-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/overhang-s-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/overhang-se-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/overhang-sw-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/rubberbanding/overhang-w-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (107093 => 107094)
--- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-02-08 16:57:45 UTC (rev 107094)
@@ -517,9 +517,10 @@
// throw. V8 follows the spec.
WONTFIX SKIP : fast/js/reparsing-semicolon-insertion.html = FAIL
-// Rubber-banding is currently a CG only feature.
-WONTFIX : platform/chromium/rubberbanding = FAIL
-WONTFIX : platform/chromium/compositing/rubberbanding = IMAGE
+// These test rubber band overhang drawing, which is a Mac OS X Lion feature
+// that is not supported on other platforms.
+WONTFIX SKIP WIN LINUX : platform/chromium/rubberbanding = IMAGE
+WONTFIX SKIP WIN LINUX : platform/chromium/compositing/rubberbanding = IMAGE
// This requires usp10.dll version 1.600 or greater on Windows and
// it isn't installed on XP by default.
@@ -4042,6 +4043,10 @@
BUGWK77736 MAC WIN : svg/zoom/text/zoom-hixie-mixed-009.xml = IMAGE
BUGWK77736 : svg/zoom/text/zoom-hixie-rendering-model-004.xhtml = IMAGE+TEXT
+BUGWK78008 : platform/chromium/compositing/rubberbanding/transform-overhang-e.html = IMAGE
+BUGWK78008 : platform/chromium/compositing/rubberbanding/transform-overhang-se.html = IMAGE
+BUGWK78008 : platform/chromium/compositing/rubberbanding/transform-overhang-s.html = IMAGE
+
// SVGLoad event timing changes require some rebaselines.
BUGWK78084 : svg/custom/SVGPoint-matrixTransform.svg = IMAGE+TEXT
BUGWK78084 : svg/custom/getTransformToElement.svg = IMAGE+TEXT
Modified: trunk/Source/WebKit/chromium/ChangeLog (107093 => 107094)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-02-08 16:57:45 UTC (rev 107094)
@@ -1,3 +1,19 @@
+2012-02-08 Alexei Svitkine <[email protected]>
+
+ Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests.
+ https://bugs.webkit.org/show_bug.cgi?id=78007
+
+ This got broken by: http://trac.webkit.org/changeset/105470
+ And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191
+
+ There is still three tests that fail from the set, but the cause for these is different,
+ which I'm still investigating.
+
+ Reviewed by James Robinson.
+
+ * src/NonCompositedContentHost.cpp:
+ (WebKit::NonCompositedContentHost::NonCompositedContentHost):
+
2012-02-07 James Robinson <[email protected]>
[chromium] Move geometry headers in Platform API to Platform directory
Modified: trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp (107093 => 107094)
--- trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp 2012-02-08 16:42:23 UTC (rev 107093)
+++ trunk/Source/WebKit/chromium/src/NonCompositedContentHost.cpp 2012-02-08 16:57:45 UTC (rev 107094)
@@ -45,7 +45,9 @@
#endif
m_graphicsLayer->setDrawsContent(true);
m_graphicsLayer->platformLayer()->setIsNonCompositedContent(true);
+#if !ENABLE(RUBBER_BANDING)
m_graphicsLayer->platformLayer()->setBackgroundCoversViewport(true);
+#endif
m_graphicsLayer->platformLayer()->setOpaque(true);
}
