Title: [287855] trunk/Source/WebCore
- Revision
- 287855
- Author
- [email protected]
- Date
- 2022-01-10 13:54:06 -0800 (Mon, 10 Jan 2022)
Log Message
hasBrokenEncryptedMediaAPISupportQuirk and needsPreloadAutoQuirk have overly
permissive domain allow lists
https://bugs.webkit.org/show_bug.cgi?id=222130
<rdar://problem/74758560>
Reviewed by Jer Noble.
Fix quirk tests for subdomains of vimeo and hulu by using RegistrableDomain instead
of testing the url directly.
* page/Quirks.cpp:
(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
(WebCore::Quirks::needsPreloadAutoQuirk const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (287854 => 287855)
--- trunk/Source/WebCore/ChangeLog 2022-01-10 21:45:01 UTC (rev 287854)
+++ trunk/Source/WebCore/ChangeLog 2022-01-10 21:54:06 UTC (rev 287855)
@@ -1,3 +1,19 @@
+2022-01-10 Eric Carlson <[email protected]>
+
+ hasBrokenEncryptedMediaAPISupportQuirk and needsPreloadAutoQuirk have overly
+ permissive domain allow lists
+ https://bugs.webkit.org/show_bug.cgi?id=222130
+ <rdar://problem/74758560>
+
+ Reviewed by Jer Noble.
+
+ Fix quirk tests for subdomains of vimeo and hulu by using RegistrableDomain instead
+ of testing the url directly.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
+ (WebCore::Quirks::needsPreloadAutoQuirk const):
+
2022-01-10 Chris Dumez <[email protected]>
https://brianpeiris.github.io/spatial-audio-test/?ramped stops playing after a few seconds
Modified: trunk/Source/WebCore/page/Quirks.cpp (287854 => 287855)
--- trunk/Source/WebCore/page/Quirks.cpp 2022-01-10 21:45:01 UTC (rev 287854)
+++ trunk/Source/WebCore/page/Quirks.cpp 2022-01-10 21:54:06 UTC (rev 287855)
@@ -179,15 +179,9 @@
if (m_hasBrokenEncryptedMediaAPISupportQuirk)
return m_hasBrokenEncryptedMediaAPISupportQuirk.value();
- auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
+ auto domain = RegistrableDomain(m_document->url()).string();
+ m_hasBrokenEncryptedMediaAPISupportQuirk = domain == "starz.com"_s || domain == "youtube.com"_s || domain == "hulu.com"_s;
- m_hasBrokenEncryptedMediaAPISupportQuirk = domain == "starz.com"
- || domain.endsWith(".starz.com")
- || domain == "youtube.com"
- || domain.endsWith(".youtube.com")
- || domain == "hulu.com"
- || domain.endsWith("hulu.com");
-
return m_hasBrokenEncryptedMediaAPISupportQuirk.value();
}
@@ -822,10 +816,9 @@
if (m_needsPreloadAutoQuirk)
return m_needsPreloadAutoQuirk.value();
- auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
+ auto domain = RegistrableDomain(m_document->url()).string();
+ m_needsPreloadAutoQuirk = domain == "vimeo"_s;
- m_needsPreloadAutoQuirk = domain == "vimeo.com" || domain.endsWith("vimeo.com");
-
return m_needsPreloadAutoQuirk.value();
#else
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
