Title: [288035] trunk/Source/WebCore
- Revision
- 288035
- Author
- [email protected]
- Date
- 2022-01-14 15:24:08 -0800 (Fri, 14 Jan 2022)
Log Message
[Cleanup] Remove redundant (and incorrect) RenderStyle::isDisplayReplacedType
https://bugs.webkit.org/show_bug.cgi?id=235250
Reviewed by Simon Fraser.
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::isDisplayInlineType): display types do not make a box replaced.
(WebCore::RenderStyle::isDisplayReplacedType): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288034 => 288035)
--- trunk/Source/WebCore/ChangeLog 2022-01-14 22:58:18 UTC (rev 288034)
+++ trunk/Source/WebCore/ChangeLog 2022-01-14 23:24:08 UTC (rev 288035)
@@ -1,3 +1,14 @@
+2022-01-14 Alan Bujtas <[email protected]>
+
+ [Cleanup] Remove redundant (and incorrect) RenderStyle::isDisplayReplacedType
+ https://bugs.webkit.org/show_bug.cgi?id=235250
+
+ Reviewed by Simon Fraser.
+
+ * rendering/style/RenderStyle.h:
+ (WebCore::RenderStyle::isDisplayInlineType): display types do not make a box replaced.
+ (WebCore::RenderStyle::isDisplayReplacedType): Deleted.
+
2022-01-14 Chris Dumez <[email protected]>
Clarify / Optimize <select> logic given that deeply nested <option> or <optgroup> are not supported
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.h (288034 => 288035)
--- trunk/Source/WebCore/rendering/style/RenderStyle.h 2022-01-14 22:58:18 UTC (rev 288034)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.h 2022-01-14 23:24:08 UTC (rev 288035)
@@ -1997,7 +1997,6 @@
bool hasAutoLeftAndRight() const { return left().isAuto() && right().isAuto(); }
bool hasAutoTopAndBottom() const { return top().isAuto() && bottom().isAuto(); }
- static bool isDisplayReplacedType(DisplayType);
static bool isDisplayInlineType(DisplayType);
static bool isDisplayFlexibleBox(DisplayType);
static bool isDisplayGridBox(DisplayType);
@@ -2395,15 +2394,14 @@
return isHorizontalWritingMode() ? getShadowVerticalExtent(shadow, logicalTop, logicalBottom) : getShadowHorizontalExtent(shadow, logicalTop, logicalBottom);
}
-inline bool RenderStyle::isDisplayReplacedType(DisplayType display)
-{
- return display == DisplayType::InlineBlock || display == DisplayType::InlineBox || display == DisplayType::InlineFlex
- || display == DisplayType::InlineGrid || display == DisplayType::InlineTable;
-}
-
inline bool RenderStyle::isDisplayInlineType(DisplayType display)
{
- return display == DisplayType::Inline || isDisplayReplacedType(display);
+ return display == DisplayType::Inline
+ || display == DisplayType::InlineBlock
+ || display == DisplayType::InlineBox
+ || display == DisplayType::InlineFlex
+ || display == DisplayType::InlineGrid
+ || display == DisplayType::InlineTable;
}
inline bool RenderStyle::isDisplayFlexibleBox(DisplayType display)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
