Title: [288043] trunk/Tools
- Revision
- 288043
- Author
- [email protected]
- Date
- 2022-01-14 17:37:34 -0800 (Fri, 14 Jan 2022)
Log Message
[EWS] Only trigger builds for open and synchronize events
https://bugs.webkit.org/show_bug.cgi?id=235249
<rdar://problem/87615392>
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/events.py:
(Events.stopService):
(GitHubEventHandlerNoEdits):
(GitHubEventHandlerNoEdits.handle_pull_request):
* Tools/CISupport/ews-build/master.cfg:
Canonical link: https://commits.webkit.org/246068@main
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/events.py (288042 => 288043)
--- trunk/Tools/CISupport/ews-build/events.py 2022-01-15 01:26:44 UTC (rev 288042)
+++ trunk/Tools/CISupport/ews-build/events.py 2022-01-15 01:37:34 UTC (rev 288043)
@@ -27,6 +27,7 @@
import time
from buildbot.util import service
+from buildbot.www.hooks.github import GitHubEventHandler
from twisted.internet import defer
from twisted.internet import reactor
from twisted.internet.defer import succeed
@@ -214,3 +215,15 @@
self._buildCompleteConsumer.stopConsuming()
self._stepStartedConsumer.stopConsuming()
self._stepFinishedConsumer.stopConsuming()
+
+
+class GitHubEventHandlerNoEdits(GitHubEventHandler):
+ ACTIONS_TO_TRIGGER_EWS = ('opened', 'synchronize')
+
+ def handle_pull_request(self, payload, event):
+ pr_number = payload['number']
+ action = ""
+ if action not in self.ACTIONS_TO_TRIGGER_EWS:
+ log.msg('Action {} on PR #{} does not indicate code has been changed'.format(action, pr_number))
+ return ([], 'git')
+ return super(GitHubEventHandlerNoEdits, self).handle_pull_request(payload, event)
Modified: trunk/Tools/CISupport/ews-build/master.cfg (288042 => 288043)
--- trunk/Tools/CISupport/ews-build/master.cfg 2022-01-15 01:26:44 UTC (rev 288042)
+++ trunk/Tools/CISupport/ews-build/master.cfg 2022-01-15 01:37:34 UTC (rev 288043)
@@ -6,7 +6,7 @@
from datetime import timedelta
import loadConfig
-from events import Events
+from events import Events, GitHubEventHandlerNoEdits
def load_password(name):
@@ -41,9 +41,10 @@
'Workers.showWorkerBuilders': True,
}
c['www']['change_hook_dialects'] = dict(
- github=dict(
- secret=load_password('GITHUB_HOOK_SECRET'),
- github_property_whitelist=[
+ github={
+ 'class': GitHubEventHandlerNoEdits,
+ 'secret': load_password('GITHUB_HOOK_SECRET'),
+ 'github_property_whitelist': [
'github.number',
'github.title',
'github.head.ref',
@@ -50,7 +51,7 @@
'github.base.sha',
'github.head.repo.full_name',
],
- ),
+ },
)
if not is_test_mode_enabled:
Modified: trunk/Tools/ChangeLog (288042 => 288043)
--- trunk/Tools/ChangeLog 2022-01-15 01:26:44 UTC (rev 288042)
+++ trunk/Tools/ChangeLog 2022-01-15 01:37:34 UTC (rev 288043)
@@ -1,5 +1,19 @@
2022-01-14 Jonathan Bedard <[email protected]>
+ [EWS] Only trigger builds for open and synchronize events
+ https://bugs.webkit.org/show_bug.cgi?id=235249
+ <rdar://problem/87615392>
+
+ Reviewed by Aakash Jain.
+
+ * CISupport/ews-build/events.py:
+ (Events.stopService):
+ (GitHubEventHandlerNoEdits):
+ (GitHubEventHandlerNoEdits.handle_pull_request):
+ * CISupport/ews-build/master.cfg:
+
+2022-01-14 Jonathan Bedard <[email protected]>
+
[EWS] ShowIdentifier should support pull-requests
https://bugs.webkit.org/show_bug.cgi?id=235252
<rdar://problem/87618736>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
