Title: [288056] trunk/Source/WebCore
- Revision
- 288056
- Author
- [email protected]
- Date
- 2022-01-15 09:11:33 -0800 (Sat, 15 Jan 2022)
Log Message
AX: Remove AXAriaAttributeChanged notification because it's not used by anything
https://bugs.webkit.org/show_bug.cgi?id=235253
Reviewed by Chris Fleizach.
Nothing uses AXAriaAttributeChanged, but we still spend time processing
it through the notification pipeline (postNotification -> m_notificationsToPost -> updateIsolatedTree(notifications) + postPlatformNotification(notifications)).
This patch deletes it.
* accessibility/AXLogger.cpp:
(WebCore::operator<<):
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
* accessibility/AXObjectCache.h:
* accessibility/atspi/AXObjectCacheAtspi.cpp:
(WebCore::AXObjectCache::postPlatformNotification):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288055 => 288056)
--- trunk/Source/WebCore/ChangeLog 2022-01-15 13:36:49 UTC (rev 288055)
+++ trunk/Source/WebCore/ChangeLog 2022-01-15 17:11:33 UTC (rev 288056)
@@ -1,3 +1,23 @@
+2022-01-15 Tyler Wilcock <[email protected]>
+
+ AX: Remove AXAriaAttributeChanged notification because it's not used by anything
+ https://bugs.webkit.org/show_bug.cgi?id=235253
+
+ Reviewed by Chris Fleizach.
+
+ Nothing uses AXAriaAttributeChanged, but we still spend time processing
+ it through the notification pipeline (postNotification -> m_notificationsToPost -> updateIsolatedTree(notifications) + postPlatformNotification(notifications)).
+
+ This patch deletes it.
+
+ * accessibility/AXLogger.cpp:
+ (WebCore::operator<<):
+ * accessibility/AXObjectCache.cpp:
+ (WebCore::AXObjectCache::handleAttributeChange):
+ * accessibility/AXObjectCache.h:
+ * accessibility/atspi/AXObjectCacheAtspi.cpp:
+ (WebCore::AXObjectCache::postPlatformNotification):
+
2022-01-15 Alan Bujtas <[email protected]>
[LFC][IFC] imported/w3c/web-platform-tests/css/css-text/word-break/word-break-normal-ar-000.html fails with incorrect run position
Modified: trunk/Source/WebCore/accessibility/AXLogger.cpp (288055 => 288056)
--- trunk/Source/WebCore/accessibility/AXLogger.cpp 2022-01-15 13:36:49 UTC (rev 288055)
+++ trunk/Source/WebCore/accessibility/AXLogger.cpp 2022-01-15 17:11:33 UTC (rev 288056)
@@ -343,9 +343,6 @@
case AXObjectCache::AXNotification::AXActiveDescendantChanged:
stream << "AXActiveDescendantChanged";
break;
- case AXObjectCache::AXNotification::AXAriaAttributeChanged:
- stream << "AXAriaAttributeChanged";
- break;
case AXObjectCache::AXNotification::AXAriaRoleChanged:
stream << "AXAriaRoleChanged";
break;
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (288055 => 288056)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-01-15 13:36:49 UTC (rev 288055)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2022-01-15 17:11:33 UTC (rev 288056)
@@ -1847,8 +1847,6 @@
postNotification(element, AXObjectCache::AXRequiredStatusChanged);
else if (attrName == aria_sortAttr)
postNotification(element, AXObjectCache::AXSortDirectionChanged);
- else
- postNotification(element, AXObjectCache::AXAriaAttributeChanged);
}
void AXObjectCache::handleModalChange(Element& element)
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (288055 => 288056)
--- trunk/Source/WebCore/accessibility/AXObjectCache.h 2022-01-15 13:36:49 UTC (rev 288055)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h 2022-01-15 17:11:33 UTC (rev 288056)
@@ -268,7 +268,6 @@
enum AXNotification {
AXActiveDescendantChanged,
- AXAriaAttributeChanged,
AXAriaRoleChanged,
AXAutocorrectionOccured,
AXCheckedStateChanged,
Modified: trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp (288055 => 288056)
--- trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp 2022-01-15 13:36:49 UTC (rev 288055)
+++ trunk/Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp 2022-01-15 17:11:33 UTC (rev 288056)
@@ -157,8 +157,6 @@
if (auto* descendant = coreObject->activeDescendant())
platformHandleFocusedUIElementChanged(nullptr, descendant->node());
break;
- case AXAriaAttributeChanged:
- break;
case AXAriaRoleChanged:
break;
case AXAutocorrectionOccured:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
