Title: [107128] trunk/Source/_javascript_Core
- Revision
- 107128
- Author
- [email protected]
- Date
- 2012-02-08 13:35:34 -0800 (Wed, 08 Feb 2012)
Log Message
Fix issue encountered while debugging stacktraces
https://bugs.webkit.org/show_bug.cgi?id=78147
Reviewed by Gavin Barraclough.
Debugging is easier if we always ensure that we have a non-null
inferred name.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (107127 => 107128)
--- trunk/Source/_javascript_Core/ChangeLog 2012-02-08 21:32:54 UTC (rev 107127)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-02-08 21:35:34 UTC (rev 107128)
@@ -1,5 +1,18 @@
2012-02-08 Oliver Hunt <[email protected]>
+ Fix issue encountered while debugging stacktraces
+ https://bugs.webkit.org/show_bug.cgi?id=78147
+
+ Reviewed by Gavin Barraclough.
+
+ Debugging is easier if we always ensure that we have a non-null
+ inferred name.
+
+ * runtime/Executable.cpp:
+ (JSC::FunctionExecutable::FunctionExecutable):
+
+2012-02-08 Oliver Hunt <[email protected]>
+
updateTopCallframe in the baseline JIT doesn't provide enough information to the stubs
https://bugs.webkit.org/show_bug.cgi?id=78145
Modified: trunk/Source/_javascript_Core/runtime/Executable.cpp (107127 => 107128)
--- trunk/Source/_javascript_Core/runtime/Executable.cpp 2012-02-08 21:32:54 UTC (rev 107127)
+++ trunk/Source/_javascript_Core/runtime/Executable.cpp 2012-02-08 21:35:34 UTC (rev 107128)
@@ -137,7 +137,7 @@
, m_forceUsesArguments(forceUsesArguments)
, m_parameters(parameters)
, m_name(name)
- , m_inferredName(inferredName)
+ , m_inferredName(inferredName.isNull() ? exec->globalData().propertyNames->emptyIdentifier : inferredName)
, m_symbolTable(0)
{
}
@@ -148,7 +148,7 @@
, m_forceUsesArguments(forceUsesArguments)
, m_parameters(parameters)
, m_name(name)
- , m_inferredName(inferredName)
+ , m_inferredName(inferredName.isNull() ? exec->globalData().propertyNames->emptyIdentifier : inferredName)
, m_symbolTable(0)
{
}
Modified: trunk/Source/_javascript_Core/runtime/JSFunction.cpp (107127 => 107128)
--- trunk/Source/_javascript_Core/runtime/JSFunction.cpp 2012-02-08 21:32:54 UTC (rev 107127)
+++ trunk/Source/_javascript_Core/runtime/JSFunction.cpp 2012-02-08 21:35:34 UTC (rev 107128)
@@ -370,7 +370,7 @@
return function->calculatedDisplayName(callFrame);
if (InternalFunction* function = jsDynamicCast<InternalFunction*>(object))
return function->calculatedDisplayName(callFrame);
- return UString();
+ return callFrame->globalData().propertyNames->emptyIdentifier.ustring();
}
} // namespace JSC
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
