Title: [288223] trunk/Source/WebCore
Revision
288223
Author
[email protected]
Date
2022-01-19 11:48:23 -0800 (Wed, 19 Jan 2022)

Log Message

Assertion is not acquired in network process when setting database journal mode
https://bugs.webkit.org/show_bug.cgi?id=235340

Setting database journal mode requires lock, so network process needs to stay active by holding assertion.

Reviewed by Chris Dumez.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::useWALJournalMode):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (288222 => 288223)


--- trunk/Source/WebCore/ChangeLog	2022-01-19 19:47:31 UTC (rev 288222)
+++ trunk/Source/WebCore/ChangeLog	2022-01-19 19:48:23 UTC (rev 288223)
@@ -1,3 +1,15 @@
+2022-01-19  Sihui Liu  <[email protected]>
+
+        Assertion is not acquired in network process when setting database journal mode
+        https://bugs.webkit.org/show_bug.cgi?id=235340
+
+        Setting database journal mode requires lock, so network process needs to stay active by holding assertion.
+
+        Reviewed by Chris Dumez.
+
+        * platform/sql/SQLiteDatabase.cpp:
+        (WebCore::SQLiteDatabase::useWALJournalMode):
+
 2022-01-19  Tyler Wilcock  <[email protected]>
 
         AX: Remove unnecessary isolated tree update for AXSelectedTextChanged node

Modified: trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp (288222 => 288223)


--- trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2022-01-19 19:47:31 UTC (rev 288222)
+++ trunk/Source/WebCore/platform/sql/SQLiteDatabase.cpp	2022-01-19 19:48:23 UTC (rev 288223)
@@ -225,6 +225,7 @@
 {
     m_useWAL = true;
     {
+        SQLiteTransactionInProgressAutoCounter transactionCounter;
         auto walStatement = prepareStatement("PRAGMA journal_mode=WAL;"_s);
         if (walStatement && walStatement->step() == SQLITE_ROW) {
 #ifndef NDEBUG
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to