Title: [288232] trunk/Source/WebKit
- Revision
- 288232
- Author
- [email protected]
- Date
- 2022-01-19 12:38:21 -0800 (Wed, 19 Jan 2022)
Log Message
WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()
https://bugs.webkit.org/show_bug.cgi?id=234975
<rdar://problem/87265153>
Reviewed by Darin Adler.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::publishProgress):
Let's not send the IPC if we failed to create the handle since the recipient code early returns when the handle is
invalid.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (288231 => 288232)
--- trunk/Source/WebKit/ChangeLog 2022-01-19 20:26:04 UTC (rev 288231)
+++ trunk/Source/WebKit/ChangeLog 2022-01-19 20:38:21 UTC (rev 288232)
@@ -1,3 +1,16 @@
+2022-01-19 Chris Dumez <[email protected]>
+
+ WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()
+ https://bugs.webkit.org/show_bug.cgi?id=234975
+ <rdar://problem/87265153>
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/Downloads/DownloadProxy.cpp:
+ (WebKit::DownloadProxy::publishProgress):
+ Let's not send the IPC if we failed to create the handle since the recipient code early returns when the handle is
+ invalid.
+
2022-01-19 Alex Christensen <[email protected]>
Allow experimental feature names to be hidden in WebKitAdditions
Modified: trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp (288231 => 288232)
--- trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp 2022-01-19 20:26:04 UTC (rev 288231)
+++ trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp 2022-01-19 20:38:21 UTC (rev 288232)
@@ -106,13 +106,12 @@
if (!m_dataStore)
return;
- SandboxExtension::Handle handle;
- if (auto createdHandle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite))
- handle = WTFMove(*createdHandle);
- else
- ASSERT_NOT_REACHED();
+ auto handle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite);
+ ASSERT(handle);
+ if (!handle)
+ return;
- m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, handle), 0);
+ m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, *handle), 0);
}
#endif // PLATFORM(COCOA)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
