Title: [288237] trunk/Source/WebKit
- Revision
- 288237
- Author
- [email protected]
- Date
- 2022-01-19 13:24:47 -0800 (Wed, 19 Jan 2022)
Log Message
WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
https://bugs.webkit.org/show_bug.cgi?id=234991
<rdar://problem/87275093>
Reviewed by Darin Adler.
Drop unnecessary default: case in the switch statement since it handles all enum values already.
* UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
(WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (288236 => 288237)
--- trunk/Source/WebKit/ChangeLog 2022-01-19 21:18:04 UTC (rev 288236)
+++ trunk/Source/WebKit/ChangeLog 2022-01-19 21:24:47 UTC (rev 288237)
@@ -1,5 +1,18 @@
2022-01-19 Chris Dumez <[email protected]>
+ WebKit::AuthenticatorPresenterCoordinator() constructor falls through ASSERT_NOT_REACHED()
+ https://bugs.webkit.org/show_bug.cgi?id=234991
+ <rdar://problem/87275093>
+
+ Reviewed by Darin Adler.
+
+ Drop unnecessary default: case in the switch statement since it handles all enum values already.
+
+ * UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:
+ (WebKit::AuthenticatorPresenterCoordinator::AuthenticatorPresenterCoordinator):
+
+2022-01-19 Chris Dumez <[email protected]>
+
WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()
https://bugs.webkit.org/show_bug.cgi?id=234975
<rdar://problem/87265153>
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm (288236 => 288237)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm 2022-01-19 21:18:04 UTC (rev 288236)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm 2022-01-19 21:24:47 UTC (rev 288237)
@@ -60,8 +60,6 @@
if ((transports.contains(AuthenticatorTransport::Usb) || transports.contains(AuthenticatorTransport::Nfc)) && !transports.contains(AuthenticatorTransport::Internal))
[m_context addLoginChoice:adoptNS([allocASCSecurityKeyPublicKeyCredentialLoginChoiceInstance() initAssertionPlaceholderChoice]).get()];
break;
- default:
- ASSERT_NOT_REACHED();
}
m_presenterDelegate = adoptNS([[WKASCAuthorizationPresenterDelegate alloc] initWithCoordinator:*this]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes