Title: [107156] trunk/Tools
Revision
107156
Author
[email protected]
Date
2012-02-08 16:50:45 -0800 (Wed, 08 Feb 2012)

Log Message

Remove Python 2.5 support from WebKit
https://bugs.webkit.org/show_bug.cgi?id=71593

Reviewed by Eric Seidel.

This is the last vestige of our Python 2.5 support.

* Scripts/webkitpy/tool/commands/queues_unittest.py:
(AbstractQueueTest.test_log_from_script_error_for_upload):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (107155 => 107156)


--- trunk/Tools/ChangeLog	2012-02-09 00:46:10 UTC (rev 107155)
+++ trunk/Tools/ChangeLog	2012-02-09 00:50:45 UTC (rev 107156)
@@ -1,5 +1,17 @@
 2012-02-08  Adam Barth  <[email protected]>
 
+        Remove Python 2.5 support from WebKit
+        https://bugs.webkit.org/show_bug.cgi?id=71593
+
+        Reviewed by Eric Seidel.
+
+        This is the last vestige of our Python 2.5 support.
+
+        * Scripts/webkitpy/tool/commands/queues_unittest.py:
+        (AbstractQueueTest.test_log_from_script_error_for_upload):
+
+2012-02-08  Adam Barth  <[email protected]>
+
         version_check.py should inform users that we don't support Python 2.5 anymore
         https://bugs.webkit.org/show_bug.cgi?id=78179
 

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py (107155 => 107156)


--- trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2012-02-09 00:46:10 UTC (rev 107155)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py	2012-02-09 00:50:45 UTC (rev 107156)
@@ -118,12 +118,6 @@
 
     def test_log_from_script_error_for_upload(self):
         self._assert_log_message(ScriptError("test"), "test")
-        # In python 2.5 unicode(Exception) is busted. See:
-        # http://bugs.python.org/issue2517
-        # With no good workaround, we just ignore these tests.
-        if not hasattr(Exception, "__unicode__"):
-            return
-
         unicode_tor = u"WebKit \u2661 Tor Arne Vestb\u00F8!"
         utf8_tor = unicode_tor.encode("utf-8")
         self._assert_log_message(ScriptError(unicode_tor), utf8_tor)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to