Title: [288514] branches/safari-613-branch/Source/WebKit
- Revision
- 288514
- Author
- [email protected]
- Date
- 2022-01-24 17:55:50 -0800 (Mon, 24 Jan 2022)
Log Message
Cherry-pick r288232. rdar://problem/87265153
WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()
https://bugs.webkit.org/show_bug.cgi?id=234975
<rdar://problem/87265153>
Reviewed by Darin Adler.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::publishProgress):
Let's not send the IPC if we failed to create the handle since the recipient code early returns when the handle is
invalid.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-613-branch/Source/WebKit/ChangeLog (288513 => 288514)
--- branches/safari-613-branch/Source/WebKit/ChangeLog 2022-01-25 01:55:47 UTC (rev 288513)
+++ branches/safari-613-branch/Source/WebKit/ChangeLog 2022-01-25 01:55:50 UTC (rev 288514)
@@ -1,5 +1,36 @@
2022-01-24 Alan Coon <[email protected]>
+ Cherry-pick r288232. rdar://problem/87265153
+
+ WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()
+ https://bugs.webkit.org/show_bug.cgi?id=234975
+ <rdar://problem/87265153>
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/Downloads/DownloadProxy.cpp:
+ (WebKit::DownloadProxy::publishProgress):
+ Let's not send the IPC if we failed to create the handle since the recipient code early returns when the handle is
+ invalid.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-01-19 Chris Dumez <[email protected]>
+
+ WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()
+ https://bugs.webkit.org/show_bug.cgi?id=234975
+ <rdar://problem/87265153>
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/Downloads/DownloadProxy.cpp:
+ (WebKit::DownloadProxy::publishProgress):
+ Let's not send the IPC if we failed to create the handle since the recipient code early returns when the handle is
+ invalid.
+
+2022-01-24 Alan Coon <[email protected]>
+
Cherry-pick r288180. rdar://problem/84440841
Loupe sometimes flips to the bottom of the page when dragging the end of a selection to the top of a page with selection flipping.
Modified: branches/safari-613-branch/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp (288513 => 288514)
--- branches/safari-613-branch/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp 2022-01-25 01:55:47 UTC (rev 288513)
+++ branches/safari-613-branch/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp 2022-01-25 01:55:50 UTC (rev 288514)
@@ -106,13 +106,12 @@
if (!m_dataStore)
return;
- SandboxExtension::Handle handle;
- if (auto createdHandle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite))
- handle = WTFMove(*createdHandle);
- else
- ASSERT_NOT_REACHED();
+ auto handle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite);
+ ASSERT(handle);
+ if (!handle)
+ return;
- m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, handle), 0);
+ m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, *handle), 0);
}
#endif // PLATFORM(COCOA)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
