Title: [288531] branches/safari-613-branch/Source/WebCore
- Revision
- 288531
- Author
- [email protected]
- Date
- 2022-01-24 17:57:02 -0800 (Mon, 24 Jan 2022)
Log Message
Cherry-pick r288441. rdar://problem/87707090
AVAudioSessionCaptureDeviceManager is not always computing the right default input device
https://bugs.webkit.org/show_bug.cgi?id=235362
<rdar://87707090>
Addressing post commit comments.
Reviewed by Eric Carlson and Geoff Garen.
* platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
Fixed the release logging.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-613-branch/Source/WebCore/ChangeLog (288530 => 288531)
--- branches/safari-613-branch/Source/WebCore/ChangeLog 2022-01-25 01:56:58 UTC (rev 288530)
+++ branches/safari-613-branch/Source/WebCore/ChangeLog 2022-01-25 01:57:02 UTC (rev 288531)
@@ -1,5 +1,36 @@
2022-01-24 Alan Coon <[email protected]>
+ Cherry-pick r288441. rdar://problem/87707090
+
+ AVAudioSessionCaptureDeviceManager is not always computing the right default input device
+ https://bugs.webkit.org/show_bug.cgi?id=235362
+ <rdar://87707090>
+
+ Addressing post commit comments.
+
+ Reviewed by Eric Carlson and Geoff Garen.
+
+ * platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
+ Fixed the release logging.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2022-01-24 Youenn Fablet <[email protected]>
+
+ AVAudioSessionCaptureDeviceManager is not always computing the right default input device
+ https://bugs.webkit.org/show_bug.cgi?id=235362
+ <rdar://87707090>
+
+ Addressing post commit comments.
+
+ Reviewed by Eric Carlson and Geoff Garen.
+
+ * platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
+ Fixed the release logging.
+
+2022-01-24 Alan Coon <[email protected]>
+
Cherry-pick r288429. rdar://problem/86612099
Position:fixed layers shouldn't allocate a backing buffer if all children are offscreen.
Modified: branches/safari-613-branch/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm (288530 => 288531)
--- branches/safari-613-branch/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm 2022-01-25 01:56:58 UTC (rev 288530)
+++ branches/safari-613-branch/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm 2022-01-25 01:57:02 UTC (rev 288531)
@@ -237,12 +237,12 @@
Vector<AVAudioSessionCaptureDevice> AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices() const
{
auto *defaultInput = [m_audioSession currentRoute].inputs.firstObject;
- if (!defaultInput)
+ if (!defaultInput) {
+ RELEASE_LOG_INFO(WebRTC, "AVAudioSessionCaptureDeviceManager using previous default input");
defaultInput = m_lastDefaultMicrophone.get();
- else {
- RELEASE_LOG_INFO(WebRTC, "AVAudioSessionCaptureDeviceManager using previous default input");
+ } else
m_lastDefaultMicrophone = defaultInput;
- }
+
auto availableInputs = [m_audioSession availableInputs];
Vector<AVAudioSessionCaptureDevice> newAudioDevices;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
