Title: [288553] trunk/Source/WebCore
- Revision
- 288553
- Author
- [email protected]
- Date
- 2022-01-25 08:47:57 -0800 (Tue, 25 Jan 2022)
Log Message
Missing EnabledBySetting=WebXREnabled where Conditional=WEBXR exists
https://bugs.webkit.org/show_bug.cgi?id=235527
Reviewed by Darin Adler.
Manually tested.
* Modules/webxr/XRFrameRequestCallback.idl:
* html/canvas/WebGLContextAttributes.idl:
* html/canvas/WebGLRenderingContextBase.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288552 => 288553)
--- trunk/Source/WebCore/ChangeLog 2022-01-25 16:46:19 UTC (rev 288552)
+++ trunk/Source/WebCore/ChangeLog 2022-01-25 16:47:57 UTC (rev 288553)
@@ -1,3 +1,16 @@
+2022-01-25 Sam Sneddon <[email protected]>
+
+ Missing EnabledBySetting=WebXREnabled where Conditional=WEBXR exists
+ https://bugs.webkit.org/show_bug.cgi?id=235527
+
+ Reviewed by Darin Adler.
+
+ Manually tested.
+
+ * Modules/webxr/XRFrameRequestCallback.idl:
+ * html/canvas/WebGLContextAttributes.idl:
+ * html/canvas/WebGLRenderingContextBase.idl:
+
2022-01-25 Lauro Moura <[email protected]>
Non-unified buildfix after r288546/246378@main
Modified: trunk/Source/WebCore/Modules/webxr/XRFrameRequestCallback.idl (288552 => 288553)
--- trunk/Source/WebCore/Modules/webxr/XRFrameRequestCallback.idl 2022-01-25 16:46:19 UTC (rev 288552)
+++ trunk/Source/WebCore/Modules/webxr/XRFrameRequestCallback.idl 2022-01-25 16:47:57 UTC (rev 288553)
@@ -27,5 +27,6 @@
// https://immersive-web.github.io/webxr/#callbackdef-xrframerequestcallback
[
- Conditional=WEBXR
+ Conditional=WEBXR,
+ EnabledBySetting=WebXREnabled
] callback XRFrameRequestCallback = undefined (DOMHighResTimeStamp time, WebXRFrame frame);
Modified: trunk/Source/WebCore/html/canvas/WebGLContextAttributes.idl (288552 => 288553)
--- trunk/Source/WebCore/html/canvas/WebGLContextAttributes.idl 2022-01-25 16:46:19 UTC (rev 288552)
+++ trunk/Source/WebCore/html/canvas/WebGLContextAttributes.idl 2022-01-25 16:47:57 UTC (rev 288553)
@@ -45,5 +45,5 @@
GLboolean preserveDrawingBuffer = false;
WebGLPowerPreference powerPreference = "default";
GLboolean failIfMajorPerformanceCaveat = false;
- [Conditional=WEBXR] boolean xrCompatible = false;
+ [Conditional=WEBXR, EnabledBySetting=WebXREnabled] boolean xrCompatible = false;
};
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl (288552 => 288553)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl 2022-01-25 16:46:19 UTC (rev 288552)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.idl 2022-01-25 16:47:57 UTC (rev 288553)
@@ -604,7 +604,7 @@
undefined lineWidth(GLfloat width);
undefined linkProgram(WebGLProgram program);
- [NewObject, Conditional=WEBXR] Promise<undefined> makeXRCompatible();
+ [NewObject, Conditional=WEBXR, EnabledBySetting=WebXREnabled] Promise<undefined> makeXRCompatible();
undefined pixelStorei(GLenum pname, GLint param);
undefined polygonOffset(GLfloat factor, GLfloat units);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
