Title: [288585] trunk
Revision
288585
Author
[email protected]
Date
2022-01-25 14:10:54 -0800 (Tue, 25 Jan 2022)

Log Message

Add another test for locale-specific shaping
https://bugs.webkit.org/show_bug.cgi?id=235558

Reviewed by Darin Adler.

Thanks so much to Just van Rossum for contributing the test font!!!

.:

* metadata/contributors.json:

LayoutTests:

This test makes sure the LOCL lookup works correctly, even without font-feature-settings.

* fast/text/locale-shaping-2-expected.html: Added.
* fast/text/locale-shaping-2.html: Added.
* fast/text/locale-shaping-3-expected.html: Added.
* fast/text/locale-shaping-3.html: Added.
* fast/text/resources/langlocatest_cjk/LICENSE: Added.
* fast/text/resources/langlocatest_cjk/langlocatest_cjk.ttf: Added.
* platform/gtk/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:
* platform/wpe/TestExpectations:

Modified Paths

Added Paths

Diff

Modified: trunk/ChangeLog (288584 => 288585)


--- trunk/ChangeLog	2022-01-25 22:09:07 UTC (rev 288584)
+++ trunk/ChangeLog	2022-01-25 22:10:54 UTC (rev 288585)
@@ -1,3 +1,14 @@
+2022-01-25  Myles C. Maxfield  <[email protected]>
+
+        Add another test for locale-specific shaping
+        https://bugs.webkit.org/show_bug.cgi?id=235558
+
+        Reviewed by Darin Adler.
+
+        Thanks so much to Just van Rossum for contributing the test font!!!
+
+        * metadata/contributors.json:
+
 2022-01-20  Elliott Williams  <[email protected]>
 
         [XCBuild] Build via the workspace with USE_WORKSPACE=YES

Modified: trunk/LayoutTests/ChangeLog (288584 => 288585)


--- trunk/LayoutTests/ChangeLog	2022-01-25 22:09:07 UTC (rev 288584)
+++ trunk/LayoutTests/ChangeLog	2022-01-25 22:10:54 UTC (rev 288585)
@@ -1,3 +1,26 @@
+2022-01-25  Myles C. Maxfield  <[email protected]>
+
+        Add another test for locale-specific shaping
+        https://bugs.webkit.org/show_bug.cgi?id=235558
+
+        Reviewed by Darin Adler.
+
+        Thanks so much to Just van Rossum for contributing the test font!!!
+
+        This test makes sure the LOCL lookup works correctly, even without font-feature-settings.
+
+        * fast/text/locale-shaping-2-expected.html: Added.
+        * fast/text/locale-shaping-2.html: Added.
+        * fast/text/locale-shaping-3-expected.html: Added.
+        * fast/text/locale-shaping-3.html: Added.
+        * fast/text/resources/langlocatest_cjk/LICENSE: Added.
+        * fast/text/resources/langlocatest_cjk/langlocatest_cjk.ttf: Added.
+        * platform/gtk/TestExpectations:
+        * platform/ios/TestExpectations:
+        * platform/mac/TestExpectations:
+        * platform/win/TestExpectations:
+        * platform/wpe/TestExpectations:
+
 2022-01-25  Ryan Haddad  <[email protected]>
 
         [macOS arm64] fast/scrolling/mac/j-shaped-scroll-rubberband.html is consistently failing

Added: trunk/LayoutTests/fast/text/locale-shaping-2-expected.html (0 => 288585)


--- trunk/LayoutTests/fast/text/locale-shaping-2-expected.html	                        (rev 0)
+++ trunk/LayoutTests/fast/text/locale-shaping-2-expected.html	2022-01-25 22:10:54 UTC (rev 288585)
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<style>
+@font-face {
+    font-family: "CJKLoclTest";
+    src: url("resources/langlocatest_cjk/langlocatest_cjk.ttf") format('truetype');
+}
+
+.locl-test {
+    display: inline-block;
+    font-family: "CJKLoclTest";
+    font-size: 3rem;
+}
+
+.locl-on {
+    font-family: "CJKLoclTest";
+    font-feature-settings: "locl" 1;
+}
+
+.locl-off {
+    font-family: "CJKLoclTest";
+    font-feature-settings: "locl" 0;
+}
+</style>
+</head>
+<body>
+<div>This test makes sure that shaping is locale-specific. The test passes if the big text below doesn't all say ZHS.</div>
+<div class="locl-test">
+<div lang="zh-Hans">雕</div>
+<div lang="zh-Hant">雕</div>
+<div lang="zh-HK">雕</div>
+<div lang="ja-JP">雕</div>
+<div lang="ko-KR">雕</div>
+</div>
+</body>
+</html>

Added: trunk/LayoutTests/fast/text/locale-shaping-2.html (0 => 288585)


--- trunk/LayoutTests/fast/text/locale-shaping-2.html	                        (rev 0)
+++ trunk/LayoutTests/fast/text/locale-shaping-2.html	2022-01-25 22:10:54 UTC (rev 288585)
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<style>
+@font-face {
+    font-family: "CJKLoclTest";
+    src: url("resources/langlocatest_cjk/langlocatest_cjk.ttf") format('truetype');
+}
+
+.locl-test {
+    display: inline-block;
+    font-family: "CJKLoclTest";
+    font-size: 3rem;
+}
+
+.locl-on {
+    font-family: "CJKLoclTest";
+    font-feature-settings: "locl" 1;
+}
+
+.locl-off {
+    font-family: "CJKLoclTest";
+    font-feature-settings: "locl" 0;
+}
+</style>
+</head>
+<body>
+<div>This test makes sure that shaping is locale-specific. The test passes if the big text below doesn't all say ZHS.</div>
+<div class="locl-test locl-on">
+<div lang="zh-Hans">雕</div>
+<div lang="zh-Hant">雕</div>
+<div lang="zh-HK">雕</div>
+<div lang="ja-JP">雕</div>
+<div lang="ko-KR">雕</div>
+</div>
+</body>
+</html>

Added: trunk/LayoutTests/fast/text/locale-shaping-3-expected.html (0 => 288585)


--- trunk/LayoutTests/fast/text/locale-shaping-3-expected.html	                        (rev 0)
+++ trunk/LayoutTests/fast/text/locale-shaping-3-expected.html	2022-01-25 22:10:54 UTC (rev 288585)
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<style>
+@font-face {
+    font-family: "CJKLoclTest";
+    src: url("resources/langlocatest_cjk/langlocatest_cjk.ttf") format('truetype');
+}
+
+.locl-test {
+    display: inline-block;
+    font-family: "CJKLoclTest";
+    font-size: 3rem;
+}
+
+.locl-on {
+    font-family: "CJKLoclTest";
+    font-feature-settings: "locl" 1;
+}
+
+.locl-off {
+    font-family: "CJKLoclTest";
+    font-feature-settings: "locl" 0;
+}
+</style>
+</head>
+<body>
+<div>This test makes sure that shaping is locale-specific. The test passes if the big text below doesn't all say ZHS.</div>
+<div class="locl-test">
+<div lang="zh-Hans">雕</div>
+<div lang="zh-Hant">雕</div>
+<div lang="zh-HK">雕</div>
+<div lang="ja-JP">雕</div>
+<div lang="ko-KR">雕</div>
+</div>
+</body>
+</html>

Added: trunk/LayoutTests/fast/text/locale-shaping-3.html (0 => 288585)


--- trunk/LayoutTests/fast/text/locale-shaping-3.html	                        (rev 0)
+++ trunk/LayoutTests/fast/text/locale-shaping-3.html	2022-01-25 22:10:54 UTC (rev 288585)
@@ -0,0 +1,38 @@
+<!DOCTYPE html>
+<html>
+<head>
+<meta charset="utf-8">
+<style>
+@font-face {
+    font-family: "CJKLoclTest";
+    src: url("resources/langlocatest_cjk/langlocatest_cjk.ttf") format('truetype');
+}
+
+.locl-test {
+    display: inline-block;
+    font-family: "CJKLoclTest";
+    font-size: 3rem;
+}
+
+.locl-on {
+    font-family: "CJKLoclTest";
+    font-feature-settings: "locl" 1;
+}
+
+.locl-off {
+    font-family: "CJKLoclTest";
+    font-feature-settings: "locl" 0;
+}
+</style>
+</head>
+<body>
+<div>This test makes sure that shaping is locale-specific. The test passes if the big text below doesn't all say ZHS.</div>
+<div class="locl-test locl-off">
+<div lang="zh-Hans">雕</div>
+<div lang="zh-Hant">雕</div>
+<div lang="zh-HK">雕</div>
+<div lang="ja-JP">雕</div>
+<div lang="ko-KR">雕</div>
+</div>
+</body>
+</html>

Added: trunk/LayoutTests/fast/text/resources/langlocatest_cjk/LICENSE (0 => 288585)


--- trunk/LayoutTests/fast/text/resources/langlocatest_cjk/LICENSE	                        (rev 0)
+++ trunk/LayoutTests/fast/text/resources/langlocatest_cjk/LICENSE	2022-01-25 22:10:54 UTC (rev 288585)
@@ -0,0 +1,3 @@
+Glyphs derived from IBM Plex, which are Copyright 2019 IBM Corp. All rights reserved. Licensed under the SIL Open Font License, Version 1.1.
+
+Very kindly provided by Just van Rossum <[email protected]>.

Added: trunk/LayoutTests/fast/text/resources/langlocatest_cjk/langlocatest_cjk.ttf (0 => 288585)


--- trunk/LayoutTests/fast/text/resources/langlocatest_cjk/langlocatest_cjk.ttf	                        (rev 0)
+++ trunk/LayoutTests/fast/text/resources/langlocatest_cjk/langlocatest_cjk.ttf	2022-01-25 22:10:54 UTC (rev 288585)
@@ -0,0 +1,11 @@
+����������������GDEF��)������
+������GPOSDvLu����
+0������ GSUB\xA9\xB4\x9A\xA1����
+P����\x9AOS/2\xEA\xBB\xEF\xEE����\x88������`cmap��\x97(������������4gasp����������
+������glyf\xEEn#D����D����\xF4head"\xBD\x85\xA2����������6hheal\xB5����D������$hmtx'\x9D4����\xE8������loca\xA7\xB4����4������maxp����B����h������ name\x8D! ����8����hpost\xA1\xB3\xDA����	\xA0������fvhea@\xCD����\xEC������$vmtx\xA0��������������������\xC5\xCAM\xC5_<\xF5��\xE8��������\xDD��������\xDE\xB2\x8B��\xFF\xF4\x88\xC6��������������������������\xC6\xFE\xCE����\xCA����\x88������������������������������������������A����������������������������������������������\xD2\x90������\x8AX������K\x8AX����^��22������������������������������������������������������BLCK��@\x96Ֆ\xD5p\xFF\x88����\xE8��������������\xFE\xCC������ ��D��OL��$\xCA��$C��$B��\xBE��]�������������������������������� ��������������\x96\xD5\xFF\xFF����\x96\xD5\xFF\xFFi,��������������������_��\x99��\xCEz��������$\xFF\xF4\xC6��	����=����%!5!!!!3#!#3!2654&''&&546327&&#"
 #"&' \xFE^\x94\xFE'~\xFEm\xFC6TT\xFE\x9FTTa\xD2p\x80^e9BANB<T?'rNf\x81f_9E<OK<[%>*yJ$LJ\xFD\xDCL\xBA\xFE\xCC4\xFDF<\xFE\xB8r`N^+418:.(.7;b]PZ+71<H3149A������$����m\xBA��	����!����%!5!5
 !!#3!3!!#3!3 \xFE\x93\xFE\x82\xD9\xFEl\xD8\xFE\x9FTTaTo\xFE\x9FTTaTJJL$JL\xFD\xDCJ<\xFE\xC4\xBA\xFE\xCC4\xFDF<\xFE\xC4\xBA\xFE\xCC4\xFDF����$����-\xBA��	��������%!5!5!!#3!3###5! \xFE\x93\xFE\x82\xD9\xFEl\xD8\xFE\x9FTTaT\x83\xDET\xDEJJL$JL\xFD\xDCJ<\xFE\xC4\xBA\xFE\xCC4\xFDFp\xFD\x90pJ������\xFF\xF4\xE5\xBA��������/����3#"&'3265#37!#7733##'#353b\xF0<659
+LcQXp\xC2\xF4k\xF4UFF[\xF1X'aRT\xFFaRT\xBAJ\xFETBC9-GXiX\xFDF\xBA\xFDF\xCE\xCE\xFDWW\xFD\xEB\xBA\xFEV\x9B\x9B\xAA\xFDF\xAA\x9B\x9B������]\xFF\xF4\x88\xC6������(��6��@����!3##55#3572654&#"7"&554632%336654&#!3532#\xFCh\xFE\xEAg\xD3dTTcȆ\xA2\xA2\x86\x86\xA2\xA2\x86ZttZZtt\xB9\xA3\x97_\xA0DHh[\xFE\xEAT\xC21881\x8F+\xFAyy\xFA\xFDF\xE9n\x{77ABEFEBA}\xAF\xAF\xBAK}gtg}}gtg}\xED\xFE\xD44dL_g\xFDFt\xFC40404����������\x8A����	������������	��������	����0����	����>>����	����(|����	����\xA4����	����(\xBE����	����\xA2\xE6����	��+ \x88����	����4\xA8����	����\xDC��G��l��y��p��h��s�� ��d��e��r��i��v��e��d�� ��f��r��o��m�� ��I��B��M�� ��P��l��e��x��,�� ��w��h��i��c��h�� ��a��r��e�� ��C��o��p��y��r��i��g��h��t�� ��2��0��1��9�� ��I��B��M�� ��C��o��r��p��.�� ��A��l��l�� ��r��i��g��h��t��s�� ��r��e��s��e��r��v��e��d��.�� ��L��i��c��e��n��s��e��d�� ��u��n��d�
 �e��r�� ��t��h��e�� ��S��I��L�� ��O��p��e��n�� ��F��o��n��t�� ��L��i��c��e��n��s��e��,�� ��V��e��r��s��i��o��n�� ��1��.��1��.��L��a��n��g��L��o��c��l��T��e��s��t��R��e��g��u��l��a��r��1��.��0��0��4��;��B��L��C��K��;��L��a��n��g��L��o��c
 ��l��T��e��s��t�� ��R��e��g��u��l��a��r��L��a��n��g��L��o��c��l��T��e��s��t�� ��R��e��g��u��l��a��r��V��e��r��s��i��o��n�� ��1��.��0��0��4��L��a��n��g��L��o��c��l��T��e��s��t��-��R��e��g��u��l��a��r��I��B��M�� ��P��l��e��x!"�� ��i��s�� ��a�� ��t��r��a��d��e��m��a��r��k�� ��o��f�� ��I��B��M�� ��C��o��r��p��,�� ��r��e��g��i��s��t��e��r��e��d�� ��i��n�� ��m��a��n��y�� ��j��u��r��i��s��d��i��c��t��i��o��n��s�� ��w��o��r��l��d��w��i��d��e��.��T��h��i��s�� ��F��o��n��t�� ��S��o��f��t��w��a��r��e�� ��i��s�� ��l��i��c��e��n��s��e��d�� ��u��n��d��e��r�� ��t��h��e�� ��S��I��L�� ��O��p��e��n�� ��F��o��n��t�� ��L��i��c��e��n��s��e��,�� ��V��e��r��s��i��o��n�� ��1��.��1��.�� ��T��h��i��s�� ��l��i��c��e��n��s��e�� ��i��s�� ��a��v��a��i��l��a��b��l��e�� ��w��i��t��h�� ��a�� ��F��A��Q�� ��a��t��:�� ��h��t��t��p��:��/��/��s��c��r��i��p��t��s��.��s��i��l��.��o��r��g��/��O��F��L��h��t��t��p��:��/��/��s��c��r��i��p��t��s��.��s��i��l��.��o��r��g��/��O��F��L\x96\xD5����������������K��2�������������
 ���������������������������������uni96D5uni96D5.ZHHuni96D5.ZHTuni96D5.JANuni96D5.KOR��������\xFF\xFF����������������������������������������������������������
+������DFLT������������\xFF\xFF��������������������
+��\x82��\xC0��DFLT�� hang��*hani��*kana��*latn��t����������\xFF\xFF����������JAN ��"KOR ��*ZHH ��2ZHS ��:ZHT ��B����\xFF\xFF����������\xFF\xFF��������\xFF\xFF��������\xFF\xFF��������\xFF\xFF��������������locl�� locl��&locl��,locl��2locl��8��������������������������������������������������,��<��L��������������������H��������������������R��������������������Z��������������������d��������������������l������������������������������������������������������������������������������������������������������������������������������������������\xF4\xFE����\xE8��9��\xD8��������������������������������\xE8��\xA4��>��>��>��9��<����
\ No newline at end of file

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (288584 => 288585)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2022-01-25 22:09:07 UTC (rev 288584)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2022-01-25 22:10:54 UTC (rev 288585)
@@ -2047,3 +2047,7 @@
 #////////////////////////////////////////////////////////////////////////////////////////
 # UNSORTED Expectations. When in doubt, put it here.
 #////////////////////////////////////////////////////////////////////////////////////////
+
+# These tests require platform support.
+fast/text/locale-shaping-2.html [ ImageOnlyFailure ]
+fast/text/locale-shaping-3.html [ ImageOnlyFailure ]

Modified: trunk/LayoutTests/platform/ios/TestExpectations (288584 => 288585)


--- trunk/LayoutTests/platform/ios/TestExpectations	2022-01-25 22:09:07 UTC (rev 288584)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2022-01-25 22:10:54 UTC (rev 288585)
@@ -3435,3 +3435,8 @@
 imported/w3c/web-platform-tests/css/css-pseudo/selection-originating-decoration-color.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-pseudo/selection-originating-underline-order.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/css/css-pseudo/target-text-007.html [ Failure ]
+
+# These tests require platform support.
+# <rdar://problem/87944426>
+fast/text/locale-shaping-2.html [ Pass ImageOnlyFailure ]
+fast/text/locale-shaping-3.html [ Pass ImageOnlyFailure ]

Modified: trunk/LayoutTests/platform/mac/TestExpectations (288584 => 288585)


--- trunk/LayoutTests/platform/mac/TestExpectations	2022-01-25 22:09:07 UTC (rev 288584)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2022-01-25 22:10:54 UTC (rev 288585)
@@ -2433,3 +2433,8 @@
 
 # This test is specific to Core Text.
 fast/text/font-lookup-dot-prefix-case-sensitive.html [ Pass ]
+
+# These tests require platform support.
+# <rdar://problem/87944426>
+[ Catalina BigSur Monterey ] fast/text/locale-shaping-2.html [ Pass ImageOnlyFailure ]
+[ Catalina BigSur Monterey ] fast/text/locale-shaping-3.html [ Pass ImageOnlyFailure ]

Modified: trunk/LayoutTests/platform/win/TestExpectations (288584 => 288585)


--- trunk/LayoutTests/platform/win/TestExpectations	2022-01-25 22:09:07 UTC (rev 288584)
+++ trunk/LayoutTests/platform/win/TestExpectations	2022-01-25 22:10:54 UTC (rev 288585)
@@ -4800,3 +4800,7 @@
 
 # LinearSRGB color space is not supported on Windows.
 css3/filters/reference-filter-color-space.html [ Skip ]
+
+# These tests require platform support.
+fast/text/locale-shaping-2.html [ ImageOnlyFailure ]
+fast/text/locale-shaping-3.html [ ImageOnlyFailure ]

Modified: trunk/LayoutTests/platform/wpe/TestExpectations (288584 => 288585)


--- trunk/LayoutTests/platform/wpe/TestExpectations	2022-01-25 22:09:07 UTC (rev 288584)
+++ trunk/LayoutTests/platform/wpe/TestExpectations	2022-01-25 22:10:54 UTC (rev 288585)
@@ -1367,3 +1367,7 @@
 #////////////////////////////////////////////////////////////////////////////////////////
 # UNSORTED Expectations. When in doubt, put it here.
 #////////////////////////////////////////////////////////////////////////////////////////
+
+# These tests require platform support.
+fast/text/locale-shaping-2.html [ ImageOnlyFailure ]
+fast/text/locale-shaping-3.html [ ImageOnlyFailure ]

Modified: trunk/metadata/contributors.json (288584 => 288585)


--- trunk/metadata/contributors.json	2022-01-25 22:09:07 UTC (rev 288584)
+++ trunk/metadata/contributors.json	2022-01-25 22:10:54 UTC (rev 288585)
@@ -3768,6 +3768,13 @@
    },
    {
       "emails" : [
+         "[email protected]"
+      ],
+      "expertise" : "Text and Fonts",
+      "name" : "Just van Rossum"
+   },
+   {
+      "emails" : [
          "[email protected]"
       ],
       "expertise" : "WebGL, Canvas",
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to