Title: [288594] trunk/Source/WebCore
- Revision
- 288594
- Author
- [email protected]
- Date
- 2022-01-25 17:23:42 -0800 (Tue, 25 Jan 2022)
Log Message
[WebIDL] Remove the now-unused [CustomEnabled] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=235608
Patch by Alexey Shvayka <[email protected]> on 2022-01-25
Reviewed by Darin Adler.
It's unlikely we will ever need it, and it's limited to Window only,
and it generates a call to a free function rather than a method.
No new tests, no behavior change.
* bindings/scripts/CodeGeneratorJS.pm:
(NeedsRuntimeCheck):
(GenerateRuntimeEnableConditionalString):
* bindings/scripts/IDLAttributes.json:
* bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttributes):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288593 => 288594)
--- trunk/Source/WebCore/ChangeLog 2022-01-26 01:11:36 UTC (rev 288593)
+++ trunk/Source/WebCore/ChangeLog 2022-01-26 01:23:42 UTC (rev 288594)
@@ -1,5 +1,24 @@
2022-01-25 Alexey Shvayka <[email protected]>
+ [WebIDL] Remove the now-unused [CustomEnabled] extended attribute
+ https://bugs.webkit.org/show_bug.cgi?id=235608
+
+ Reviewed by Darin Adler.
+
+ It's unlikely we will ever need it, and it's limited to Window only,
+ and it generates a call to a free function rather than a method.
+
+ No new tests, no behavior change.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (NeedsRuntimeCheck):
+ (GenerateRuntimeEnableConditionalString):
+ * bindings/scripts/IDLAttributes.json:
+ * bindings/scripts/preprocess-idls.pl:
+ (GenerateConstructorAttributes):
+
+2022-01-25 Alexey Shvayka <[email protected]>
+
[WebIDL] Blob-related methods should use _relevant_ context instead of _current_
https://bugs.webkit.org/show_bug.cgi?id=235279
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (288593 => 288594)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2022-01-26 01:11:36 UTC (rev 288593)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2022-01-26 01:23:42 UTC (rev 288594)
@@ -1994,8 +1994,7 @@
|| $context->extendedAttributes->{EnabledBySetting}
|| $context->extendedAttributes->{EnabledByQuirk}
|| $context->extendedAttributes->{DisabledByQuirk}
- || $context->extendedAttributes->{SecureContext}
- || $context->extendedAttributes->{CustomEnabled};
+ || $context->extendedAttributes->{SecureContext};
}
sub NeedsRuntimeReadWriteCheck
@@ -4046,13 +4045,6 @@
}
}
- if ($context->extendedAttributes->{CustomEnabled}) {
- assert("CustomEnabled can only be used by interfaces only exposed to the Window") if $interface->extendedAttributes->{Exposed} && $interface->extendedAttributes->{Exposed} ne "Window";
-
- my $className = "JS" . $interface->type->name;
- push(@conjuncts, "${className}" . $codeGenerator->WK_ucfirst($context->name) . "IsEnabled()");
- }
-
if ($context->extendedAttributes->{EnabledByQuirk}) {
assert("Must specify value for EnabledByQuirk.") if $context->extendedAttributes->{DisabledByQuirk} eq "VALUE_IS_MISSING";
Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.json (288593 => 288594)
--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.json 2022-01-26 01:11:36 UTC (rev 288593)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.json 2022-01-26 01:23:42 UTC (rev 288594)
@@ -144,9 +144,6 @@
"CustomToJSObject": {
"contextsAllowed": ["interface"]
},
- "CustomEnabled": {
- "contextsAllowed": ["interface", "dictionary", "enum", "attribute", "operation", "constant", "iterable"]
- },
"DOMJIT": {
"contextsAllowed": ["interface", "attribute", "operation"],
"values": ["", "ReadDOM", "Getter"],
Modified: trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl (288593 => 288594)
--- trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl 2022-01-26 01:11:36 UTC (rev 288593)
+++ trunk/Source/WebCore/bindings/scripts/preprocess-idls.pl 2022-01-26 01:23:42 UTC (rev 288594)
@@ -480,7 +480,7 @@
next unless ($attributeName eq "Conditional" || $attributeName eq "EnabledAtRuntime" || $attributeName eq "EnabledForWorld"
|| $attributeName eq "EnabledBySetting" || $attributeName eq "SecureContext" || $attributeName eq "PrivateIdentifier"
|| $attributeName eq "PublicIdentifier" || $attributeName eq "DisabledByQuirk" || $attributeName eq "EnabledByQuirk"
- || $attributeName eq "EnabledForContext" || $attributeName eq "CustomEnabled") || $attributeName eq "LegacyFactoryFunctionEnabledBySetting";
+ || $attributeName eq "EnabledForContext") || $attributeName eq "LegacyFactoryFunctionEnabledBySetting";
my $extendedAttribute = $attributeName;
$extendedAttribute .= "=" . $extendedAttributes->{$attributeName} unless $extendedAttributes->{$attributeName} eq "VALUE_IS_MISSING";
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
