Title: [288643] trunk/Source/WebGPU
- Revision
- 288643
- Author
- [email protected]
- Date
- 2022-01-26 13:58:05 -0800 (Wed, 26 Jan 2022)
Log Message
[WebGPU] Make sure WGSLUnitTests can call into WGSL
https://bugs.webkit.org/show_bug.cgi?id=235630
Reviewed by Dean Jackson.
* WGSL/WGSL.cpp:
(WGSL::staticCheck): Apparently /usr/local/include/AssertMacros.h #defines "check"
(WGSL::check): Deleted.
* WGSL/WGSL.h:
* WGSLUnitTests/WGSLUnitTests.mm:
(-[WGSLUnitTests testExample]):
Modified Paths
Diff
Modified: trunk/Source/WebGPU/ChangeLog (288642 => 288643)
--- trunk/Source/WebGPU/ChangeLog 2022-01-26 20:51:09 UTC (rev 288642)
+++ trunk/Source/WebGPU/ChangeLog 2022-01-26 21:58:05 UTC (rev 288643)
@@ -1,3 +1,17 @@
+2022-01-26 Myles C. Maxfield <[email protected]>
+
+ [WebGPU] Make sure WGSLUnitTests can call into WGSL
+ https://bugs.webkit.org/show_bug.cgi?id=235630
+
+ Reviewed by Dean Jackson.
+
+ * WGSL/WGSL.cpp:
+ (WGSL::staticCheck): Apparently /usr/local/include/AssertMacros.h #defines "check"
+ (WGSL::check): Deleted.
+ * WGSL/WGSL.h:
+ * WGSLUnitTests/WGSLUnitTests.mm:
+ (-[WGSLUnitTests testExample]):
+
2022-01-25 Myles C. Maxfield <[email protected]>
[WebGPU] Fix WGSLUnitTests build
Modified: trunk/Source/WebGPU/WGSL/WGSL.cpp (288642 => 288643)
--- trunk/Source/WebGPU/WGSL/WGSL.cpp 2022-01-26 20:51:09 UTC (rev 288642)
+++ trunk/Source/WebGPU/WGSL/WGSL.cpp 2022-01-26 21:58:05 UTC (rev 288643)
@@ -30,9 +30,8 @@
namespace WGSL {
-std::variant<SuccessfulCheck, FailedCheck> check(const String&, const std::optional<SourceMap>&)
+std::variant<SuccessfulCheck, FailedCheck> staticCheck(const String&, const std::optional<SourceMap>&)
{
- ASSERT_NOT_REACHED();
return FailedCheck { { }, { } };
}
Modified: trunk/Source/WebGPU/WGSL/WGSL.h (288642 => 288643)
--- trunk/Source/WebGPU/WGSL/WGSL.h 2022-01-26 20:51:09 UTC (rev 288642)
+++ trunk/Source/WebGPU/WGSL/WGSL.h 2022-01-26 21:58:05 UTC (rev 288643)
@@ -72,7 +72,7 @@
// https://sourcemaps.info/spec.html
};
-std::variant<SuccessfulCheck, FailedCheck> check(const String& wgsl, const std::optional<SourceMap>&);
+std::variant<SuccessfulCheck, FailedCheck> staticCheck(const String& wgsl, const std::optional<SourceMap>&);
//
// Step 2
Modified: trunk/Source/WebGPU/WGSLUnitTests/WGSLUnitTests.mm (288642 => 288643)
--- trunk/Source/WebGPU/WGSLUnitTests/WGSLUnitTests.mm 2022-01-26 20:51:09 UTC (rev 288642)
+++ trunk/Source/WebGPU/WGSLUnitTests/WGSLUnitTests.mm 2022-01-26 21:58:05 UTC (rev 288643)
@@ -23,6 +23,9 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#import "config.h"
+#import "WGSL.h"
+
#import <XCTest/XCTest.h>
#import <vector>
#import <wtf/DataLog.h>
@@ -41,6 +44,7 @@
y.append(2);
y.append(3);
XCTAssertEqual(x, y);
+ WGSL::staticCheck("", std::nullopt);
}
@end
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
