Title: [288657] trunk/Tools
- Revision
- 288657
- Author
- [email protected]
- Date
- 2022-01-26 17:02:34 -0800 (Wed, 26 Jan 2022)
Log Message
[EWS] Ignore hooks from closed PRs
https://bugs.webkit.org/show_bug.cgi?id=235666
<rdar://problem/88091611>
Reviewed by Aakash Jain.
* Tools/CISupport/ews-build/events.py:
(GitHubEventHandlerNoEdits):
(GitHubEventHandlerNoEdits.handle_pull_request): Ignore hooks coming from closed pull requests.
Canonical link: https://commits.webkit.org/246465@main
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/events.py (288656 => 288657)
--- trunk/Tools/CISupport/ews-build/events.py 2022-01-27 00:57:37 UTC (rev 288656)
+++ trunk/Tools/CISupport/ews-build/events.py 2022-01-27 01:02:34 UTC (rev 288657)
@@ -313,6 +313,7 @@
class GitHubEventHandlerNoEdits(GitHubEventHandler):
ACTIONS_TO_TRIGGER_EWS = ('opened', 'synchronize')
+ OPEN_STATES = ('open',)
def _get_commit_msg(self, repo, sha):
return ''
@@ -320,7 +321,11 @@
def handle_pull_request(self, payload, event):
pr_number = payload['number']
action = ""
+ state = payload.get('state')
if action not in self.ACTIONS_TO_TRIGGER_EWS:
log.msg('Action {} on PR #{} does not indicate code has been changed'.format(action, pr_number))
return ([], 'git')
+ if state not in self.OPEN_STATES:
+ log.msg("PR #{} is '{}', which triggers nothing".format(pr_number, state))
+ return ([], 'git')
return super(GitHubEventHandlerNoEdits, self).handle_pull_request(payload, event)
Modified: trunk/Tools/ChangeLog (288656 => 288657)
--- trunk/Tools/ChangeLog 2022-01-27 00:57:37 UTC (rev 288656)
+++ trunk/Tools/ChangeLog 2022-01-27 01:02:34 UTC (rev 288657)
@@ -1,3 +1,15 @@
+2022-01-26 Jonathan Bedard <[email protected]>
+
+ [EWS] Ignore hooks from closed PRs
+ https://bugs.webkit.org/show_bug.cgi?id=235666
+ <rdar://problem/88091611>
+
+ Reviewed by Aakash Jain.
+
+ * CISupport/ews-build/events.py:
+ (GitHubEventHandlerNoEdits):
+ (GitHubEventHandlerNoEdits.handle_pull_request): Ignore hooks coming from closed pull requests.
+
2022-01-26 Don Olmstead <[email protected]>
Share TestRunner::installFakeHelvetica implementation
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
