[webkit-changes] [288689] trunk/Source

Thu, 27 Jan 2022 11:45:40 -0800

Title: [288689] trunk/Source
Revision
288689
Author
[email protected]
Date
2022-01-27 11:45:03 -0800 (Thu, 27 Jan 2022)

Log Message

Disable WebXR experimental feature by default
https://bugs.webkit.org/show_bug.cgi?id=235688

Patch by Ada Chan <[email protected]> on 2022-01-27
Reviewed by Tim Horton.

Source/WebKit:

Remove WebKit::defaultWebXREnabled() since it's no longer used.

* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultWebXREnabled): Deleted.
* Shared/WebPreferencesDefaultValues.h:

Source/WebKitLegacy/mac:

Remove WebKit::defaultWebXREnabled() since it's no longer used.

* WebView/WebPreferencesDefaultValues.h:
* WebView/WebPreferencesDefaultValues.mm:
(WebKit::defaultWebXREnabled): Deleted.

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (288688 => 288689)


--- trunk/Source/WTF/ChangeLog	2022-01-27 19:35:12 UTC (rev 288688)
+++ trunk/Source/WTF/ChangeLog	2022-01-27 19:45:03 UTC (rev 288689)
@@ -1,3 +1,12 @@
+2022-01-27  Ada Chan  <[email protected]>
+
+        Disable WebXR experimental feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=235688
+
+        Reviewed by Tim Horton.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
 2022-01-27  Alexander Mikhaylenko  <[email protected]>
 
         [GTK] Support accent colors

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (288688 => 288689)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-01-27 19:35:12 UTC (rev 288688)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-01-27 19:45:03 UTC (rev 288689)
@@ -1793,9 +1793,9 @@
   condition: ENABLE(WEBXR)
   defaultValue:
     WebKitLegacy:
-      default: WebKit::defaultWebXREnabled()
+      default: false
     WebKit:
-      default: WebKit::defaultWebXREnabled()
+      default: false
     WebCore:
       default: false
 
@@ -1806,9 +1806,9 @@
   condition: ENABLE(WEBXR)
   defaultValue:
     WebKitLegacy:
-      default: WebKit::defaultWebXREnabled()
+      default: false
     WebKit:
-      default: WebKit::defaultWebXREnabled()
+      default: false
     WebCore:
       default: false
 
@@ -1819,9 +1819,9 @@
   condition: ENABLE(WEBXR)
   defaultValue:
     WebKitLegacy:
-      default: WebKit::defaultWebXREnabled()
+      default: false
     WebKit:
-      default: WebKit::defaultWebXREnabled()
+      default: false
     WebCore:
       default: false
 
@@ -1832,9 +1832,9 @@
   condition: ENABLE(WEBXR_HANDS)
   defaultValue:
     WebKitLegacy:
-      default: WebKit::defaultWebXREnabled()
+      default: false
     WebKit:
-      default: WebKit::defaultWebXREnabled()
+      default: false
     WebCore:
       default: false

Modified: trunk/Source/WebKit/ChangeLog (288688 => 288689)


--- trunk/Source/WebKit/ChangeLog	2022-01-27 19:35:12 UTC (rev 288688)
+++ trunk/Source/WebKit/ChangeLog	2022-01-27 19:45:03 UTC (rev 288689)
@@ -1,3 +1,16 @@
+2022-01-27  Ada Chan  <[email protected]>
+
+        Disable WebXR experimental feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=235688
+
+        Reviewed by Tim Horton.
+
+        Remove WebKit::defaultWebXREnabled() since it's no longer used.
+
+        * Shared/WebPreferencesDefaultValues.cpp:
+        (WebKit::defaultWebXREnabled): Deleted.
+        * Shared/WebPreferencesDefaultValues.h:
+
 2022-01-27  Alexander Mikhaylenko  <[email protected]>
 
         [GTK] Support accent colors

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (288688 => 288689)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2022-01-27 19:35:12 UTC (rev 288688)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2022-01-27 19:45:03 UTC (rev 288689)
@@ -273,19 +273,6 @@
 }
 #endif
 
-#if ENABLE(WEBXR)
-
-bool defaultWebXREnabled()
-{
-#if HAVE(WEBXR_INTERNALS)
-    return true;
-#else
-    return false;
-#endif
-}
-
-#endif // ENABLE(WEBXR)
-
 #if ENABLE(WEBM_FORMAT_READER)
 
 bool defaultWebMFormatReaderEnabled()

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (288688 => 288689)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2022-01-27 19:35:12 UTC (rev 288688)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2022-01-27 19:45:03 UTC (rev 288689)
@@ -89,10 +89,6 @@
 bool defaultIncrementalPDFEnabled();
 #endif
 
-#if ENABLE(WEBXR)
-bool defaultWebXREnabled();
-#endif
-
 #if ENABLE(WEBM_FORMAT_READER)
 bool defaultWebMFormatReaderEnabled();
 #endif

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (288688 => 288689)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2022-01-27 19:35:12 UTC (rev 288688)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2022-01-27 19:45:03 UTC (rev 288689)
@@ -1,3 +1,16 @@
+2022-01-27  Ada Chan  <[email protected]>
+
+        Disable WebXR experimental feature by default
+        https://bugs.webkit.org/show_bug.cgi?id=235688
+
+        Reviewed by Tim Horton.
+
+        Remove WebKit::defaultWebXREnabled() since it's no longer used.
+
+        * WebView/WebPreferencesDefaultValues.h:
+        * WebView/WebPreferencesDefaultValues.mm:
+        (WebKit::defaultWebXREnabled): Deleted.
+
 2022-01-19  Alex Christensen  <[email protected]>
 
         Allow experimental feature names to be hidden in WebKitAdditions

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h (288688 => 288689)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h	2022-01-27 19:35:12 UTC (rev 288688)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h	2022-01-27 19:45:03 UTC (rev 288689)
@@ -43,10 +43,6 @@
 bool defaultIncrementalPDFEnabled();
 #endif
 
-#if ENABLE(WEBXR)
-bool defaultWebXREnabled();
-#endif
-
 #if PLATFORM(IOS_FAMILY)
 bool defaultAllowsInlineMediaPlayback();
 bool defaultAllowsInlineMediaPlaybackAfterFullscreen();

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm (288688 => 288689)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm	2022-01-27 19:35:12 UTC (rev 288688)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm	2022-01-27 19:45:03 UTC (rev 288689)
@@ -79,15 +79,6 @@
 
 #endif
 
-#if ENABLE(WEBXR)
-
-bool defaultWebXREnabled()
-{
-    return isFeatureFlagEnabled("WebXR", false);
-}
-
-#endif // ENABLE(WEBXR)
-
 #if PLATFORM(IOS_FAMILY)
 
 bool defaultAllowsInlineMediaPlayback()

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to