Title: [288693] trunk/Source/WebCore
- Revision
- 288693
- Author
- tyle...@apple.com
- Date
- 2022-01-27 12:07:27 -0800 (Thu, 27 Jan 2022)
Log Message
AX: Remove ancestor flag initialized ASSERT in AXIsolatedObject::initializeAttributeData
https://bugs.webkit.org/show_bug.cgi?id=235717
Reviewed by Andres Gonzalez.
This patch removes:
ASSERT(isRoot || object.ancestorFlagsAreInitialized());
>From AXIsolatedObject::initializeAttributeData.
This ASSERT is not very useful, since after
https://bugs.webkit.org/show_bug.cgi?id=235189 we do a single
traversal to compute all flags in the rare but legitimate cases
they aren't already initialized.
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288692 => 288693)
--- trunk/Source/WebCore/ChangeLog 2022-01-27 20:03:04 UTC (rev 288692)
+++ trunk/Source/WebCore/ChangeLog 2022-01-27 20:07:27 UTC (rev 288693)
@@ -1,3 +1,24 @@
+2022-01-27 Tyler Wilcock <tyle...@apple.com>
+
+ AX: Remove ancestor flag initialized ASSERT in AXIsolatedObject::initializeAttributeData
+ https://bugs.webkit.org/show_bug.cgi?id=235717
+
+ Reviewed by Andres Gonzalez.
+
+ This patch removes:
+
+ ASSERT(isRoot || object.ancestorFlagsAreInitialized());
+
+ From AXIsolatedObject::initializeAttributeData.
+
+ This ASSERT is not very useful, since after
+ https://bugs.webkit.org/show_bug.cgi?id=235189 we do a single
+ traversal to compute all flags in the rare but legitimate cases
+ they aren't already initialized.
+
+ * accessibility/isolatedtree/AXIsolatedObject.cpp:
+ (WebCore::AXIsolatedObject::initializeAttributeData):
+
2022-01-27 Elliott Williams <e...@apple.com>
Generated xcfilelists contain symlinks when building for macOS
Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp (288692 => 288693)
--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp 2022-01-27 20:03:04 UTC (rev 288692)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp 2022-01-27 20:07:27 UTC (rev 288693)
@@ -75,8 +75,6 @@
setProperty(AXPropertyName::ARIALandmarkRoleDescription, object.ariaLandmarkRoleDescription().isolatedCopy());
setProperty(AXPropertyName::AccessibilityDescription, object.accessibilityDescription().isolatedCopy());
- // For all objects besides the root, the ancestry flags should've been set by now.
- ASSERT(isRoot || object.ancestorFlagsAreInitialized());
if (object.ancestorFlagsAreInitialized())
setProperty(AXPropertyName::AncestorFlags, object.ancestorFlags());
else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
