Title: [288725] trunk/Source/WebCore
- Revision
- 288725
- Author
- carlo...@webkit.org
- Date
- 2022-01-27 22:59:31 -0800 (Thu, 27 Jan 2022)
Log Message
[GTK][a11y] Keep a reference to the parent wrapper with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=235699
Reviewed by Adrian Perez de Castro.
When wrappers are destroyed it doesn't necessarily happen in the tree order, we need to keep the parent alive to
emit the children-changed signal.
* accessibility/atspi/AccessibilityObjectAtspi.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (288724 => 288725)
--- trunk/Source/WebCore/ChangeLog 2022-01-28 06:58:48 UTC (rev 288724)
+++ trunk/Source/WebCore/ChangeLog 2022-01-28 06:59:31 UTC (rev 288725)
@@ -1,5 +1,17 @@
2022-01-27 Carlos Garcia Campos <cgar...@igalia.com>
+ [GTK][a11y] Keep a reference to the parent wrapper with ATSPI
+ https://bugs.webkit.org/show_bug.cgi?id=235699
+
+ Reviewed by Adrian Perez de Castro.
+
+ When wrappers are destroyed it doesn't necessarily happen in the tree order, we need to keep the parent alive to
+ emit the children-changed signal.
+
+ * accessibility/atspi/AccessibilityObjectAtspi.h:
+
+2022-01-27 Carlos Garcia Campos <cgar...@igalia.com>
+
[GTK][a11y] Return null reference for root parent reference if queried before being embedded
https://bugs.webkit.org/show_bug.cgi?id=235698
Modified: trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h (288724 => 288725)
--- trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h 2022-01-28 06:58:48 UTC (rev 288724)
+++ trunk/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h 2022-01-28 06:59:31 UTC (rev 288725)
@@ -242,7 +242,7 @@
AXCoreObject* m_coreObject { nullptr };
OptionSet<Interface> m_interfaces;
AccessibilityRootAtspi* m_root { nullptr };
- std::optional<AccessibilityObjectAtspi*> m_parent;
+ std::optional<RefPtr<AccessibilityObjectAtspi>> m_parent;
bool m_isRegistered { false };
String m_path;
String m_hyperlinkPath;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
