Title: [288747] trunk/Source/WebKit
- Revision
- 288747
- Author
- [email protected]
- Date
- 2022-01-28 10:33:25 -0800 (Fri, 28 Jan 2022)
Log Message
Symbols not always properly hidden when using WebKitAdditions to introduce new API
https://bugs.webkit.org/show_bug.cgi?id=235674
<rdar://87999257>
Reviewed by Wenson Hsieh.
Follow-up to r288658 to address post commit feedback from Alexey Proskuryakov.
* UIProcess/API/Cocoa/WKWebpagePreferences.h:
* mac/replace-webkit-additions-includes.py:
(main):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (288746 => 288747)
--- trunk/Source/WebKit/ChangeLog 2022-01-28 18:28:09 UTC (rev 288746)
+++ trunk/Source/WebKit/ChangeLog 2022-01-28 18:33:25 UTC (rev 288747)
@@ -1,3 +1,17 @@
+2022-01-28 Chris Dumez <[email protected]>
+
+ Symbols not always properly hidden when using WebKitAdditions to introduce new API
+ https://bugs.webkit.org/show_bug.cgi?id=235674
+ <rdar://87999257>
+
+ Reviewed by Wenson Hsieh.
+
+ Follow-up to r288658 to address post commit feedback from Alexey Proskuryakov.
+
+ * UIProcess/API/Cocoa/WKWebpagePreferences.h:
+ * mac/replace-webkit-additions-includes.py:
+ (main):
+
2022-01-28 Tyler Wilcock <[email protected]>
AX: Isolated tree object frames no longer encode content offsets, so hit testing should be updated accordingly
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h (288746 => 288747)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h 2022-01-28 18:28:09 UTC (rev 288746)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.h 2022-01-28 18:33:25 UTC (rev 288747)
@@ -71,7 +71,7 @@
*/
@property (nonatomic) BOOL allowsContentJavaScript WK_API_AVAILABLE(macos(11.0), ios(14.0));
-#if ENABLE(API_WEBKIT_ADDITIONS)
+#if 0 // API_WEBKIT_ADDITIONS_REPLACEMENT
#import <WebKitAdditions/WKWebpagePreferencesAdditions.h>
#endif
Modified: trunk/Source/WebKit/mac/replace-webkit-additions-includes.py (288746 => 288747)
--- trunk/Source/WebKit/mac/replace-webkit-additions-includes.py 2022-01-28 18:28:09 UTC (rev 288746)
+++ trunk/Source/WebKit/mac/replace-webkit-additions-includes.py 2022-01-28 18:33:25 UTC (rev 288747)
@@ -88,9 +88,7 @@
# We currently only support WebKitAdditions in Framework headers on macOS 13+ and iOS 16+.
should_do_replacement = is_supported_os()
- # API_WEBKIT_ADDITIONS is intentionally not defined anywhere so that we never try to build this code. It is only
- # meant to be used by this script to identify where to introduce replacement in API headers from WebKitAdditions.
- additions_import_pattern = re.compile(r"\#if ENABLE\(API_WEBKIT_ADDITIONS\)\n#import <WebKitAdditions/(.*)>\n#endif")
+ additions_import_pattern = re.compile(r"\#if 0 // API_WEBKIT_ADDITIONS_REPLACEMENT\n#import <WebKitAdditions/(.*)>\n#endif")
try:
with open(header_path, "r") as header:
header_contents = header.read()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
