Diff
Modified: trunk/LayoutTests/ChangeLog (288802 => 288803)
--- trunk/LayoutTests/ChangeLog 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/ChangeLog 2022-01-30 23:24:38 UTC (rev 288803)
@@ -1,3 +1,41 @@
+2022-01-30 Ryosuke Niwa <[email protected]>
+
+ Delete runtime preference for enabling input events
+ https://bugs.webkit.org/show_bug.cgi?id=235864
+
+ Reviewed by Wenson Hsieh.
+
+ Updated the tests.
+
+ * fast/events/before-input-delete-empty-list-target-ranges.html:
+ * fast/events/before-input-delete-text-target-ranges.html:
+ * fast/events/before-input-events-different-start-end-elements.html:
+ * fast/events/before-input-events-prevent-block-text-direction.html:
+ * fast/events/before-input-events-prevent-default-in-textfield.html:
+ * fast/events/before-input-events-prevent-default.html:
+ * fast/events/before-input-events-prevent-drag-and-drop.html:
+ * fast/events/before-input-events-prevent-insert-composition.html:
+ * fast/events/before-input-events-prevent-recomposition.html:
+ * fast/events/before-input-prevent-biu.html:
+ * fast/events/before-input-prevent-cut.html:
+ * fast/events/before-input-prevent-paste.html:
+ * fast/events/before-input-prevent-typing.html:
+ * fast/events/before-input-prevent-undo.html:
+ * fast/events/before-input-replace-text-target-ranges.html:
+ * fast/events/input-event-insert-link.html:
+ * fast/events/input-events-drag-and-drop.html:
+ * fast/events/input-events-fired-when-typing.html:
+ * fast/events/input-events-forecolor-data.html:
+ * fast/events/input-events-ime-composition.html:
+ * fast/events/input-events-ime-recomposition.html:
+ * fast/events/input-events-insert-by-drop.html:
+ * fast/events/input-events-paste-data.html:
+ * fast/events/input-events-paste-rich-datatransfer.html:
+ * fast/events/input-events-selection-forecolor-data.html:
+ * fast/events/input-events-spell-checking-datatransfer.html:
+ * fast/events/input-events-typing-data.html:
+ * fast/events/ios/input-events-fired-when-typing-in-contenteditable.html:
+
2022-01-30 Arcady Goldmints-Orlov <[email protected]>
[GLIB] Update Test expectations and baselines. Unreviewed test gardening.
Modified: trunk/LayoutTests/fast/events/before-input-delete-empty-list-target-ranges.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-delete-empty-list-target-ranges.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-delete-empty-list-target-ranges.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -11,9 +11,6 @@
editable.focus();
getSelection().setPosition(item);
- if (window.internals)
- internals.settings.setInputEventsEnabled(true);
-
if (window.testRunner)
testRunner.execCommand("deleteBackward");
Modified: trunk/LayoutTests/fast/events/before-input-delete-text-target-ranges.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-delete-text-target-ranges.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-delete-text-target-ranges.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -10,9 +10,6 @@
editable.focus();
- if (window.internals)
- internals.settings.setInputEventsEnabled(true);
-
if (window.testRunner) {
select(0, 0);
testRunner.execCommand("deleteForward");
Modified: trunk/LayoutTests/fast/events/before-input-events-different-start-end-elements.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-events-different-start-end-elements.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-events-different-start-end-elements.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -9,7 +9,6 @@
if (!window.eventSender || !window.internals || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
testRunner.dumpAsText();
document.querySelector("#foo").focus();
Modified: trunk/LayoutTests/fast/events/before-input-events-prevent-block-text-direction.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-events-prevent-block-text-direction.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-events-prevent-block-text-direction.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -25,7 +25,6 @@
return;
}
- internals.settings.setInputEventsEnabled(true);
testRunner.dumpAsText();
editor.focus();
write("*** TESTING RICH TEXT ***");
Modified: trunk/LayoutTests/fast/events/before-input-events-prevent-default-in-textfield.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-events-prevent-default-in-textfield.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-events-prevent-default-in-textfield.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -11,7 +11,6 @@
if (!window.eventSender || !window.internals || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
testRunner.dumpAsText();
let input = document.querySelector("#foo");
input.focus();
Modified: trunk/LayoutTests/fast/events/before-input-events-prevent-default.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-events-prevent-default.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-events-prevent-default.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -9,7 +9,6 @@
if (!window.eventSender || !window.internals || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
testRunner.dumpAsText();
document.querySelector("#foo").focus();
eventSender.keyDown("a", []);
Modified: trunk/LayoutTests/fast/events/before-input-events-prevent-drag-and-drop.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-events-prevent-drag-and-drop.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-events-prevent-drag-and-drop.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -28,10 +28,8 @@
<p>HTML content:</p>
<div id="result"></div>
<script type="text/_javascript_">
- if (window.internals && window.testRunner) {
- internals.settings.setInputEventsEnabled(true);
+ if (window.internals && window.testRunner)
testRunner.dumpAsText();
- }
source.focus();
document.execCommand("selectAll");
Modified: trunk/LayoutTests/fast/events/before-input-events-prevent-insert-composition.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-events-prevent-insert-composition.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-events-prevent-insert-composition.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -5,8 +5,6 @@
<script src=""
<script type="text/_javascript_">
Markup.description("To manually test this, try to insert text using IME. No text should be committed to the input.");
- if (window.internals)
- internals.settings.setInputEventsEnabled(true);
editable.focus();
Modified: trunk/LayoutTests/fast/events/before-input-events-prevent-recomposition.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-events-prevent-recomposition.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-events-prevent-recomposition.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -5,8 +5,6 @@
<script src=""
<script type="text/_javascript_">
Markup.description("To manually test this, try to recompose text. The original text should not be modified.");
- if (window.internals)
- internals.settings.setInputEventsEnabled(true);
editable.focus();
Modified: trunk/LayoutTests/fast/events/before-input-prevent-biu.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-prevent-biu.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-prevent-biu.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -10,7 +10,6 @@
if (!window.internals || !window.eventSender || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
document.querySelector("#editable").focus();
eventSender.keyDown("a", []);
Modified: trunk/LayoutTests/fast/events/before-input-prevent-cut.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-prevent-cut.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-prevent-cut.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -11,7 +11,6 @@
if (!window.internals || !window.eventSender || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
document.querySelector("#field").focus();
})();
Modified: trunk/LayoutTests/fast/events/before-input-prevent-paste.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-prevent-paste.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-prevent-paste.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -12,7 +12,6 @@
if (!window.internals || !window.eventSender || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
document.querySelector("input").focus();
})();
Modified: trunk/LayoutTests/fast/events/before-input-prevent-typing.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-prevent-typing.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-prevent-typing.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -11,7 +11,6 @@
if (!window.internals || !window.eventSender || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
document.querySelector("#editable").focus();
Markup.dump("editable", "initially");
Modified: trunk/LayoutTests/fast/events/before-input-prevent-undo.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-prevent-undo.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-prevent-undo.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -11,7 +11,6 @@
if (!window.internals || !window.eventSender || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
document.querySelector("#field").focus();
eventSender.keyDown("a", []);
Modified: trunk/LayoutTests/fast/events/before-input-replace-text-target-ranges.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/before-input-replace-text-target-ranges.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/before-input-replace-text-target-ranges.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -11,7 +11,6 @@
editable.focus();
if (window.eventSender && window.internals) {
- internals.settings.setInputEventsEnabled(true);
eventSender.keyDown("h");
eventSender.keyDown("l");
eventSender.keyDown("l");
Modified: trunk/LayoutTests/fast/events/input-event-insert-link.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-event-insert-link.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-event-insert-link.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -8,10 +8,7 @@
<script type="text/_javascript_">
description("This test verifies that input events of inputType 'insertLink' are dispatched when automatically replacing text with a link.");
if (window.internals)
- {
- internals.settings.setInputEventsEnabled(true);
internals.setAutomaticLinkDetectionEnabled(true);
- }
document.getElementById("editable").focus();
document.execCommand("insertText", true, "www.apple.com ");
Modified: trunk/LayoutTests/fast/events/input-events-drag-and-drop.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-drag-and-drop.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-drag-and-drop.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -25,10 +25,8 @@
<div id="output"></div>
<script type="text/_javascript_">
let write = s => output.innerHTML += s + "<br>";
- if (window.internals && window.testRunner) {
- internals.settings.setInputEventsEnabled(true);
+ if (window.internals && window.testRunner)
testRunner.dumpAsText();
- }
source.focus();
document.execCommand("selectAll");
Modified: trunk/LayoutTests/fast/events/input-events-fired-when-typing.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-fired-when-typing.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-fired-when-typing.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -21,7 +21,6 @@
if (!window.eventSender || !window.internals || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
testRunner.dumpAsText();
contentEditable().focus();
eventSender.keyDown("a", []);
Modified: trunk/LayoutTests/fast/events/input-events-forecolor-data.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-forecolor-data.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-forecolor-data.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -7,8 +7,6 @@
<div id="editable" contenteditable _onbeforeinput_=handleInput(event) _oninput_=handleInput(event)></div>
<script type="text/_javascript_">
description("To manually test this, change the foreground color and check the resulting debug messages.");
- if (window.internals)
- internals.settings.setInputEventsEnabled(true);
document.getElementById("editable").focus();
Modified: trunk/LayoutTests/fast/events/input-events-ime-composition.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-ime-composition.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-ime-composition.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -7,8 +7,6 @@
<input id="editable" contenteditable _onbeforeinput_=logInputEvent(event) _oninput_=logInputEvent(event)></input>
<script type="text/_javascript_">
description("To manually test this, insert text via IME and observe the resulting debug messages.");
- if (window.internals)
- internals.settings.setInputEventsEnabled(true);
editable.addEventListener("compositionend", logCompositionEvent);
editable.focus();
Modified: trunk/LayoutTests/fast/events/input-events-ime-recomposition.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-ime-recomposition.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-ime-recomposition.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -7,8 +7,6 @@
<input id="editable" contenteditable value="abc" _onbeforeinput_=logInputEvent(event) _oninput_=logInputEvent(event)></input>
<script type="text/_javascript_">
description("To manually test this, recompose existing text via IME and observe the resulting debug messages.");
- if (window.internals)
- internals.settings.setInputEventsEnabled(true);
editable.addEventListener("compositionend", logCompositionEvent);
editable.focus();
Modified: trunk/LayoutTests/fast/events/input-events-insert-by-drop.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-insert-by-drop.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-insert-by-drop.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -16,10 +16,8 @@
<textarea id="plainDestination" _onbeforeinput_=logInputEvent(event) _oninput_=logInputEvent(event)></textarea>
<div id="output"></div>
<script type="text/_javascript_">
- if (window.internals && window.testRunner) {
- internals.settings.setInputEventsEnabled(true);
+ if (window.internals && window.testRunner)
testRunner.dumpAsText();
- }
if (window.eventSender) {
moveToCenter(source);
Modified: trunk/LayoutTests/fast/events/input-events-paste-data.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-paste-data.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-paste-data.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -11,8 +11,6 @@
(function() {
if (!window.internals || !window.eventSender || !window.testRunner)
return;
-
- internals.settings.setInputEventsEnabled(true);
document.querySelector("#plain").focus();
})();
Modified: trunk/LayoutTests/fast/events/input-events-paste-rich-datatransfer.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-paste-rich-datatransfer.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-paste-rich-datatransfer.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -10,9 +10,6 @@
source.focus();
document.execCommand("selectAll", false, null);
- if (window.internals)
- internals.settings.setInputEventsEnabled(true);
-
if (window.testRunner) {
testRunner.execCommand("Cut");
testRunner.execCommand("Paste");
Modified: trunk/LayoutTests/fast/events/input-events-selection-forecolor-data.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-selection-forecolor-data.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-selection-forecolor-data.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -7,10 +7,8 @@
<div id="output"></div>
<script type="text/_javascript_">
let write = s => output.innerHTML += s + "<br>";
- if (window.internals) {
+ if (window.internals)
testRunner.dumpAsText();
- internals.settings.setInputEventsEnabled(true);
- }
document.getElementById("editable").focus();
Modified: trunk/LayoutTests/fast/events/input-events-spell-checking-datatransfer.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-spell-checking-datatransfer.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-spell-checking-datatransfer.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -9,7 +9,6 @@
source.focus();
if (window.internals && window.eventSender) {
- internals.settings.setInputEventsEnabled(true);
eventSender.keyDown("e", []);
eventSender.keyDown("s", []);
eventSender.keyDown("c", []);
Modified: trunk/LayoutTests/fast/events/input-events-typing-data.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/input-events-typing-data.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/input-events-typing-data.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -13,8 +13,6 @@
if (!window.internals || !window.eventSender || !window.testRunner)
return;
- internals.settings.setInputEventsEnabled(true);
-
document.querySelector("#plain").focus();
simulateTypingWithReplacement(false);
Modified: trunk/LayoutTests/fast/events/ios/input-events-fired-when-typing-in-contenteditable.html (288802 => 288803)
--- trunk/LayoutTests/fast/events/ios/input-events-fired-when-typing-in-contenteditable.html 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/LayoutTests/fast/events/ios/input-events-fired-when-typing-in-contenteditable.html 2022-01-30 23:24:38 UTC (rev 288803)
@@ -22,7 +22,6 @@
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.waitUntilDone();
- internals.settings.setInputEventsEnabled(true);
}
function incrementProgress()
Modified: trunk/Source/WTF/ChangeLog (288802 => 288803)
--- trunk/Source/WTF/ChangeLog 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/Source/WTF/ChangeLog 2022-01-30 23:24:38 UTC (rev 288803)
@@ -1,3 +1,12 @@
+2022-01-30 Ryosuke Niwa <[email protected]>
+
+ Delete runtime preference for enabling input events
+ https://bugs.webkit.org/show_bug.cgi?id=235864
+
+ Reviewed by Wenson Hsieh.
+
+ * Scripts/Preferences/WebPreferences.yaml:
+
2022-01-29 Ryosuke Niwa <[email protected]>
Delete runtime preference for enabling request animation frame
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (288802 => 288803)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml 2022-01-30 23:24:38 UTC (rev 288803)
@@ -954,18 +954,6 @@
"PLATFORM(IOS_FAMILY)": true
default: false
-InputEventsEnabled:
- type: bool
- humanReadableName: "Input Events"
- humanReadableDescription: "Enable InputEvents support"
- defaultValue:
- WebKitLegacy:
- default: true
- WebKit:
- default: true
- WebCore:
- default: true
-
InspectorAdditionsEnabled:
type: bool
humanReadableName: "Web Inspector Additions"
Modified: trunk/Source/WebCore/ChangeLog (288802 => 288803)
--- trunk/Source/WebCore/ChangeLog 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/Source/WebCore/ChangeLog 2022-01-30 23:24:38 UTC (rev 288803)
@@ -1,3 +1,13 @@
+2022-01-30 Ryosuke Niwa <[email protected]>
+
+ Delete runtime preference for enabling input events
+ https://bugs.webkit.org/show_bug.cgi?id=235864
+
+ Reviewed by Wenson Hsieh.
+
+ * dom/InputEvent.idl:
+ * editing/Editor.cpp:
+
2022-01-30 Alan Bujtas <[email protected]>
(REGRESSION)[IFC][RTL] wpt/css/css-text/white-space/trailing-space-and-text-alignment-rtl-003.html
Modified: trunk/Source/WebCore/dom/InputEvent.idl (288802 => 288803)
--- trunk/Source/WebCore/dom/InputEvent.idl 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/Source/WebCore/dom/InputEvent.idl 2022-01-30 23:24:38 UTC (rev 288803)
@@ -24,7 +24,6 @@
*/
[
- EnabledBySetting=InputEventsEnabled,
Exposed=Window
] interface InputEvent : UIEvent {
constructor(DOMString type, optional InputEventInit eventInitDict);
Modified: trunk/Source/WebCore/editing/Editor.cpp (288802 => 288803)
--- trunk/Source/WebCore/editing/Editor.cpp 2022-01-30 16:57:38 UTC (rev 288802)
+++ trunk/Source/WebCore/editing/Editor.cpp 2022-01-30 23:24:38 UTC (rev 288803)
@@ -139,9 +139,6 @@
static bool dispatchBeforeInputEvent(Element& element, const AtomString& inputType, const String& data = { }, RefPtr<DataTransfer>&& dataTransfer = nullptr, const Vector<RefPtr<StaticRange>>& targetRanges = { }, Event::IsCancelable cancelable = Event::IsCancelable::Yes)
{
- if (!element.document().settings().inputEventsEnabled())
- return true;
-
auto event = InputEvent::create(eventNames().beforeinputEvent, inputType, cancelable, element.document().windowProxy(), data, WTFMove(dataTransfer), targetRanges, 0);
element.dispatchEvent(event);
return !event->defaultPrevented();
@@ -149,15 +146,12 @@
static void dispatchInputEvent(Element& element, const AtomString& inputType, const String& data = { }, RefPtr<DataTransfer>&& dataTransfer = nullptr, const Vector<RefPtr<StaticRange>>& targetRanges = { })
{
- if (element.document().settings().inputEventsEnabled()) {
- // FIXME: We should not be dispatching to the scoped queue here. Normally, input events are dispatched in CompositeEditCommand::apply after the end of the scope,
- // but TypingCommands are special in that existing TypingCommands that are applied again fire input events *from within* the scope by calling typingAddedToOpenCommand.
- // Instead, TypingCommands should always dispatch events synchronously after the end of the scoped queue in CompositeEditCommand::apply. To work around this for the
- // time being, just revert back to calling dispatchScopedEvent.
- element.dispatchScopedEvent(InputEvent::create(eventNames().inputEvent, inputType, Event::IsCancelable::No,
- element.document().windowProxy(), data, WTFMove(dataTransfer), targetRanges, 0));
- } else
- element.dispatchInputEvent();
+ // FIXME: We should not be dispatching to the scoped queue here. Normally, input events are dispatched in CompositeEditCommand::apply after the end of the scope,
+ // but TypingCommands are special in that existing TypingCommands that are applied again fire input events *from within* the scope by calling typingAddedToOpenCommand.
+ // Instead, TypingCommands should always dispatch events synchronously after the end of the scoped queue in CompositeEditCommand::apply. To work around this for the
+ // time being, just revert back to calling dispatchScopedEvent.
+ element.dispatchScopedEvent(InputEvent::create(eventNames().inputEvent, inputType, Event::IsCancelable::No,
+ element.document().windowProxy(), data, WTFMove(dataTransfer), targetRanges, 0));
}
static String inputEventDataForEditingStyleAndAction(const StyleProperties* style, EditAction action)
