Title: [288825] trunk/Source/WebKit
Revision
288825
Author
[email protected]
Date
2022-01-31 11:36:30 -0800 (Mon, 31 Jan 2022)

Log Message

[WP] Remove PostScript conversion code
https://bugs.webkit.org/show_bug.cgi?id=235892
<rdar://88172449>

Reviewed by Brent Fulgham.

The WebContent process no longer has access to the PostScript conversion service, so there is no need to keep this code.

* WebProcess/Plugins/PDF/PDFPlugin.h:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::streamDidFinishLoading):
(WebKit::PDFPlugin::manualStreamDidFinishLoading):
(WebKit::PDFPlugin::convertPostScriptDataIfNeeded): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (288824 => 288825)


--- trunk/Source/WebKit/ChangeLog	2022-01-31 19:29:37 UTC (rev 288824)
+++ trunk/Source/WebKit/ChangeLog	2022-01-31 19:36:30 UTC (rev 288825)
@@ -1,5 +1,21 @@
 2022-01-31  Per Arne Vollan  <[email protected]>
 
+        [WP] Remove PostScript conversion code
+        https://bugs.webkit.org/show_bug.cgi?id=235892
+        <rdar://88172449>
+
+        Reviewed by Brent Fulgham.
+
+        The WebContent process no longer has access to the PostScript conversion service, so there is no need to keep this code.
+
+        * WebProcess/Plugins/PDF/PDFPlugin.h:
+        * WebProcess/Plugins/PDF/PDFPlugin.mm:
+        (WebKit::PDFPlugin::streamDidFinishLoading):
+        (WebKit::PDFPlugin::manualStreamDidFinishLoading):
+        (WebKit::PDFPlugin::convertPostScriptDataIfNeeded): Deleted.
+
+2022-01-31  Per Arne Vollan  <[email protected]>
+
         [iOS][WP] Restrict image decoders
         https://bugs.webkit.org/show_bug.cgi?id=234175
 

Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h (288824 => 288825)


--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h	2022-01-31 19:29:37 UTC (rev 288824)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h	2022-01-31 19:36:30 UTC (rev 288825)
@@ -288,8 +288,6 @@
     JSObjectRef makeJSPDFDoc(JSContextRef);
     static JSValueRef jsPDFDocPrint(JSContextRef, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception);
 
-    void convertPostScriptDataIfNeeded();
-
     void setSuggestedFilename(const String&);
 
     // Regular plug-ins don't need access to view, but we add scrollbars to embedding FrameView for proper event handling.

Modified: trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm (288824 => 288825)


--- trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm	2022-01-31 19:29:37 UTC (rev 288824)
+++ trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm	2022-01-31 19:36:30 UTC (rev 288825)
@@ -1623,14 +1623,6 @@
     return JSObjectMake(ctx, jsPDFDocClass, this);
 }
 
-void PDFPlugin::convertPostScriptDataIfNeeded()
-{
-    if (!m_isPostScript)
-        return;
-
-    m_data = PDFDocumentImage::convertPostScriptDataToPDF(WTFMove(m_data));
-}
-
 void PDFPlugin::documentDataDidFinishLoading()
 {
     if (m_hasBeenDestroyed)
@@ -1734,7 +1726,6 @@
 {
     ASSERT_UNUSED(streamID, streamID == pdfDocumentRequestID);
 
-    convertPostScriptDataIfNeeded();
     documentDataDidFinishLoading();
 }
 
@@ -1796,7 +1787,6 @@
 
 void PDFPlugin::manualStreamDidFinishLoading()
 {
-    convertPostScriptDataIfNeeded();
     documentDataDidFinishLoading();
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to