Title: [288827] trunk
- Revision
- 288827
- Author
- [email protected]
- Date
- 2022-01-31 12:08:45 -0800 (Mon, 31 Jan 2022)
Log Message
Source/WebCore:
Changed playbackRate and defaultPlaybackRate from unrestricted double
to double.
https://bugs.webkit.org/show_bug.cgi?id=235174
rdar://problem/87815745
Patch by Takeshi Sone <[email protected]> on 2022-01-31
Reviewed by Eric Carlson.
Test: media/video-playbackrate-undefined.html
* html/HTMLMediaElement.idl:
LayoutTests:
Added a test to verify that setting undefined to video.playbackRate
raises an exception.
https://bugs.webkit.org/show_bug.cgi?id=235174
rdar://problem/87815745
Patch by Takeshi Sone <[email protected]> on 2022-01-31
Reviewed by Eric Carlson.
* media/video-playbackrate-undefined-expected.txt: Added.
* media/video-playbackrate-undefined.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (288826 => 288827)
--- trunk/LayoutTests/ChangeLog 2022-01-31 19:51:51 UTC (rev 288826)
+++ trunk/LayoutTests/ChangeLog 2022-01-31 20:08:45 UTC (rev 288827)
@@ -1,3 +1,15 @@
+2022-01-31 Takeshi Sone <[email protected]>
+
+ Added a test to verify that setting undefined to video.playbackRate
+ raises an exception.
+ https://bugs.webkit.org/show_bug.cgi?id=235174
+ rdar://problem/87815745
+
+ Reviewed by Eric Carlson.
+
+ * media/video-playbackrate-undefined-expected.txt: Added.
+ * media/video-playbackrate-undefined.html: Added.
+
2022-01-31 Asumu Takikawa <[email protected]>
Fix handling of module script errors in WebCore
Added: trunk/LayoutTests/media/video-playbackrate-undefined-expected.txt (0 => 288827)
--- trunk/LayoutTests/media/video-playbackrate-undefined-expected.txt (rev 0)
+++ trunk/LayoutTests/media/video-playbackrate-undefined-expected.txt 2022-01-31 20:08:45 UTC (rev 288827)
@@ -0,0 +1,5 @@
+
+TEST(video.playbackRate = undefined) THROWS('TypeError: The provided value is non-finite') OK
+TEST(video.defaultPlaybackRate = undefined) THROWS('TypeError: The provided value is non-finite') OK
+END OF TEST
+
Added: trunk/LayoutTests/media/video-playbackrate-undefined.html (0 => 288827)
--- trunk/LayoutTests/media/video-playbackrate-undefined.html (rev 0)
+++ trunk/LayoutTests/media/video-playbackrate-undefined.html 2022-01-31 20:08:45 UTC (rev 288827)
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html>
+ <head>
+ <title>Setting undefined to playbackRate and defaultPlaybackRate</title>
+ </head>
+ <body>
+ <video></video>
+ <script src=""
+ <script>
+ testException(
+ "video.playbackRate = undefined",
+ "'TypeError: The provided value is non-finite'"
+ );
+ testException(
+ "video.defaultPlaybackRate = undefined",
+ "'TypeError: The provided value is non-finite'"
+ );
+ endTest();
+ </script>
+ </body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (288826 => 288827)
--- trunk/Source/WebCore/ChangeLog 2022-01-31 19:51:51 UTC (rev 288826)
+++ trunk/Source/WebCore/ChangeLog 2022-01-31 20:08:45 UTC (rev 288827)
@@ -1,3 +1,16 @@
+2022-01-31 Takeshi Sone <[email protected]>
+
+ Changed playbackRate and defaultPlaybackRate from unrestricted double
+ to double.
+ https://bugs.webkit.org/show_bug.cgi?id=235174
+ rdar://problem/87815745
+
+ Reviewed by Eric Carlson.
+
+ Test: media/video-playbackrate-undefined.html
+
+ * html/HTMLMediaElement.idl:
+
2022-01-31 Asumu Takikawa <[email protected]>
Fix handling of module script errors in WebCore
Modified: trunk/Source/WebCore/html/HTMLMediaElement.idl (288826 => 288827)
--- trunk/Source/WebCore/html/HTMLMediaElement.idl 2022-01-31 19:51:51 UTC (rev 288826)
+++ trunk/Source/WebCore/html/HTMLMediaElement.idl 2022-01-31 20:08:45 UTC (rev 288827)
@@ -75,8 +75,8 @@
readonly attribute unrestricted double duration;
Date getStartDate();
readonly attribute boolean paused;
- attribute unrestricted double defaultPlaybackRate;
- attribute unrestricted double playbackRate;
+ attribute double defaultPlaybackRate;
+ attribute double playbackRate;
readonly attribute TimeRanges played;
readonly attribute TimeRanges seekable;
readonly attribute boolean ended;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
