Diff
Modified: trunk/ChangeLog (288868 => 288869)
--- trunk/ChangeLog 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/ChangeLog 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,3 +1,13 @@
+2022-02-01 Tim Nguyen <[email protected]>
+
+ Entirely remove support for -apple-trailing-word
+ https://bugs.webkit.org/show_bug.cgi?id=234672
+
+ Reviewed by Simon Fraser.
+
+ * Source/cmake/OptionsMac.cmake:
+ * Source/cmake/WebKitFeatures.cmake:
+
2022-01-28 Elliott Williams <[email protected]>
[XCBuild] Small corrections to build-webkit and Makefile for workspace builds
Modified: trunk/LayoutTests/ChangeLog (288868 => 288869)
--- trunk/LayoutTests/ChangeLog 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/ChangeLog 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,3 +1,17 @@
+2022-02-01 Tim Nguyen <[email protected]>
+
+ Entirely remove support for -apple-trailing-word
+ https://bugs.webkit.org/show_bug.cgi?id=234672
+
+ Reviewed by Simon Fraser.
+
+ * fast/text/trailing-word-detection-expected.txt: Removed.
+ * fast/text/trailing-word-detection.html: Removed.
+ * platform/glib/TestExpectations:
+ * platform/win/TestExpectations:
+ * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+
2022-01-31 Said Abou-Hallawa <[email protected]>
[GPU Process] Pattern should hold SourceImage which can be converted to a NativeImage only when needed
Deleted: trunk/LayoutTests/fast/text/trailing-word-detection-expected.txt (288868 => 288869)
--- trunk/LayoutTests/fast/text/trailing-word-detection-expected.txt 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/fast/text/trailing-word-detection-expected.txt 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,6 +0,0 @@
-PASS '-apple-trailing-word' in element.style is true
-PASS window.getComputedStyle(element).getPropertyValue('color') is "rgb(0, 128, 0)"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/fast/text/trailing-word-detection.html (288868 => 288869)
--- trunk/LayoutTests/fast/text/trailing-word-detection.html 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/fast/text/trailing-word-detection.html 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,22 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-<style>
-@supports (-apple-trailing-word: auto) {
- #test {
- color: rgb(0, 128, 0);
- }
-}
-</style>
-</head>
-<body>
-<div id="test"></div>
-<script>
-let element = document.getElementById("test");
-shouldBeTrue("'-apple-trailing-word' in element.style");
-shouldBeEqualToString("window.getComputedStyle(element).getPropertyValue('color')", "rgb(0, 128, 0)");
-</script>
-<script src=""
-</body>
-</html>
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (288868 => 288869)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,3 +1,13 @@
+2022-02-01 Tim Nguyen <[email protected]>
+
+ Entirely remove support for -apple-trailing-word
+ https://bugs.webkit.org/show_bug.cgi?id=234672
+
+ Reviewed by Simon Fraser.
+
+ * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
+ * web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt:
+
2022-01-31 Asumu Takikawa <[email protected]>
Fix handling of module script errors in WebCore
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (288868 => 288869)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-02-01 09:33:02 UTC (rev 288869)
@@ -336,7 +336,6 @@
PASS -apple-color-filter
PASS -apple-pay-button-style
PASS -apple-pay-button-type
-PASS -apple-trailing-word
PASS -webkit-backdrop-filter
PASS -webkit-background-clip
PASS -webkit-background-origin
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (288868 => 288869)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 398
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 398
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 398
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 398
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 397
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 397
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 397
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 397
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/platform/glib/TestExpectations (288868 => 288869)
--- trunk/LayoutTests/platform/glib/TestExpectations 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2022-02-01 09:33:02 UTC (rev 288869)
@@ -2092,7 +2092,6 @@
webkit.org/b/160246 fast/text/multiple-feature-properties.html [ ImageOnlyFailure ]
webkit.org/b/160248 fast/text/combining-mark-paint.html [ ImageOnlyFailure ]
webkit.org/b/160248 fast/text/synthetic-bold-transformed.html [ ImageOnlyFailure ]
-webkit.org/b/160248 fast/text/trailing-word-detection.html [ Failure ]
webkit.org/b/160249 fast/shrink-wrap/rect-shrink-wrap.html [ ImageOnlyFailure ]
webkit.org/b/161583 accessibility/auto-fill-types.html [ Timeout ]
webkit.org/b/161589 css3/masking/mask-repeat-space-padding.html [ ImageOnlyFailure ]
Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt (288868 => 288869)
--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt 2022-02-01 09:33:02 UTC (rev 288869)
@@ -304,7 +304,6 @@
PASS -apple-color-filter
PASS -apple-pay-button-style
PASS -apple-pay-button-type
-PASS -apple-trailing-word
PASS -webkit-appearance
PASS -webkit-backdrop-filter
PASS -webkit-backface-visibility
Modified: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt (288868 => 288869)
--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-detached-subtree-expected.txt 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,8 +1,8 @@
PASS getComputedStyle returns no style for detached element
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 400
-FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 400
-FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 400
-FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 400
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) assert_equals: expected 0 but got 399
+FAIL getComputedStyle returns no style for element in non-rendered iframe (display: none) from iframe's window assert_equals: expected 0 but got 399
+FAIL getComputedStyle returns no style for element outside the flat tree assert_equals: expected 0 but got 399
+FAIL getComputedStyle returns no style for descendant outside the flat tree assert_equals: expected 0 but got 399
PASS getComputedStyle returns no style for shadow tree outside of flattened tree
Modified: trunk/LayoutTests/platform/win/TestExpectations (288868 => 288869)
--- trunk/LayoutTests/platform/win/TestExpectations 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/LayoutTests/platform/win/TestExpectations 2022-02-01 09:33:02 UTC (rev 288869)
@@ -2951,7 +2951,6 @@
fast/ruby/ruby-expansion-cjk-5.html [ ImageOnlyFailure ]
fast/text/combining-mark-paint.html [ ImageOnlyFailure ]
fast/text/synthetic-bold-transformed.html [ ImageOnlyFailure ]
-fast/text/trailing-word-detection.html [ Failure ]
# TestRunner::addChromeInputField() and focusWebView() not implemented
fast/forms/focus-option-control-on-page.html [ Skip ]
Modified: trunk/Source/WTF/ChangeLog (288868 => 288869)
--- trunk/Source/WTF/ChangeLog 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Source/WTF/ChangeLog 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,3 +1,12 @@
+2022-02-01 Tim Nguyen <[email protected]>
+
+ Entirely remove support for -apple-trailing-word
+ https://bugs.webkit.org/show_bug.cgi?id=234672
+
+ Reviewed by Simon Fraser.
+
+ * wtf/PlatformEnableCocoa.h:
+
2022-01-31 Ryosuke Niwa <[email protected]>
Delete runtime flag for subresource integrity
Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (288868 => 288869)
--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2022-02-01 09:33:02 UTC (rev 288869)
@@ -187,10 +187,6 @@
#define ENABLE_CSS_SELECTORS_LEVEL4 1
#endif
-#if !defined(ENABLE_CSS_TRAILING_WORD)
-#define ENABLE_CSS_TRAILING_WORD 1
-#endif
-
#if !defined(ENABLE_CSS_TYPED_OM)
#define ENABLE_CSS_TYPED_OM 1
#endif
Modified: trunk/Source/WebCore/ChangeLog (288868 => 288869)
--- trunk/Source/WebCore/ChangeLog 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Source/WebCore/ChangeLog 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,3 +1,13 @@
+2022-02-01 Tim Nguyen <[email protected]>
+
+ Entirely remove support for -apple-trailing-word
+ https://bugs.webkit.org/show_bug.cgi?id=234672
+
+ Reviewed by Simon Fraser.
+
+ * css/CSSProperties.json:
+ * css/CSSValueKeywords.in:
+
2022-01-31 Myles C. Maxfield <[email protected]>
Rename FontCascade::fontMetrics() and RenderStyle::fontMetrics() to fontMetricsOfPrimaryFont()
Modified: trunk/Source/WebCore/css/CSSProperties.json (288868 => 288869)
--- trunk/Source/WebCore/css/CSSProperties.json 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Source/WebCore/css/CSSProperties.json 2022-02-01 09:33:02 UTC (rev 288869)
@@ -7648,19 +7648,10 @@
"status": "non-standard"
},
"-apple-trailing-word": {
- "inherited": true,
- "values": [
- "auto",
- "-webkit-partially-balanced"
- ],
"codegen-properties": {
- "name-for-methods": "TrailingWord",
- "enable-if": "ENABLE_CSS_TRAILING_WORD"
+ "skip-codegen": true
},
- "status": {
- "status": "non-standard",
- "comment": "Needed for feature-detecting the Safari browser. Implementation has no effect."
- }
+ "status": "removed"
},
"-apple-pay-button-style": {
"codegen-properties": {
Modified: trunk/Source/WebCore/css/CSSValueKeywords.in (288868 => 288869)
--- trunk/Source/WebCore/css/CSSValueKeywords.in 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Source/WebCore/css/CSSValueKeywords.in 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1432,11 +1432,6 @@
// -webkit-column-fill
balance
-#if defined(ENABLE_CSS_TRAILING_WORD) && ENABLE_CSS_TRAILING_WORD
-// -apple-trailing-word
--webkit-partially-balanced
-#endif
-
#if defined(ENABLE_APPLE_PAY) && ENABLE_APPLE_PAY
// -apple-pay-button-style
white-outline
Modified: trunk/Source/cmake/OptionsMac.cmake (288868 => 288869)
--- trunk/Source/cmake/OptionsMac.cmake 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Source/cmake/OptionsMac.cmake 2022-02-01 09:33:02 UTC (rev 288869)
@@ -20,7 +20,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_CONIC_GRADIENTS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TRAILING_WORD PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURSOR_VISIBILITY PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DARK_MODE_CSS PRIVATE ON)
Modified: trunk/Source/cmake/WebKitFeatures.cmake (288868 => 288869)
--- trunk/Source/cmake/WebKitFeatures.cmake 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2022-02-01 09:33:02 UTC (rev 288869)
@@ -127,7 +127,6 @@
WEBKIT_OPTION_DEFINE(ENABLE_CSS_IMAGE_RESOLUTION "Toggle CSS image-resolution support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_CSS_PAINTING_API "Toggle CSS Painting API support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_CSS_SELECTORS_LEVEL4 "Toggle CSS Selectors Level 4 support" PRIVATE ON)
- WEBKIT_OPTION_DEFINE(ENABLE_CSS_TRAILING_WORD "Toggle css trailing word" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_CSS_TYPED_OM "Toggle CSS Typed OM support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_CURSOR_VISIBILITY "Toggle cursor visibility support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_C_LOOP "Enable CLoop interpreter" PRIVATE ${ENABLE_C_LOOP_DEFAULT})
Modified: trunk/Tools/ChangeLog (288868 => 288869)
--- trunk/Tools/ChangeLog 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Tools/ChangeLog 2022-02-01 09:33:02 UTC (rev 288869)
@@ -1,3 +1,12 @@
+2022-02-01 Tim Nguyen <[email protected]>
+
+ Entirely remove support for -apple-trailing-word
+ https://bugs.webkit.org/show_bug.cgi?id=234672
+
+ Reviewed by Simon Fraser.
+
+ * Scripts/webkitperl/FeatureList.pm:
+
2022-01-31 Megan Gardner <[email protected]>
Collapsed ranges return zero rects in DocumentContext
Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (288868 => 288869)
--- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2022-02-01 07:44:05 UTC (rev 288868)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm 2022-02-01 09:33:02 UTC (rev 288869)
@@ -259,9 +259,6 @@
{ option => "css-selectors-level4", desc => "Toggle CSS Selectors Level 4 support",
define => "ENABLE_CSS_SELECTORS_LEVEL4", value => \$cssSelectorsLevel4Support },
- { option => "css-trailing-word", desc => "Toggle css trailing word",
- define => "ENABLE_CSS_TRAILING_WORD", value => \$cssTrailingWordSupport },
-
{ option => "css-typed-om", desc => "Toggle CSS Typed OM support",
define => "ENABLE_CSS_TYPED_OM", value => \$cssTypedOMSupport },
